From 27793c718d6c20fb8b2a3000051070e82ac0b846 Mon Sep 17 00:00:00 2001 From: Guillaume Gomez Date: Sun, 1 Mar 2026 20:34:45 +0100 Subject: [PATCH] Handle JSON generation like other errors instead of bailing out --- .../src/docbuilder/rustwide_builder.rs | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/crates/bin/docs_rs_builder/src/docbuilder/rustwide_builder.rs b/crates/bin/docs_rs_builder/src/docbuilder/rustwide_builder.rs index 1cf2071d5..67bf9021c 100644 --- a/crates/bin/docs_rs_builder/src/docbuilder/rustwide_builder.rs +++ b/crates/bin/docs_rs_builder/src/docbuilder/rustwide_builder.rs @@ -1137,7 +1137,7 @@ impl RustwideBuilder { } }; - if let Err(err) = self.execute_json_build( + self.execute_json_build( build_id, name, version, @@ -1146,16 +1146,7 @@ impl RustwideBuilder { build, metadata, limits, - ) { - // FIXME: this is temporary. Theoretically all `Err` things coming out - // of the method should be retryable, so we could juse use `?` here. - // But since this is new, I want to be carful and first see what kind of - // errors we are seeing here. - error!( - ?err, - "internal error when trying to generate rustdoc JSON output" - ); - } + )?; let result = { let _span = info_span!("cargo_build", target = %target, is_default_target).entered();