fixed version issue

Author: Robin Stolpe

.src/private/function/Confirm-RSWinGet.ps1

@@ -57,12 +57,10 @@
             [System.Object]$GithubInfoRestData = Invoke-RestMethod -Uri $GitHubUrl -Method Get -Headers $GithubHeaders -TimeoutSec 10 | Select-Object -Property assets, tag_name
         }
 
-        [string]$latestVersion = $GithubInfoRestData.tag_name.Substring(1)
-
         [System.Object]$GitHubInfo = [PSCustomObject]@{
-            Tag         = $latestVersion
+            Tag         = $($GithubInfoRestData.tag_name.Substring(1))
             DownloadUrl = $GithubInfoRestData.assets | where-object { $_.name -like "*.msixbundle" } | Select-Object -ExpandProperty browser_download_url
-            OutFile     = "$env:TEMP\WinGet_$($latestVersion).msixbundle"
+            OutFile     = "$env:TEMP\WinGet_$($GithubInfoRestData.tag_name.Substring(1)).msixbundle"
         }
     }
     catch {
@@ -74,7 +72,10 @@
     }
 
     # Checking if the installed version of WinGet are the same as the latest version of WinGet
-    if ([Version]$WinGet -lt [Version]$GitHubInfo.Tag) {
+    [version]$vWinGet = [string]$WinGet
+    [version]$vGitHub = [string]$GitHubInfo.Tag
+
+    if ([Version]$vWinGet -lt [Version]$vGitHub) {
         Write-Output "WinGet has a newer version $($GitHubInfo.Tag), downloading and installing it..."
         Invoke-WebRequest -UseBasicParsing -Uri $GitHubInfo.DownloadUrl -OutFile $GitHubInfo.OutFile
 

.src/private/function/Get-RSInstallInfo.ps1

@@ -54,7 +54,7 @@
     # Collects everything in pscustomobject to get easier access to the information
     [System.Object]$SysInfo = [PSCustomObject]@{
         VCLibs           = $(Get-AppxPackage -Name "Microsoft.VCLibs.140.00" -AllUsers | Where-Object { $_.Architecture -eq $Arch })
-        WinGet           = $(try { (Get-AppxPackage -AllUsers | Where-Object { $_.name -like "Microsoft.DesktopAppInstaller" }).version } catch { "no" })
+        WinGet           = $(try { (Get-AppxPackage -AllUsers | Where-Object { $_.name -like "Microsoft.DesktopAppInstaller" } | Sort-Object { $_.Version -as [version] } -Descending | Select-Object Version -First 1).version } catch { "no" })
         VisualCRedistUrl = $VisualCRedistUrl
         $VCLibsUrl       = $VCLibsUrl
         Arch             = $Arch

RSModuleBuilder.ps1

@@ -4,7 +4,7 @@
 [string]$Author = "Robin Stolpe"
 [string]$Mail = "robin@stolpe.io"
 [string]$Website = "https://stolpe.io"
-[string]$preRelease = "beta2"
+[string]$preRelease = ""
 [string]$Company = "Stolpe.io"
 [string]$apiKey = ""
 #

WinSoftwareUpdate/WinSoftwareUpdate.psd1

@@ -134,7 +134,7 @@
             ReleaseNotes = 'https://github.com/rstolpe/WinSoftwareUpdate/releases'
 
             # Prerelease string of this module
-            Prerelease = 'beta2'
+            Prerelease = ''
 
             # Flag to indicate whether the module requires explicit user acceptance for install/update/save
             RequireLicenseAcceptance = $false

WinSoftwareUpdate/WinSoftwareUpdate.psm1

@@ -160,12 +160,10 @@ Function Confirm-RSWinGet {
             [System.Object]$GithubInfoRestData = Invoke-RestMethod -Uri $GitHubUrl -Method Get -Headers $GithubHeaders -TimeoutSec 10 | Select-Object -Property assets, tag_name
         }
 
-        [string]$latestVersion = $GithubInfoRestData.tag_name.Substring(1)
-
         [System.Object]$GitHubInfo = [PSCustomObject]@{
-            Tag         = $latestVersion
+            Tag         = $($GithubInfoRestData.tag_name.Substring(1))
             DownloadUrl = $GithubInfoRestData.assets | where-object { $_.name -like "*.msixbundle" } | Select-Object -ExpandProperty browser_download_url
-            OutFile     = "$env:TEMP\WinGet_$($latestVersion).msixbundle"
+            OutFile     = "$env:TEMP\WinGet_$($GithubInfoRestData.tag_name.Substring(1)).msixbundle"
         }
     }
     catch {
@@ -177,7 +175,10 @@ Function Confirm-RSWinGet {
     }
 
     # Checking if the installed version of WinGet are the same as the latest version of WinGet
-    if ([Version]$WinGet -lt [Version]$GitHubInfo.Tag) {
+    [version]$vWinGet = [string]$WinGet
+    [version]$vGitHub = [string]$GitHubInfo.Tag
+
+    if ([Version]$vWinGet -lt [Version]$vGitHub) {
         Write-Output "WinGet has a newer version $($GitHubInfo.Tag), downloading and installing it..."
         Invoke-WebRequest -UseBasicParsing -Uri $GitHubInfo.DownloadUrl -OutFile $GitHubInfo.OutFile
 
@@ -244,7 +245,7 @@ Function Get-RSInstallInfo {
     # Collects everything in pscustomobject to get easier access to the information
     [System.Object]$SysInfo = [PSCustomObject]@{
         VCLibs           = $(Get-AppxPackage -Name "Microsoft.VCLibs.140.00" -AllUsers | Where-Object { $_.Architecture -eq $Arch })
-        WinGet           = $(try { (Get-AppxPackage -AllUsers | Where-Object { $_.name -like "Microsoft.DesktopAppInstaller" }).version } catch { "no" })
+        WinGet           = $(try { (Get-AppxPackage -AllUsers | Where-Object { $_.name -like "Microsoft.DesktopAppInstaller" } | Sort-Object { $_.Version -as [version] } -Descending | Select-Object Version -First 1).version } catch { "no" })
         VisualCRedistUrl = $VisualCRedistUrl
         $VCLibsUrl       = $VCLibsUrl
         Arch             = $Arch

test/PSScriptAnalyzer_WinSoftwareUpdate.psm1_2023-01-18.md

@@ -11,7 +11,7 @@ RuleSuppressionID    :
 SuggestedCorrections : 
 IsSuppressed         : False
 
-Line                 : 306
+Line                 : 307
 Column               : 10
 Message              : Function 'Start-RSWinGet' has verb that could change system state. Therefore, the function has to support 'ShouldProcess'.
 Extent               : Start-RSWinGet