Merge pull request #5 from rstolpe/dev

Fixed param issue

Author: Robin Stolpe

.src/private/function/Confirm-RSWinGet.ps1

@@ -36,11 +36,11 @@
         [string]$GitHubUrl,
         [Parameter(Mandatory = $true, HelpMessage = "The headers and API version for the GitHub API")]
         [hashtable]$GithubHeaders,
-        [Parameter(Mandatory = $true, HelpMessage = "Information about the installed version of WinGet")]
+        [Parameter(Mandatory = $false, HelpMessage = "Information about the installed version of WinGet")]
         [string]$WinGet
     )
 
-    if ($null -eq $WinGet) {
+    if ($WinGet -eq "No") {
         Write-Output = "WinGet is not installed, downloading and installing WinGet..."
     }
     else {

.src/private/function/Get-RSInstallInfo.ps1

@@ -54,7 +54,7 @@
     # Collects everything in pscustomobject to get easier access to the information
     [System.Object]$SysInfo = [PSCustomObject]@{
         VCLibs           = $(Get-AppxPackage -Name "Microsoft.VCLibs.140.00" -AllUsers | Where-Object { $_.Architecture -eq $Arch })
-        WinGet           = $(try { (Get-AppxPackage -Name Microsoft.DesktopAppInstaller).version } catch { $Null })
+        WinGet           = $(try { (Get-AppxPackage -Name Microsoft.DesktopAppInstaller).version } catch { "No" })
         VisualCRedistUrl = $VisualCRedistUrl
         $VCLibsUrl       = $VCLibsUrl
         Arch             = $Arch

.src/public/function/Update-RSWinSoftware.ps1

@@ -66,8 +66,8 @@
     [System.Object]$SysInfo = Get-RSInstallInfo
 
     # If user has choosen to skip the WinGet version don't check, if WinGet is not installed this will install WinGet anyway.
-    if ($SkipVersionCheck -eq $false -or $null -eq $SysInfo.WinGet) {
-        Confirm-RSWinGet -GitHubUrl $GitHubUrl -GithubHeaders $GithubHeaders
+    if ($SkipVersionCheck -eq $false -or $SysInfo.WinGet -eq "No") {
+        Confirm-RSWinGet -GitHubUrl $GitHubUrl -GithubHeaders $GithubHeaders -WinGet $SysInfo.WinGet
     }
 
     # If VCLibs are not installed it will get installed

Help/Confirm-RSWinGet.md

@@ -8,7 +8,7 @@ SYNOPSIS
 
 
 SYNTAX
-    Confirm-RSWinGet [-GitHubUrl] <String> [-GithubHeaders] <Hashtable> [-WinGet] <String> [<CommonParameters>]
+    Confirm-RSWinGet [-GitHubUrl] <String> [-GithubHeaders] <Hashtable> [[-WinGet] <String>] [<CommonParameters>]
 
 
 DESCRIPTION
@@ -37,7 +37,7 @@ PARAMETERS
 
     -WinGet <String>
 
-        Required?                    true
+        Required?                    false
         Position?                    3
         Default value                
         Accept pipeline input?       false

README.md

@@ -8,6 +8,9 @@ This module will let you update your installed software with WinGet, many of the
 This module is perfect for people like me that are to lazy to update every singel software all the time, it's much easier to just run a PowerShell Script.  
 I have added the result from PSScriptAnalyzer in [test folder](https://github.com/rstolpe/WinSoftwareUpdate/tree/main/test) I have some ShouldProcess warnings in this module but that's nothing to worry about really.
 
+# Note
+This module are only supported with PowerShell 5.1 because of limitation for the Appx module.
+
 ## This module can do the following
 - Check what platform your currently running and adapt the downloads for that, if your running x86, amd64, arm64.
 - Make sure that you have WinGet installed and up to date, if it's not the module will install / update it for you to the latest version.

RSModuleBuilder.ps1

@@ -9,7 +9,7 @@
 [string]$apiKey = ""
 #
 # Changes on every build
-[string]$Version = "0.0.3"
+[string]$Version = "0.0.4"
 [string]$PowerShellVersion = "5.1"
 [string]$Tags = '"windows", "maintenance", "autoupdate", "autoupdate-script", "psmodule", "update", "winget", "windows10", "windows11"'
 [string]$ProcessorArchitecture = ""

WinSoftwareUpdate/WinSoftwareUpdate.psd1

@@ -36,7 +36,7 @@
     RootModule = '.\WinSoftwareUpdate.psm1'
 
     # Version number of this module.
-    ModuleVersion = '0.0.3'
+    ModuleVersion = '0.0.4'
 
     # Supported PSEditions
     # CompatiblePSEditions = @()

WinSoftwareUpdate/WinSoftwareUpdate.psm1

@@ -89,8 +89,8 @@ Function Update-RSWinSoftware {
     [System.Object]$SysInfo = Get-RSInstallInfo
 
     # If user has choosen to skip the WinGet version don't check, if WinGet is not installed this will install WinGet anyway.
-    if ($SkipVersionCheck -eq $false -or $null -eq $SysInfo.WinGet) {
-        Confirm-RSWinGet -GitHubUrl $GitHubUrl -GithubHeaders $GithubHeaders
+    if ($SkipVersionCheck -eq $false -or $SysInfo.WinGet -eq "No") {
+        Confirm-RSWinGet -GitHubUrl $GitHubUrl -GithubHeaders $GithubHeaders -WinGet $SysInfo.WinGet
     }
 
     # If VCLibs are not installed it will get installed
@@ -139,11 +139,11 @@ Function Confirm-RSWinGet {
         [string]$GitHubUrl,
         [Parameter(Mandatory = $true, HelpMessage = "The headers and API version for the GitHub API")]
         [hashtable]$GithubHeaders,
-        [Parameter(Mandatory = $true, HelpMessage = "Information about the installed version of WinGet")]
+        [Parameter(Mandatory = $false, HelpMessage = "Information about the installed version of WinGet")]
         [string]$WinGet
     )
 
-    if ($null -eq $WinGet) {
+    if ($WinGet -eq "No") {
         Write-Output = "WinGet is not installed, downloading and installing WinGet..."
     }
     else {
@@ -244,7 +244,7 @@ Function Get-RSInstallInfo {
     # Collects everything in pscustomobject to get easier access to the information
     [System.Object]$SysInfo = [PSCustomObject]@{
         VCLibs           = $(Get-AppxPackage -Name "Microsoft.VCLibs.140.00" -AllUsers | Where-Object { $_.Architecture -eq $Arch })
-        WinGet           = $(try { (Get-AppxPackage -Name Microsoft.DesktopAppInstaller).version } catch { $Null })
+        WinGet           = $(try { (Get-AppxPackage -Name Microsoft.DesktopAppInstaller).version } catch { "No" })
         VisualCRedistUrl = $VisualCRedistUrl
         $VCLibsUrl       = $VCLibsUrl
         Arch             = $Arch