Merge pull request nextcloud#52005 from nextcloud/fix/l10n-placeholder

susnux · web-flow · commit 403c33a640a5 · 2025-04-07T19:20:13.000+02:00
fix(l10n): put placeholder like string into variable
diff --git a/apps/user_ldap/lib/Connection.php b/apps/user_ldap/lib/Connection.php
@@ -538,8 +538,8 @@ private function doCriticalValidation(): void {
 
 		if (mb_strpos((string)$this->configuration->ldapLoginFilter, '%uid', 0, 'UTF-8') === false) {
 			throw new ConfigurationIssueException(
-				'Login filter does not contain %uid place holder.',
-				$this->l10n->t('Login filter does not contain %uid place holder'),
+				'Login filter does not contain %uid placeholder.',
+				$this->l10n->t('Login filter does not contain %s placeholder.', ['%uid']),
 			);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -538,8 +538,8 @@ private function doCriticalValidation(): void {`
`538`	`538`
`539`	`539`	`if (mb_strpos((string)$this->configuration->ldapLoginFilter, '%uid', 0, 'UTF-8') === false) {`
`540`	`540`	`throw new ConfigurationIssueException(`
`541`		`- 'Login filter does not contain %uid place holder.',`
`542`		`- $this->l10n->t('Login filter does not contain %uid place holder'),`
	`541`	`+ 'Login filter does not contain %uid placeholder.',`
	`542`	`+ $this->l10n->t('Login filter does not contain %s placeholder.', ['%uid']),`
`543`	`543`	`);`
`544`	`544`	`}`
`545`	`545`	`}`