fix: reuse default navigation entry when updating navigation entries

icewind1991 · icewind1991 · commit aa34f2f4571b · 2025-04-09T18:39:42.000+02:00
Signed-off-by: Robin Appelman &lt;robin@icewind.nl&gt;
diff --git a/lib/private/NavigationManager.php b/lib/private/NavigationManager.php
@@ -110,9 +110,10 @@ public function add($entry) {
 	}
 
 	private function updateDefaultEntries() {
+		$defaultEntryId = $this->getDefaultEntryIdForUser($this->userSession->getUser(), false);
 		foreach ($this->entries as $id => $entry) {
 			if ($entry['type'] === 'link') {
-				$this->entries[$id]['default'] = $id === $this->getDefaultEntryIdForUser($this->userSession->getUser(), false);
+				$this->entries[$id]['default'] = $id === $defaultEntryId;
 			}
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -110,9 +110,10 @@ public function add($entry) {`
`110`	`110`	`}`
`111`	`111`
`112`	`112`	`private function updateDefaultEntries() {`
	`113`	`+ $defaultEntryId = $this->getDefaultEntryIdForUser($this->userSession->getUser(), false);`
`113`	`114`	`foreach ($this->entries as $id => $entry) {`
`114`	`115`	`if ($entry['type'] === 'link') {`
`115`		`- $this->entries[$id]['default'] = $id === $this->getDefaultEntryIdForUser($this->userSession->getUser(), false);`
	`116`	`+ $this->entries[$id]['default'] = $id === $defaultEntryId;`
`116`	`117`	`}`
`117`	`118`	`}`
`118`	`119`	`}`