From 659e46aa1008beb6bf9f1a091819ceca6c52d78f Mon Sep 17 00:00:00 2001 From: Lin Date: Wed, 11 Oct 2023 09:19:35 +0200 Subject: [PATCH] FixErrorSonarLint --- src/main/java/hu/bme/mit/spaceship/TorpedoStore.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java index 592bce6..f709e47 100644 --- a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java +++ b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java @@ -11,7 +11,7 @@ public class TorpedoStore { // rate of failing to fire torpedos [0.0, 1.0] private double FAILURE_RATE = 0.0; //NOSONAR - + private Random random = new Random(); private int torpedoCount = 0; public TorpedoStore(int numberOfTorpedos){ @@ -30,18 +30,18 @@ public TorpedoStore(int numberOfTorpedos){ public boolean fire(int numberOfTorpedos){ if(numberOfTorpedos < 1 || numberOfTorpedos > this.torpedoCount){ - new IllegalArgumentException("numberOfTorpedos"); + throw new IllegalArgumentException("numberOfTorpedos"); } boolean success = false; // simulate random overheating of the launcher bay which prevents firing - Random generator = new Random(); - double r = generator.nextDouble(); + + double r = this.random.nextDouble(); if (r >= FAILURE_RATE) { // successful firing - this.torpedoCount =- numberOfTorpedos; + this.torpedoCount = -numberOfTorpedos; success = true; } else { // simulated failure