Update golangci-lint

Author: mircearoata

.github/workflows/push.yml

@@ -31,12 +31,10 @@ jobs:
           mkdir -p frontend/build
           echo "" > frontend/build/.gitkeep
 
-      - uses: golangci/golangci-lint-action@v4
+      - uses: golangci/golangci-lint-action@v8
         with:
-          version: v1.61
+          version: v2.6
           only-new-issues: true
-          skip-pkg-cache: true
-          skip-build-cache: true
 
   lint-frontend:
     runs-on: ubuntu-latest

.golangci.yml

@@ -1,62 +1,70 @@
-linters-settings:
-  wrapcheck:
-    ignorePackageGlobs:
-      - github.com/satisfactorymodding/SatisfactoryModManager/*
-
-  govet:
-    enable-all: true
-    disable:
-      - shadow
-      - fieldalignment
-
-  gocritic:
-    disabled-checks:
-      - ifElseChain
-
-  gci:
-    custom-order: true
-    sections:
-      - standard
-      - default
-      - prefix(github.com/satisfactorymodding/SatisfactoryModManager)
-      - blank
-      - dot
-
-issues:
-  exclude-rules:
-    - linters:
-        - typecheck
-      text: "no matching files found"
-  exclude-dirs:
-    - frontend
-
+version: "2"
 run:
-  timeout: 5m
   build-tags:
     - webkit2_41
-
 linters:
-  disable-all: true
+  default: none
   enable:
-    - errcheck
-    - gosimple
-    - govet
-    - ineffassign
-    - staticcheck
-    - typecheck
-    - unused
     - bidichk
     - contextcheck
     - durationcheck
+    - errcheck
     - errorlint
     - goconst
-    - goimports
-    - revive
+    - gocritic
+    - govet
+    - ineffassign
     - misspell
+    - nonamedreturns
     - prealloc
+    - revive
+    - staticcheck
+    - unused
     - whitespace
     - wrapcheck
+  settings:
+    gocritic:
+      disabled-checks:
+        - ifElseChain
+    govet:
+      disable:
+        - shadow
+        - fieldalignment
+      enable-all: true
+    wrapcheck:
+      ignore-package-globs:
+        - github.com/satisfactorymodding/SatisfactoryModManager/*
+    revive:
+      rules:
+        - name: var-naming
+          arguments:
+            - [ ] # AllowList
+            - [ ] # DenyList
+            - - skip-package-name-checks: true
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - frontend
+formatters:
+  enable:
     - gci
-    - gocritic
     - gofumpt
-    - nonamedreturns
+    - goimports
+  settings:
+    gci:
+      sections:
+        - standard
+        - default
+        - prefix(github.com/satisfactorymodding/SatisfactoryModManager)
+        - blank
+        - dot
+      custom-order: true
+  exclusions:
+    generated: lax
+    paths:
+      - frontend

Taskfile.yml

@@ -65,7 +65,7 @@ tasks:
   lint:
     silent: true
     preconditions:
-      - golangci-lint --version | grep -q 1.61
+      - golangci-lint --version | grep -q 2.6
     cmds:
       - GOOS=windows  golangci-lint run
       - GOOS=linux    golangci-lint run

backend/installfinders/launchers/crossover/crossover_darwin.go

@@ -6,11 +6,11 @@ import (
 	"os"
 	"path/filepath"
 
-	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/launchers/epic"
 	"howett.net/plist"
 
 	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/common"
 	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/launchers"
+	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/launchers/epic"
 	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/launchers/steam"
 )
 

backend/installfinders/launchers/epic/epic_wine_unix.go

@@ -16,7 +16,7 @@ func FindInstallationsWine(winePrefix string, launcher string, launchPath []stri
 	platform := common.WineLauncherPlatform(winePrefix)
 
 	if _, err := os.Stat(platform.ProcessPath(epicWineManifestPath)); os.IsNotExist(err) {
-		return nil, []error{fmt.Errorf("Epic is not installed in %s", winePrefix)}
+		return nil, []error{fmt.Errorf("epic is not installed in %s", winePrefix)}
 	}
 
 	return FindInstallationsEpic(

backend/installfinders/launchers/steam/steam.go

@@ -12,8 +12,10 @@ import (
 	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/common"
 )
 
-var manifests = []string{"appmanifest_526870.acf", "appmanifest_1690800.acf"}
-var steamappsCasings = []string{"steamapps", "SteamApps"}
+var (
+	manifests        = []string{"appmanifest_526870.acf", "appmanifest_1690800.acf"}
+	steamappsCasings = []string{"steamapps", "SteamApps"}
+)
 
 func FindInstallationsSteam(steamPath string, launcher string, platform common.LauncherPlatform) ([]*common.Installation, []error) {
 	rawLibraryFolders := []string{steamPath}

backend/installfinders/launchers/steam/steam_wine_darwin.go

@@ -17,7 +17,7 @@ func FindInstallationsWine(winePrefix string, launcher string, launchPath []stri
 	platform := common.WineLauncherPlatform(winePrefix)
 
 	if _, err := os.Stat(platform.ProcessPath(steamWinePath)); os.IsNotExist(err) {
-		return nil, []error{fmt.Errorf("Steam is not installed in %s", winePrefix)}
+		return nil, []error{fmt.Errorf("steam is not installed in %s", winePrefix)}
 	}
 
 	return FindInstallationsSteam(

backend/installfinders/launchers/whisky/whisky_darwin.go

@@ -7,11 +7,11 @@ import (
 	"os"
 	"path/filepath"
 
-	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/launchers/epic"
 	"howett.net/plist"
 
 	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/common"
 	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/launchers"
+	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/launchers/epic"
 	"github.com/satisfactorymodding/SatisfactoryModManager/backend/installfinders/launchers/steam"
 )
 

build/windows/installer_version.go

@@ -58,5 +58,5 @@ func main() {
 	}
 
 	_, _ = f.WriteString("# DO NOT EDIT - Generated automatically by build/windows/installer_version.go\n\n")
-	_, _ = f.WriteString(fmt.Sprintf("!define VI_VERSION \"%s\"\n", version))
+	_, _ = fmt.Fprintf(f, "!define VI_VERSION \"%s\"\n", version)
 }