pop_select issue

[arnodelorme]

This is with the sample_data/eeglab_data.set

[arnodelorme]

Same issue with menu item "Select epoch or events"

[claude]

🤖 Plan:

• Reproduce error
• Identify root cause
• Add regression test
• Apply fix in pop_select_dialog_spec
• Run pre-commit + pytest (1654 passed, 62 skipped)
• Open PR Fix pop_select dialog crash on numpy chanlocs #231
• Verify CI passes (all required checks green)

Research

pop_select_dialog_spec crashes with ValueError: The truth value of an array with more than one element is ambiguous when invoked on an EEG loaded by pop_loadset (e.g. sample_data/eeglab_data.set). eeg_checkset normalises EEG["chanlocs"] to a numpy.ndarray of dicts, but the dialog builder does list(EEG.get("chanlocs", []) or []) — the or [] forces a boolean on the array.

Relevant code

• src/eegprep/functions/popfunc/pop_select.py#L581 — offending or [] on possible ndarray.
• src/eegprep/functions/adminfunc/eeg_checkset.py#L211-L212 — chanlocs stored as np.ndarray.
• src/eegprep/functions/popfunc/_chanutils.py — existing chanlocs_as_list helper handling this case.

Proposed Fix

Replace the or [] with the existing chanlocs_as_list helper inside pop_select_dialog_spec. Add a regression test that builds the dialog spec from an EEG whose chanlocs is a numpy array of dicts.

PR: #231

Note (separate concern)

The same list(EEG.get("chanlocs", []) or []) pattern exists in src/eegprep/functions/popfunc/pop_rejcont.py:248 and src/eegprep/plugins/ICLabel/_prop_numerics.py:266 — same latent bug, not fixed here to keep this PR scoped to #229.