Skip to content

Commit 4fa13ed

Browse files
committed
Trigger proxytests on PR against main
1 parent 0a0ffda commit 4fa13ed

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

.github/workflows/proxytests.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ name: Python package (with methods that need proxy)
55

66
on:
77
workflow_run:
8-
workflows: ["lint"]
8+
workflows: ["Python package"]
99
branches: [main]
1010
types:
1111
- completed
@@ -37,7 +37,7 @@ jobs:
3737
# uses: typilus/typilus-action@v0.9
3838
- name: Run unittests
3939
id: unittests
40-
if: ${{ github.event.pull_request.draft == false }}
40+
if: ${{ github.event.pull_request.ready_for_review == true }}
4141
continue-on-error: true
4242
env:
4343
CONNECTION_METHOD: ${{ secrets.CONNECTION_METHOD }}
@@ -48,8 +48,6 @@ jobs:
4848
run: |
4949
coverage run -m unittest -v test_module.TestScholarlyWithProxy
5050
- name: Generate coverage report
51-
if:
52-
"matrix.os == 'macos-latest'"
5351
run: |
5452
curl --data-binary @.github/.codecov.yml https://codecov.io/validate | head -n 1
5553
coverage xml

.github/workflows/pythonpackage.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ on:
1111
pull_request:
1212
branches: [main, develop]
1313
workflow_run:
14-
workflows: ["lint"]
15-
# branches: [main]
14+
workflows: ["lint", lint]
15+
branches: [main, develop]
1616
types:
1717
- completed
1818

0 commit comments

Comments
 (0)