Skip to content

Commit 55d2c80

Browse files
committed
Handle breaking change in fp
Fixes #454 properly
1 parent 4f56743 commit 55d2c80

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ beautifulsoup4
33
bibtexparser
44
deprecated
55
fake_useragent
6-
free-proxy<1.1.0
6+
free-proxy
77
python-dotenv
88
requests[socks]
99
selenium

scholarly/_proxy_generator.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,10 @@ def _fp_coroutine(self, timeout=1, wait_time=120):
483483
freeproxy = FreeProxy(rand=False, timeout=timeout)
484484
if not hasattr(self, '_dirty_freeproxies'):
485485
self._dirty_freeproxies = set()
486-
all_proxies = freeproxy.get_proxy_list()
486+
try:
487+
all_proxies = freeproxy.get_proxy_list(repeat=False) # free-proxy >= 1.1.0
488+
except TypeError:
489+
all_proxies = freeproxy.get_proxy_list() # free-proxy < 1.1.0
487490
all_proxies.reverse() # Try the older proxies first
488491

489492
t1 = time.time()

0 commit comments

Comments
 (0)