Skip to content

Commit 6c3da1b

Browse files
committed
Catch exceptions when quitting webdriver
This is mainly to prevent crashing in Windows machines. May address the concern in #403 partly.
1 parent 868ab58 commit 6c3da1b

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

scholarly/_proxy_generator.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ def __init__(self):
4949
self._tor_control_port = None
5050
self._tor_password = None
5151
self._session = None
52+
self._webdriver = None
5253
self._TIMEOUT = 5
5354
self._new_session()
5455

@@ -458,7 +459,10 @@ def _close_session(self):
458459
if self._session:
459460
self._session.close()
460461
if self._webdriver:
461-
self._webdriver.quit()
462+
try:
463+
self._webdriver.quit()
464+
except Exception as e:
465+
self.logger.warning("Could not close webdriver cleanly: %s", e)
462466

463467
def _fp_coroutine(self, timeout=1, wait_time=120):
464468
"""A coroutine to continuosly yield free proxies

0 commit comments

Comments
 (0)