Address code review feedback: enforce uppercase X in ISSN, clean up data fields

Co-authored-by: robertatakenaka <505143+robertatakenaka@users.noreply.github.com>

Author: Copilot

packtools/sps/validation/journal_meta.py

@@ -483,7 +483,7 @@ def validate_publisher_id_presence(self, error_level="CRITICAL"):
             expected='<journal-id journal-id-type="publisher-id"> with non-empty value',
             obtained=publisher_id if is_valid else None,
             advice='Add <journal-id journal-id-type="publisher-id">ACRONYM</journal-id> inside <journal-meta>',
-            data={'publisher_id': publisher_id},
+            data={'publisher_id': publisher_id} if is_valid else None,
             error_level=error_level,
         )
 
@@ -512,7 +512,7 @@ def validate_journal_title_presence(self, error_level="CRITICAL"):
             expected='<journal-title> with non-empty value',
             obtained=journal_title if is_valid else None,
             advice='Add <journal-title>Title</journal-title> inside <journal-title-group>',
-            data={'journal_title': journal_title},
+            data={'journal_title': journal_title} if is_valid else None,
             error_level=error_level,
         )
 
@@ -541,7 +541,7 @@ def validate_abbrev_journal_title_presence(self, error_level="CRITICAL"):
             expected='<abbrev-journal-title abbrev-type="publisher"> with non-empty value',
             obtained=abbrev_title if is_valid else None,
             advice='Add <abbrev-journal-title abbrev-type="publisher">Abbrev. Title</abbrev-journal-title> inside <journal-title-group>',
-            data={'abbrev_title': abbrev_title},
+            data={'abbrev_title': abbrev_title} if is_valid else None,
             error_level=error_level,
         )
 
@@ -601,7 +601,7 @@ def validate_publisher_name_presence(self, error_level="CRITICAL"):
             expected='<publisher-name> with non-empty value',
             obtained=publisher_name if is_valid else None,
             advice='Add <publisher><publisher-name>Publisher Name</publisher-name></publisher> inside <journal-meta>',
-            data={'publisher_name': publisher_name},
+            data={'publisher_name': publisher_name} if is_valid else None,
             error_level=error_level,
         )
 
@@ -619,14 +619,15 @@ def validate_issn_format(self, error_level="ERROR"):
         """
         Rule 8: Validates ISSN format (XXXX-XXXX pattern).
         ISSN must be 4 digits, hyphen, 4 digits (last digit can be X).
+        According to ISO 3297, the check digit X must be uppercase.
         
         Returns
         -------
         generator of dict
             Validation results for each ISSN format.
         """
-        # Regex pattern for ISSN: 4 digits, hyphen, 3 digits + (digit or X)
-        issn_pattern = re.compile(r'^\d{4}-\d{3}[\dXx]$')
+        # Regex pattern for ISSN: 4 digits, hyphen, 3 digits + (digit or uppercase X)
+        issn_pattern = re.compile(r'^\d{4}-\d{3}[\dX]$')
 
         for issn_data in self.journal_issns.data:
             issn_value = issn_data.get('value', '')

tests/sps/validation/test_journal_meta.py

@@ -1041,6 +1041,28 @@ def test_validate_issn_format_invalid_wrong_length(self):
         self.assertEqual(len(results), 1)
         self.assertEqual(results[0]['response'], 'ERROR')
 
+    def test_validate_issn_format_invalid_lowercase_x(self):
+        """Test ISSN format validation rejects lowercase x (must be uppercase X)"""
+        xmltree = etree.fromstring(
+            """
+            <article xmlns:xlink="http://www.w3.org/1999/xlink" article-type="research-article" xml:lang="en">
+                <front>
+                    <journal-meta>
+                        <issn pub-type="epub">1234-567x</issn>
+                    </journal-meta>
+                </front>
+            </article>
+            """
+        )
+        from packtools.sps.validation.journal_meta import ISSNFormatValidation
+        validation = ISSNFormatValidation(xmltree)
+        results = list(validation.validate_issn_format())
+        
+        self.assertEqual(len(results), 1)
+        self.assertEqual(results[0]['response'], 'ERROR')
+
+
+
 
 class JournalMetaAttributeTest(TestCase):
     """Tests for JournalMetaAttributeValidation class"""
@@ -1171,3 +1193,6 @@ def test_validate_issn_type_uniqueness_failure(self):
         self.assertEqual(len(results), 1)
         self.assertEqual(results[0]['response'], 'WARNING')
         self.assertIn('epub', results[0]['data']['duplicates'])
+
+    def test_validate_issn_format_invalid_lowercase_x(self):
+        """Test ISSN format validation rejects lowercase x (must be uppercase X)"""