fix: reset state on tests, move class init to BeforeEach instead of BeforeAll

Author: benminer

tests/functional/authorization.ts

@@ -21,7 +21,7 @@ describe("Authorization", () => {
   let schema: GraphQLSchema;
   let sampleResolver: any;
 
-  beforeAll(async () => {
+  beforeEach(async () => {
     getMetadataStorage().clear();
 
     @ObjectType()
@@ -608,7 +608,7 @@ describe("Authorization", () => {
   describe("with constant readonly array or roles", () => {
     let testResolver: Function;
 
-    beforeAll(() => {
+    beforeEach(() => {
       getMetadataStorage().clear();
 
       const CONSTANT_ROLES = ["a", "b", "c"] as const;

tests/functional/middlewares.ts

@@ -282,6 +282,8 @@ describe("Middlewares", () => {
 
     // clear ResolverMiddlewareMetadata for other tests
     getMetadataStorage().resolverMiddlewares = [];
+    getMetadataStorage().resolverMiddlewaresByTargetCache = new Map();
+    getMetadataStorage().middlewaresByTargetAndFieldCache = new Map();
 
     const query = `query {
       middlewareOrderQuery

tests/functional/validation.ts

@@ -679,8 +679,13 @@ describe("Custom validation", () => {
   let validateResolverData: ResolverData[] = [];
   let sampleQueryArgs: any[] = [];
 
-  beforeAll(async () => {
+  beforeEach(() => {
+    // Reset ALL shared state
     getMetadataStorage().clear();
+    validateArgs = [];
+    validateTypes = [];
+    validateResolverData = [];
+    sampleQueryArgs = [];
 
     @ArgsType()
     class SampleArgs {
@@ -725,13 +730,6 @@ describe("Custom validation", () => {
     sampleResolverCls = SampleResolver;
   });
 
-  beforeEach(() => {
-    validateArgs = [];
-    validateTypes = [];
-    validateResolverData = [];
-    sampleQueryArgs = [];
-  });
-
   it("should call `validateFn` function provided in option with proper params", async () => {
     schema = await buildSchema({
       resolvers: [sampleResolverCls],