clean up

move ld_prelaod generation into subsystem, as its the only one using its, and its logic

Author: AndreasGocht

scorep/helper.py

@@ -52,19 +52,6 @@ def add_to_ld_library_path(path):
                 ":" + os.environ["LD_LIBRARY_PATH"]
 
 
-def generate_ld_preload(scorep_config):
-    """
-    This functions generate a string that needs to be passed to $LD_PRELOAD.
-    After this sting is passed, the tracing needs to be restarted with this $LD_PRELOAD in env.
-
-    @return ld_preload string which needs to be passed to LD_PRELOAD
-    """
-
-    (_, preload, _) = call(["scorep-config"] +
-                           scorep_config + ["--user", "--preload-libs"])
-    return preload
-
-
 def generate_compile_deps(config=[]):
     """
     Generates the data needed for compilation.

scorep/subsystem.py

@@ -7,7 +7,7 @@
 import scorep.helper
 
 
-def gen_subsystem_lib_name():
+def generate_subsystem_lib_name():
     """
     generate the name for the subsystem lib.
     """
@@ -16,6 +16,19 @@ def gen_subsystem_lib_name():
     return mpi_lib_name
 
 
+def generate_ld_preload(scorep_config):
+    """
+    This functions generate a string that needs to be passed to $LD_PRELOAD.
+    After this sting is passed, the tracing needs to be restarted with this $LD_PRELOAD in env.
+
+    @return ld_preload string which needs to be passed to LD_PRELOAD
+    """
+
+    (_, preload, _) = scorep.helper.call(
+        ["scorep-config"] + scorep_config + ["--user", "--preload-libs"])
+    return preload
+
+
 def generate_subsystem_code(config=[]):
     """
     Generates the data needed to be preloaded.
@@ -62,7 +75,7 @@ def generate(scorep_config, keep_files=False):
     with open(temp_dir + "/scorep_init.c", "w") as f:
         f.write(scorep_adapter_init)
 
-    subsystem_lib_name = gen_subsystem_lib_name()
+    subsystem_lib_name = generate_subsystem_lib_name()
 
     cc = distutils.ccompiler.new_compiler()
     compiled_subsystem = cc.compile(
@@ -97,7 +110,7 @@ def init_environment(scorep_config=[], keep_files=False):
 
     subsystem_lib_name, temp_dir = scorep.subsystem.generate(
         scorep_config, keep_files)
-    scorep_ld_preload = scorep.helper.generate_ld_preload(scorep_config)
+    scorep_ld_preload = generate_ld_preload(scorep_config)
 
     scorep.helper.add_to_ld_library_path(temp_dir)