Skip to content

Commit a1ac319

Browse files
committed
make flake happy, and remove more typhints
1 parent 70fabf7 commit a1ac319

2 files changed

Lines changed: 6 additions & 8 deletions

File tree

test/test_scorep.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import platform
66
import pytest
77
import re
8-
import subprocess
98
import sys
109
import numpy
1110

test/utils.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class OTF2_Region:
5353
def __init__(self, region):
5454
self.region = region
5555

56-
def __str__(self) -> str:
56+
def __str__(self):
5757
return self.region
5858

5959

@@ -62,7 +62,7 @@ def __init__(self, parameter, value):
6262
self.parameter = parameter
6363
self.value = value
6464

65-
def __str__(self) -> str:
65+
def __str__(self):
6666
return "{}:{}".format(self.parameter, self.value)
6767

6868

@@ -79,13 +79,12 @@ def __contains__(self, otf2_element):
7979
search_str = "{event}[ ]*[0-9 ]*[0-9 ]*Region: \"{region}\"".format(
8080
event=event, region=otf2_element.region)
8181
search_res = re.search(search_str, self.trace)
82-
result.append(search_res != None)
82+
result.append(search_res is not None)
8383
elif isinstance(otf2_element, OTF2_Parameter):
84-
search_str = "PARAMETER_STRING[ ]*[0-9 ]*[0-9 ]*Parameter: \"{parameter}\" <[0-9]*>, Value: \"{value}\"".format(
85-
parameter=otf2_element.parameter,
86-
value=otf2_element.value)
84+
search_str = "PARAMETER_STRING[ ]*[0-9 ]*[0-9 ]*Parameter: \"{parameter}\" <[0-9]*>, Value: \"{value}\""
85+
search_str = search_str.format(parameter=otf2_element.parameter, value=otf2_element.value)
8786
search_res = re.search(search_str, self.trace)
88-
result.append(search_res != None)
87+
result.append(search_res is not None)
8988
else:
9089
raise NotImplementedError
9190
return all(result)

0 commit comments

Comments
 (0)