logging in files fixed, minor stream reading improvements

Author: OutlyingWest

src/scorep_jupyter/kernel.py

@@ -674,28 +674,29 @@ def start_reading_scorep_process_streams(
         process_busy_spinner = create_busy_spinner(
             stdout_lock, spinner_stop_event, is_multicell_final
         )
-        process_busy_spinner.start("Process is running...")
+        t_stderr = threading.Thread(
+            target=self.read_scorep_stderr,
+            args=(proc.stderr, stdout_lock, spinner_stop_event),
+        )
 
         # Empty cell output, required for interactive output
         # e.g. tqdm for-loop progress bar
         self.cell_output("\0")
 
         try:
-            t_stderr = threading.Thread(
-                target=self.read_scorep_stderr,
-                args=(proc.stderr, stdout_lock, spinner_stop_event),
-            )
+            process_busy_spinner.start("Process is running...")
             t_stderr.start()
 
             self.read_scorep_stdout(
                 proc.stdout, stdout_lock, spinner_stop_event
             )
 
-            t_stderr.join()
             process_busy_spinner.stop("Done.")
 
         except KeyboardInterrupt:
             process_busy_spinner.stop("Kernel interrupted.")
+        finally:
+            t_stderr.join()
 
     def read_scorep_stdout(
         self,
@@ -727,7 +728,7 @@ def read_scorep_stderr(
         def process_stderr_line(line: str):
             if spinner_stop_event.is_set():
                 self.cell_output(line)
-                self.log.error(line)
+                self.log.error(line.strip())
 
         self.read_scorep_stream(
             stderr, lock, process_stderr_line, read_chunk_size
@@ -909,7 +910,7 @@ def log_error(self, code: KernelErrorCode, **kwargs):
         )
         message = template.format(mode=mode, marshaller=marshaller, **kwargs)
 
-        self.log.error(message)
+        self.log.error(message.strip())
         self.cell_output("KernelError: " + message, "stderr")
 
 

src/scorep_jupyter/logging_config.py

@@ -1,9 +1,10 @@
 import logging
 import os
 import sys
+from pathlib import Path
 
 
-LOGGING_DIR = "logging"
+LOGGING_DIR = Path().cwd().parent / "logging"
 os.makedirs(LOGGING_DIR, exist_ok=True)
 
 
@@ -17,7 +18,7 @@ def filter(self, record):
         return record.levelno < logging.ERROR
 
 
-class scorep_jupyterKernelOnlyFilter(logging.Filter):
+class ScorepJupyterKernelOnlyFilter(logging.Filter):
     def filter(self, record):
         return "scorep_jupyter" in record.pathname
 
@@ -55,8 +56,8 @@ def filter(self, record):
             "class": "logging.StreamHandler",
             "stream": sys.stdout,
             "filters": [
-                "ignore_error_filter",  # prevents from writing to jupyter
-                # cell output twice
+                # prevents from writing to jupyter cell output twice
+                "ignore_error_filter",
                 "scorep_jupyter_kernel_only_filter",
             ],
         },
@@ -65,7 +66,7 @@ def filter(self, record):
         "jupyter_filter": {"()": JupyterLogFilter},
         "ignore_error_filter": {"()": IgnoreErrorFilter},
         "scorep_jupyter_kernel_only_filter": {
-            "()": scorep_jupyterKernelOnlyFilter
+            "()": ScorepJupyterKernelOnlyFilter
         },
     },
     "root": {