Skip to content

Commit 930d0f9

Browse files
author
Elias Werner
committed
add scorep dependency, renaming
1 parent d52a768 commit 930d0f9

12 files changed

Lines changed: 47 additions & 46 deletions

File tree

.github/workflows/unit_test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ jobs:
4242
pip install pyyaml dill cloudpickle numpy pandas
4343
pip install ipywidgets itables matplotlib pynvml
4444
45-
- name: Build JUmPER kernel
45+
- name: Build scorep_jupyter kernel
4646
run: |
4747
pip install .
48-
python -m jumper.install
48+
python -m scorep_jupyter.install
4949
5050
- name: Run userpersistence tests
5151
run: |

examples/ExampleBasic.ipynb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@
503503
"metadata": {},
504504
"outputs": [],
505505
"source": [
506-
"%env JUMPER_MARSHALLING_DETAILED_REPORT=1"
506+
"%env scorep_jupyter_MARSHALLING_DETAILED_REPORT=1"
507507
]
508508
},
509509
{
@@ -527,9 +527,9 @@
527527
],
528528
"metadata": {
529529
"kernelspec": {
530-
"display_name": "JUmPER",
530+
"display_name": "scorep_jupyter",
531531
"language": "python",
532-
"name": "jumper"
532+
"name": "scorep_jupyter"
533533
},
534534
"language_info": {
535535
"file_extension": ".py",

examples/gpt-demo/01-GPT-Training.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,9 +184,9 @@
184184
"lastKernelId": null
185185
},
186186
"kernelspec": {
187-
"display_name": "JUmPER",
187+
"display_name": "scorep_jupyter",
188188
"language": "python",
189-
"name": "jumper"
189+
"name": "scorep_jupyter"
190190
},
191191
"language_info": {
192192
"file_extension": ".py",

pyproject.toml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ requires = [
66
build-backend = "setuptools.build_meta:__legacy__"
77

88
[project]
9-
name='jumper-kernel'
10-
version='1.1.1'
9+
name='scorep-jupyter'
10+
version='1.2.0'
1111
authors=[
1212
{name='Elias Werner',email='elias.werner@tu-dresden.de'},
1313
]
@@ -23,7 +23,8 @@ dependencies = [
2323
"ipykernel",
2424
"jupyter-client",
2525
"astunparse",
26-
"dill"
26+
"dill",
27+
"scorep"
2728
]
2829

2930
[project.urls]

src/parallel_marshall/parallel_marshall.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@
1010
# mode is automatically determined by the file object that is passed for
1111
# dumping
1212
mode = ""
13-
backend = str(os.environ.get("JUMPER_PARALLEL_MARSHALL_BACKEND", "dill"))
14-
if os.environ.get("JUMPER_PARALLEL_MARSHALL_NWORKERS"):
13+
backend = str(os.environ.get("scorep_jupyter_PARALLEL_MARSHALL_BACKEND", "dill"))
14+
if os.environ.get("scorep_jupyter_PARALLEL_MARSHALL_NWORKERS"):
1515
workers = min(
16-
int(os.environ.get("JUMPER_PARALLEL_MARSHALL_NWORKERS")),
16+
int(os.environ.get("scorep_jupyter_PARALLEL_MARSHALL_NWORKERS")),
1717
multiprocessing.cpu_count(),
1818
multiprocessing.cpu_count(),
1919
)
2020
else:
2121
workers = multiprocessing.cpu_count()
22-
debug = int(os.environ.get("JUMPER_PARALLEL_MARSHALL_DEBUG", 20))
22+
debug = int(os.environ.get("scorep_jupyter_PARALLEL_MARSHALL_DEBUG", 20))
2323

2424
logger = logging.getLogger(__name__)
2525
logging.basicConfig(filename="parallel_marshall.log", level=logging.INFO)

src/scorep_jupyter/install.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import os
44
import sys
55
import json
6-
from jumper.logo import logo_image
6+
from scorep_jupyter.logo import logo_image
77

88
kernel_spec = {
99
"argv": [sys.executable, "-m", "scorep_jupyter.kernel", "-f", "{connection_file}"],

src/scorep_jupyter/kernel.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -13,17 +13,17 @@
1313
from enum import Enum
1414
from textwrap import dedent
1515
from ipykernel.ipkernel import IPythonKernel
16-
from jumper.userpersistence import PersHelper, scorep_script_name
17-
from jumper.userpersistence import magics_cleanup, create_busy_spinner
16+
from scorep_jupyter.userpersistence import PersHelper, scorep_script_name
17+
from scorep_jupyter.userpersistence import magics_cleanup, create_busy_spinner
1818
import importlib
19-
from jumper.kernel_messages import KernelErrorCode, KERNEL_ERROR_MESSAGES
19+
from scorep_jupyter.kernel_messages import KernelErrorCode, KERNEL_ERROR_MESSAGES
2020

21-
# import jumper.multinode_monitor.slurm_monitor as slurm_monitor
21+
# import scorep_jupyter.multinode_monitor.slurm_monitor as slurm_monitor
2222

2323
from .logging_config import LOGGING
2424

2525
PYTHON_EXECUTABLE = sys.executable
26-
userpersistence_token = "jumper.userpersistence"
26+
userpersistence_token = "scorep_jupyter.userpersistence"
2727
jupyter_dump = "jupyter_dump.pkl"
2828
subprocess_dump = "subprocess_dump.pkl"
2929

@@ -38,7 +38,7 @@ def __str__(self):
3838
return self.value[1]
3939

4040

41-
class JumperKernel(IPythonKernel):
41+
class scorep_jupyterKernel(IPythonKernel):
4242
implementation = "Python and Score-P"
4343
implementation_version = "1.0"
4444
language = "python"
@@ -305,7 +305,7 @@ def start_writefile(self, code):
305305
f"""
306306
# This bash script is generated automatically to run
307307
# Jupyter Notebook -> Python script conversion
308-
# by JUmPER kernel
308+
# by scorep_jupyter kernel
309309
# {self.writefile_python_name}
310310
# !/bin/bash
311311
"""
@@ -322,7 +322,7 @@ def start_writefile(self, code):
322322
dedent(
323323
f"""
324324
# This is the automatic conversion of
325-
# Jupyter Notebook -> Python script by JUmPER kernel.
325+
# Jupyter Notebook -> Python script by scorep_jupyter kernel.
326326
# Code corresponding to the cells not marked for
327327
# Score-P instrumentation is framed by
328328
# "with scorep.instrumenter.disable()
@@ -880,4 +880,4 @@ def log_error(self, code: KernelErrorCode, **kwargs):
880880
if __name__ == "__main__":
881881
from ipykernel.kernelapp import IPKernelApp
882882

883-
IPKernelApp.launch_instance(kernel_class=JumperKernel)
883+
IPKernelApp.launch_instance(kernel_class=scorep_jupyterKernel)

src/scorep_jupyter/logging_config.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ def filter(self, record):
1717
return record.levelno < logging.ERROR
1818

1919

20-
class JumperKernelOnlyFilter(logging.Filter):
20+
class scorep_jupyterKernelOnlyFilter(logging.Filter):
2121
def filter(self, record):
22-
return "jumper" in record.pathname
22+
return "scorep_jupyter" in record.pathname
2323

2424

2525
LOGGING = {
@@ -57,14 +57,14 @@ def filter(self, record):
5757
"filters": [
5858
"ignore_error_filter", # prevents from writing to jupyter
5959
# cell output twice
60-
"jumper_kernel_only_filter",
60+
"scorep_jupyter_kernel_only_filter",
6161
],
6262
},
6363
},
6464
"filters": {
6565
"jupyter_filter": {"()": JupyterLogFilter},
6666
"ignore_error_filter": {"()": IgnoreErrorFilter},
67-
"jumper_kernel_only_filter": {"()": JumperKernelOnlyFilter},
67+
"scorep_jupyter_kernel_only_filter": {"()": scorep_jupyterKernelOnlyFilter},
6868
},
6969
"root": {
7070
"handlers": [],

src/scorep_jupyter/userpersistence.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def preprocess(self):
4444
for key2 in self.paths[key1]:
4545

4646
if self.mode == "memory":
47-
fd_path = "jumper_" + key1 + "_" + key2 + "_" + uid
47+
fd_path = "scorep_jupyter_" + key1 + "_" + key2 + "_" + uid
4848
elif self.mode == "disk":
4949
fd_path = dir_path + "_" + key2 + "_" + uid
5050

@@ -114,7 +114,7 @@ def jupyter_dump(self):
114114
"import os\n"
115115
"import threading\n"
116116
f"import {self.marshaller}\n"
117-
"from jumper.userpersistence import dump_runtime, "
117+
"from scorep_jupyter.userpersistence import dump_runtime, "
118118
"dump_variables, create_busy_spinner\n"
119119
"spinner = create_busy_spinner()\n"
120120
f"if {self.is_dump_detailed_report}:\n"
@@ -152,7 +152,7 @@ def subprocess_wrapper(self, code):
152152
"import sys\n"
153153
"import os\n"
154154
f"import {self.marshaller}\n"
155-
"from jumper.userpersistence import dump_runtime,"
155+
"from scorep_jupyter.userpersistence import dump_runtime,"
156156
"dump_variables, load_runtime, load_variables\n"
157157
"load_runtime(os.environ, sys.path,"
158158
f"'{self.paths['jupyter']['os_environ']}',"
@@ -195,7 +195,7 @@ def jupyter_update(self, code):
195195
jupyter_update = (
196196
"import sys\n"
197197
"import os\n"
198-
"from jumper.userpersistence import load_runtime, load_variables\n"
198+
"from scorep_jupyter.userpersistence import load_runtime, load_variables\n"
199199
f"load_runtime(os.environ, sys.path,"
200200
f"'{self.paths['subprocess']['os_environ']}',"
201201
f"'{self.paths['subprocess']['sys_path']}',{self.marshaller})\n"
@@ -231,7 +231,7 @@ def parse(self, code, mode):
231231

232232
def set_dump_report_level(self):
233233
self.is_dump_detailed_report = int(
234-
os.getenv("JUMPER_MARSHALLING_DETAILED_REPORT", "0")
234+
os.getenv("scorep_jupyter_MARSHALLING_DETAILED_REPORT", "0")
235235
)
236236

237237

@@ -306,7 +306,7 @@ def extract_definitions(code):
306306
Extract imported modules and definitions of classes and functions from
307307
the code block.
308308
"""
309-
# can't use in kernel as import from jumper.userpersistence:
309+
# can't use in kernel as import from scorep_jupyter.userpersistence:
310310
# self-reference error during dill dump of notebook
311311
root = ast.parse(code)
312312
definitions = []
@@ -488,7 +488,7 @@ def stop(self, done_message="Done."):
488488

489489

490490
def create_busy_spinner(lock=None):
491-
is_enabled = os.getenv("JUMPER_DISABLE_PROCESSING_ANIMATIONS") != "1"
491+
is_enabled = os.getenv("scorep_jupyter_DISABLE_PROCESSING_ANIMATIONS") != "1"
492492
if is_enabled:
493493
return BusySpinner(lock)
494494
else:

tests/kernel/notebook.ipynb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -810,9 +810,9 @@
810810
],
811811
"metadata": {
812812
"kernelspec": {
813-
"display_name": "JUmPER",
813+
"display_name": "scorep_jupyter",
814814
"language": "python",
815-
"name": "jumper"
815+
"name": "scorep_jupyter"
816816
},
817817
"language_info": {
818818
"file_extension": ".py",

0 commit comments

Comments
 (0)