Skip to content

Commit a786bd6

Browse files
author
OutlyingWest
committed
nodelist is taken from PerformanceDataHandler singleton for both kernel and extension
1 parent e113b5a commit a786bd6

2 files changed

Lines changed: 15 additions & 11 deletions

File tree

src/jumper/kernel.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,7 @@ def __init__(self, **kwargs):
9797
self.gpu_avail = False
9898
# TODO: Temporary share perfdata_handler instance with an ipython extension
9999
# as it contains data that should be shared with the extension.
100-
kernel_context.perfdata_handler = PerformanceDataHandler()
101-
kernel_context.nodelist = kernel_context.perfdata_handler.get_nodelist()
100+
self.nodelist = kernel_context.perfdata_handler.get_nodelist()
102101

103102
self.scorep_available_ = shutil.which("scorep")
104103
self.scorep_python_available_ = True
@@ -487,9 +486,9 @@ def report_perfdata(self, performance_data_nodes, duration):
487486
performance_data_nodes[:-8]
488487
):
489488

490-
if kernel_context.nodelist:
489+
if self.nodelist:
491490
self.cell_output(
492-
"--NODE " + str(kernel_context.nodelist[idx]) + "--\n", "stdout"
491+
"--NODE " + str(self.nodelist[idx]) + "--\n", "stdout"
493492
)
494493

495494
cpu_util = performance_data[0]
@@ -970,7 +969,7 @@ async def do_execute(
970969
f" following sub cells: {sub_idxs}"
971970
)
972971
perfvis.draw_performance_graph(
973-
kernel_context.nodelist,
972+
self.nodelist,
974973
kernel_context.perfdata_handler.get_perfdata_history()[-1],
975974
self.gpu_avail,
976975
time_indices,
@@ -999,7 +998,7 @@ async def do_execute(
999998
f" following sub cells: {sub_idxs}"
1000999
)
10011000
perfvis.draw_performance_graph(
1002-
kernel_context.nodelist,
1001+
self.nodelist,
10031002
kernel_context.perfdata_handler.get_perfdata_history()[index],
10041003
self.gpu_avail,
10051004
time_indices,

src/magic_extension/magic.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ def __init__(self, shell):
1818

1919
# will be set to True as soon as GPU data is received
2020
self.gpu_avail = False
21+
self.nodelist = kernel_context.perfdata_handler.get_nodelist()
2122

2223
@cell_magic
2324
def abra(self, line, cell):
@@ -29,12 +30,16 @@ def display_graph_for_all(self, line):
2930
kernel_context.perfdata_handler.get_perfdata_aggregated()
3031
)
3132
perfvis.draw_performance_graph(
32-
kernel_context.nodelist,
33+
self.nodelist,
3334
data,
3435
self.gpu_avail,
3536
time_indices,
3637
)
3738

39+
@line_magic
40+
def display_graph_for_index(self, line):
41+
pass
42+
3843

3944
@cell_magic
4045
def set_perfmonitor(self, line, code):
@@ -50,9 +55,9 @@ def set_perfmonitor(self, line, code):
5055
else:
5156
try:
5257
kernel_context.perfdata_handler.set_monitor(monitor)
53-
kernel_context.nodelist = kernel_context.perfdata_handler.get_nodelist()
54-
if len(kernel_context.nodelist) <= 1:
55-
kernel_context.nodelist = None
58+
self.nodelist = kernel_context.perfdata_handler.get_nodelist()
59+
if len(self.nodelist) <= 1:
60+
self.nodelist = None
5661
self.cell_output(
5762
"Found monitor: "
5863
+ str(monitor)
@@ -63,7 +68,7 @@ def set_perfmonitor(self, line, code):
6368
"Selected monitor: "
6469
+ str(monitor)
6570
+ " and got nodes: "
66-
+ str(kernel_context.nodelist)
71+
+ str(self.nodelist)
6772
)
6873
except Exception as e:
6974
self.cell_output(f"Error setting monitor\n{e}", "stderr")

0 commit comments

Comments
 (0)