Sipeed_GD32V_LCD: examples/image_display: fix warnings, use printf

scpcom · scpcom · commit 8feee873bab7 · 2020-11-22T22:14:03.000+01:00
diff --git a/libraries/Sipeed_GD32V_LCD/examples/image_display/image_display.ino b/libraries/Sipeed_GD32V_LCD/examples/image_display/image_display.ino
@@ -24,9 +24,9 @@ static uint8_t lcdBuffer[LCD_W*LCD_BUF_H*2];
 bool sdMounted = false;
 
 
-void DrawImageFromFile(char* path)
+void DrawImageFromFile(const char* path)
 {
-    int offset = 0;
+    uint32_t offset = 0;
     uint16_t top = 0;
     uint32_t dataSize = 0;
     File dataFile;
@@ -79,7 +79,7 @@ void DrawImageFromFile(char* path)
         lcd.setTextSize(2);
         lcd.setTextColor(COLOR_RED);
         lcd.setCursor(0,32);
-        lcd.print("File "); lcd.print(path); lcd.println(" not found.");
+        lcd.printf("File %s not found.", path);
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -24,9 +24,9 @@ static uint8_t lcdBuffer[LCD_WLCD_BUF_H2];`
`24`	`24`	`bool sdMounted = false;`
`25`	`25`
`26`	`26`
`27`		`-void DrawImageFromFile(char* path)`
	`27`	`+void DrawImageFromFile(const char* path)`
`28`	`28`	`{`
`29`		`- int offset = 0;`
	`29`	`+ uint32_t offset = 0;`
`30`	`30`	`uint16_t top = 0;`
`31`	`31`	`uint32_t dataSize = 0;`
`32`	`32`	`File dataFile;`
`@@ -79,7 +79,7 @@ void DrawImageFromFile(char* path)`
`79`	`79`	`lcd.setTextSize(2);`
`80`	`80`	`lcd.setTextColor(COLOR_RED);`
`81`	`81`	`lcd.setCursor(0,32);`
`82`		`- lcd.print("File "); lcd.print(path); lcd.println(" not found.");`
	`82`	`+ lcd.printf("File %s not found.", path);`
`83`	`83`	`}`
`84`	`84`	`}`
`85`	`85`