Bugfix - checking that condition_dsp is not null in the JSON (#220)

jfsantos · web-flow · commit 95c7aa66adcd · 2026-02-11T16:42:43.000-08:00
diff --git a/NAM/wavenet.cpp b/NAM/wavenet.cpp
@@ -573,7 +573,7 @@ std::unique_ptr<nam::DSP> nam::wavenet::Factory(const nlohmann::json& config, st
                                                 const double expectedSampleRate)
 {
   std::unique_ptr<nam::DSP> condition_dsp = nullptr;
-  if (config.find("condition_dsp") != config.end())
+  if (config.find("condition_dsp") != config.end() && !config["condition_dsp"].is_null())
   {
     const nlohmann::json& condition_dsp_json = config["condition_dsp"];
     condition_dsp = nam::get_dsp(condition_dsp_json);

Original file line number	Diff line number	Diff line change
`@@ -573,7 +573,7 @@ std::unique_ptr<nam::DSP> nam::wavenet::Factory(const nlohmann::json& config, st`
`573`	`573`	`const double expectedSampleRate)`
`574`	`574`	`{`
`575`	`575`	`std::unique_ptr<nam::DSP> condition_dsp = nullptr;`
`576`		`- if (config.find("condition_dsp") != config.end())`
	`576`	`+ if (config.find("condition_dsp") != config.end() && !config["condition_dsp"].is_null())`
`577`	`577`	`{`
`578`	`578`	`const nlohmann::json& condition_dsp_json = config["condition_dsp"];`
`579`	`579`	`condition_dsp = nam::get_dsp(condition_dsp_json);`