Merge pull request #275 from secrethub/feature/replace-golanci.com

Move linting to CircleCI

Author: SimonBarendse

.circleci/config.yml

@@ -1,5 +1,11 @@
 version: 2
 jobs:
+  lint:
+    docker:
+      - image: golangci/golangci-lint:v1.23.8-alpine
+    steps:
+      - checkout
+      - run: golangci-lint run
   test:
     docker:
       - image: circleci/golang:1.13
@@ -24,5 +30,6 @@ workflows:
   version: 2
   pipeline:
     jobs:
+      - lint
       - test
       - verify-goreleaser

Makefile

@@ -14,8 +14,10 @@ tools: format-tools lint-tools
 format-tools:
 	@go get -u golang.org/x/tools/cmd/goimports
 
+GOLANGCI_VERSION=v1.23.8
+
 lint-tools:
-	@curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin v1.15.0
+	@curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(go env GOPATH)/bin ${GOLANGCI_VERSION}
 
 COMMIT=`git rev-parse --short HEAD`
 VERSION=`git describe --always`

README.md

@@ -7,7 +7,6 @@
 
 [![GoDoc](https://godoc.org/github.com/secrethub/secrethub-cli?status.svg)][godoc]
 [![CircleCI](https://circleci.com/gh/secrethub/secrethub-cli.svg?style=shield)][circle-ci]
-[![GolangCI](https://golangci.com/badges/github.com/secrethub/secrethub-cli.svg)][golang-ci]
 [![Go Report Card](https://goreportcard.com/badge/github.com/secrethub/secrethub-cli)][goreportcard]
 [![Version]( https://img.shields.io/github/release/secrethub/secrethub-cli.svg)][latest-version]
 [![Discord](https://img.shields.io/badge/chat-on%20discord-7289da.svg?logo=discord)][discord]
@@ -101,7 +100,6 @@ Run a single test:
 [releases]: https://github.com/secrethub/secrethub-cli/releases
 [latest-version]: https://github.com/secrethub/secrethub-cli/releases/latest
 [godoc]: http://godoc.org/github.com/secrethub/secrethub-cli
-[golang-ci]: https://golangci.com/r/github.com/secrethub/secrethub-cli
 [goreportcard]: https://goreportcard.com/report/github.com/secrethub/secrethub-cli
 [circle-ci]: https://circleci.com/gh/secrethub/secrethub-cli
 [discord]: https://discord.gg/gyQXAFU