Merge pull request #252 from secrethub/feature/update-is-err-not-found

Use api.IsErrNotFound

Author: Marton6

internals/secrethub/list.go

@@ -85,7 +85,7 @@ func (cmd *LsCommand) Run() error {
 		dirFS, err := client.Dirs().GetTree(dirPath.Value(), 1, false)
 		if api.IsErrNotFound(err) && dirPath.IsRepoPath() {
 			return err
-		} else if err != nil && !isErrNotFound(err) {
+		} else if err != nil && !api.IsErrNotFound(err) {
 			return err
 		} else if err == nil {
 			err = printDir(cmd.io.Stdout(), cmd.quiet, dirFS.RootDir, timeFormatter)

internals/secrethub/secret_reader.go

@@ -2,7 +2,7 @@ package secrethub
 
 import (
 	"github.com/secrethub/secrethub-cli/internals/secrethub/tpl"
-	"github.com/secrethub/secrethub-go/internals/errio"
+	"github.com/secrethub/secrethub-go/internals/api"
 )
 
 type secretReader struct {
@@ -82,18 +82,8 @@ func newIgnoreMissingSecretReader(sr tpl.SecretReader) *ignoreMissingSecretReade
 // errors for non-existing secrets. Instead, it returns the empty string.
 func (sr *ignoreMissingSecretReader) ReadSecret(path string) (string, error) {
 	secret, err := sr.secretReader.ReadSecret(path)
-	if isErrNotFound(err) {
+	if api.IsErrNotFound(err) {
 		return "", nil
 	}
 	return secret, err
 }
-
-// isErrNotFound returns whether the given error is caused by a un-existing resource.
-// TODO: Replace this function with github.com/secrethub/secrethub-go/blob/develop/internals/api.IsErrNotFound once that is released.
-func isErrNotFound(err error) bool {
-	statusError, ok := err.(errio.PublicStatusError)
-	if !ok {
-		return false
-	}
-	return statusError.StatusCode == 404
-}