Preallocate slice with capacitiy

jpcoenen · jpcoenen · commit 86f3788db0b7 · 2020-07-07T13:30:48.000+02:00
diff --git a/internals/secrethub/service_gcp_init.go b/internals/secrethub/service_gcp_init.go
@@ -216,7 +216,7 @@ func (l *gcpServiceAccountOptionLister) Options() ([]ui.Option, bool, error) {
 		return nil, false, gcp.HandleError(err)
 	}
 
-	var options []ui.Option
+	options := make([]ui.Option, 0, len(resp.Accounts))
 	for _, account := range resp.Accounts {
 		if err := api.ValidateGCPServiceAccountEmail(account.Email); err != nil {
 			continue

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ func (l *gcpServiceAccountOptionLister) Options() ([]ui.Option, bool, error) {`
`216`	`216`	`return nil, false, gcp.HandleError(err)`
`217`	`217`	`}`
`218`	`218`
`219`		`- var options []ui.Option`
	`219`	`+ options := make([]ui.Option, 0, len(resp.Accounts))`
`220`	`220`	`for _, account := range resp.Accounts {`
`221`	`221`	`if err := api.ValidateGCPServiceAccountEmail(account.Email); err != nil {`
`222`	`222`	`continue`