Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Commit 896efa2

Browse files
Merge pull request #253 from secrethub/fix/env-source-precedence
Fix order of env sources
2 parents eecbb0b + 6d8decd commit 896efa2

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

internals/secrethub/run.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -117,16 +117,16 @@ func (cmd *RunCommand) Run() error {
117117

118118
osEnv, passthroughEnv := parseKeyValueStringsToMap(cmd.osEnv)
119119

120-
referenceEnv := newReferenceEnv(osEnv)
121-
envSources = append(envSources, referenceEnv)
122-
123120
// TODO: Validate the flags when parsing by implementing the Flag interface for EnvFlags.
124121
flagSource, err := NewEnvFlags(cmd.envar)
125122
if err != nil {
126123
return err
127124
}
128125
envSources = append(envSources, flagSource)
129126

127+
referenceEnv := newReferenceEnv(osEnv)
128+
envSources = append(envSources, referenceEnv)
129+
130130
if cmd.envFile == "" {
131131
const defaultEnvFile = "secrethub.env"
132132
_, err := os.Stat(defaultEnvFile)

0 commit comments

Comments
 (0)