Extract listing acl check levels to a function

Author: SimonBarendse

internals/secrethub/acl_check.go

@@ -40,29 +40,11 @@ func (cmd *ACLCheckCommand) Register(r command.Registerer) {
 
 // Run prints the access level(s) on the given directory.
 func (cmd *ACLCheckCommand) Run() error {
-	client, err := cmd.newClient()
+	levels, err := cmd.listLevels()
 	if err != nil {
 		return err
 	}
 
-	path := cmd.path.Value()
-
-	levels, err := client.AccessRules().ListLevels(path)
-	if api.IsErrNotFound(err) {
-		isSecret, err := client.Secrets().Exists(path)
-		if err != nil {
-			return err
-		}
-		if isSecret {
-			levels, err = client.AccessRules().ListLevels(secretpath.Parent(path))
-			if err != nil {
-				return err
-			}
-		}
-	} else if err != nil {
-		return err
-	}
-
 	if cmd.accountName != "" {
 		for _, level := range levels {
 			if level.Account.Name == cmd.accountName {
@@ -94,3 +76,31 @@ func (cmd *ACLCheckCommand) Run() error {
 
 	return nil
 }
+
+func (cmd *ACLCheckCommand) listLevels() ([]*api.AccessLevel, error) {
+	client, err := cmd.newClient()
+	if err != nil {
+		return nil, err
+	}
+
+	path := cmd.path.Value()
+
+	levels, err := client.AccessRules().ListLevels(path)
+	if api.IsErrNotFound(err) {
+		isSecret, isSecretErr := client.Secrets().Exists(path)
+		if isSecretErr != nil {
+			return nil, err
+		}
+		if isSecret {
+			levels, err = client.AccessRules().ListLevels(secretpath.Parent(path))
+			if err != nil {
+				return nil, err
+			}
+			return levels, nil
+		}
+	} else if err != nil {
+		return nil, err
+	}
+
+	return levels, nil
+}