SN-1938 Validate user id

Author: Inbal Tako

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    securenative (0.1.21)
+    securenative (0.1.22)
 
 GEM
   remote: https://rubygems.org/

README.md

@@ -96,7 +96,7 @@ require 'models/user_traits'
 
 def track
     securenative = SecureNative.instance
-    context = SecureNativeContext.new(client_token: '2a980d872b939c7e4f4378aa111a5eeffb22808b58b5372f658d34904ebd5b05fff0daab91921243ac08b72442a5b3992e402dc21df16aa7cc0e19f8bffa9d6cc59996d480d70aa22b857189403675d37fd144ebaf9dc697fed149b907678f2b1f964d73b332dc8ea7df63fcfc3c11f7bbb51ba2672652ca7d5d43f36a62e15db8b13dfd794a5eccfc5968ca514dd7cce59f2df2b9d8184d076eba808c81b311', ip: '127.0.0.1',
+    context = SecureNativeContext.new(client_token: 'SECURED_CLIENT_TOKEN', ip: '127.0.0.1',
                                        headers: { 'user-agent' => 'Mozilla: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:47.0) Gecko/20100101 Firefox/47.3 Mozilla/5.0 (Macintosh; Intel Mac OS X x.y; rv:42.0) Gecko/20100101 Firefox/43.4' })
 
     event_options = EventOptions.new(event: EventTypes::LOG_IN, user_id: '1234', context: context,
@@ -118,7 +118,7 @@ require 'enums/event_types'
 require 'models/user_traits'
 
 
-def track
+def track(request)
     securenative = SecureNative.instance
     context = SecureNativeContext.from_http_request(request)
 

lib/models/sdk_event.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'context/securenative_context'
+require 'errors/securenative_invalid_options_error'
 require 'utils/encryption_utils'
 require 'utils/date_utils'
 require 'models/request_context'
@@ -11,6 +12,14 @@ class SDKEvent
   attr_writer :context, :rid, :event_type, :user_id, :user_traits, :request, :timestamp, :properties
 
   def initialize(event_options, securenative_options)
+    if event_options.user_id.nil? || event_options.user_id.length <= 0 || event_options.user_id == ''
+      raise SecureNativeInvalidOptionsError.new, 'Invalid event structure; User Id is missing'
+    end
+
+    if event_options.event.nil? || event_options.event.length <= 0 || event_options.event == ''
+      raise SecureNativeInvalidOptionsError.new, 'Invalid event structure; Event Type is missing'
+    end
+
     @context = if !event_options.context.nil?
                  event_options.context
                else

securenative.gemspec

@@ -4,7 +4,7 @@ require_relative "lib/utils/version_utils"
 
 Gem::Specification.new do |spec|
   spec.name          = "securenative"
-  spec.version       = "0.1.21"
+  spec.version       = "0.1.22"
   spec.authors       = ["SecureNative"]
   spec.email         = ["support@securenative.com"]
 

spec/spec_sdk_event.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+require 'models/sdk_event'
+require 'models/event_options'
+require 'config/securenative_options'
+require 'enums/event_types'
+require 'errors/securenative_invalid_options_error'
+require 'rspec'
+
+RSpec.describe SDKEvent do
+  it 'throws when event created without user id' do
+    event_options = EventOptions.new(event: EventTypes::LOG_IN, user_id: nil)
+    options = SecureNativeOptions.new
+
+    expect { SDKEvent.new(event_options, options) }.to raise_error(SecureNativeInvalidOptionsError)
+  end
+
+  it 'throws when event created without event type' do
+    event_options = EventOptions.new(event: nil, user_id: '1234')
+    options = SecureNativeOptions.new
+
+    expect { SDKEvent.new(event_options, options) }.to raise_error(SecureNativeInvalidOptionsError)
+  end
+end