Skip to content

Commit 87855af

Browse files
Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent a6f6fca commit 87855af

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

analytics/src/main/java/com/segment/analytics/Analytics.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ public Analytics build() {
397397
maximumQueueSizeInBytes = MESSAGE_QUEUE_MAX_BYTE_SIZE;
398398
}
399399
if (maximumFlushAttempts == 0) {
400-
// Adjusted upward to accomodate shorter max retry backoff.
400+
// Adjusted upward to accommodate shorter max retry backoff.
401401
maximumFlushAttempts = 1000;
402402
}
403403
if (messageTransformers == null) {

analytics/src/test/java/com/segment/analytics/internal/AnalyticsClientTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -619,7 +619,7 @@ public Call<UploadResponse> answer(InvocationOnMock invocation) {
619619
batchUploadTask.run();
620620

621621
// DEFAULT_RETRIES == maxRetries
622-
// tries 11(one normal run + 10 retries)
622+
// tries 4 times (one normal run + 3 retries)
623623
verify(segmentService, times(4)).upload(anyInt(), isNull(), eq(batch));
624624
verify(callback)
625625
.failure(
@@ -634,7 +634,7 @@ public boolean matches(IOException exception) {
634634
}
635635

636636
@Test
637-
public void xRetryCountHeaderOnlyAppearsOnRetries() {
637+
public void xRetryCountHeaderIncrementsWithEachAttempt() {
638638
AnalyticsClient client = newClient();
639639
TrackMessage trackMessage = TrackMessage.builder("foo").userId("bar").build();
640640
Batch batch = batchFor(trackMessage);

0 commit comments

Comments
 (0)