Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: MichaelGHSeg

segment/analytics/request.py

@@ -5,7 +5,7 @@
 import json
 import base64
 from dateutil.tz import tzutc
-from requests.auth import HTTPBasicAuth
+
 from requests import sessions
 
 from segment.analytics.version import VERSION
@@ -30,7 +30,8 @@ def parse_retry_after(response):
     try:
         # Try parsing as integer (delay in seconds)
         delay = int(retry_after)
-        return min(delay, MAX_RETRY_AFTER_SECONDS)
+        # Ensure delay is non-negative before applying upper bound
+        return min(max(delay, 0), MAX_RETRY_AFTER_SECONDS)
     except ValueError:
         # Could be HTTP-date format, but for simplicity we'll skip that
         # Most APIs use integer seconds

segment/analytics/test/test_consumer.py

@@ -490,10 +490,8 @@ def mock_post_fn(*args, **kwargs):
             raise FatalError('Fatal error occurred')
 
         with mock.patch('segment.analytics.consumer.post', side_effect=mock_post_fn):
-            try:
+            with self.assertRaises(FatalError):
                 consumer.request([track])
-            except FatalError:
-                pass
 
         # Should only be called once (no retries)
         self.assertEqual(call_count, 1)