Upgrade to go 1.24.5 (#2420)

masih · web-flow · commit 5820ece53789 · 2025-10-01T12:46:06.000+01:00
Port of original work done in sei-protocol/sei-cosmos#604, excluding the CI workflow updates since the CI workflows are relocated in `sei-chain`. Upgrade to go 1.24.5, consistent with sei-chain. While at it, resolve false negative test failures: * use testing temp directory * use constant pattern for formatting printers * follow required go naming convention in examples
diff --git a/sei-cosmos/crypto/hd/hdpath_test.go b/sei-cosmos/crypto/hd/hdpath_test.go
@@ -186,7 +186,7 @@ func TestDeriveHDPathRange(t *testing.T) {
 	}
 }
 
-func ExampleStringifyPathParams() {
+func ExampleNewParams() {
 	path := hd.NewParams(44, 0, 0, false, 0)
 	fmt.Println(path.String())
 	path = hd.NewParams(44, 33, 7, true, 9)
@@ -196,7 +196,7 @@ func ExampleStringifyPathParams() {
 	// m/44'/33'/7'/1/9
 }
 
-func ExampleSomeBIP32TestVecs() {
+func ExampleComputeMastersFromSeed() {
 	seed := mnemonicToSeed("barrel original fuel morning among eternal " +
 		"filter ball stove pluck matrix mechanic")
 	master, ch := hd.ComputeMastersFromSeed(seed)
diff --git a/sei-cosmos/go.mod b/sei-cosmos/go.mod
@@ -1,7 +1,7 @@
-go 1.21
-
 module github.com/cosmos/cosmos-sdk
 
+go 1.24.5
+
 require (
 	cosmossdk.io/errors v1.0.0
 	github.com/99designs/keyring v1.2.1
diff --git a/sei-cosmos/server/start.go b/sei-cosmos/server/start.go
@@ -6,6 +6,8 @@ import (
 	"context"
 	"fmt"
 	"net/http"
+	//nolint:gosec,G108
+	_ "net/http/pprof"
 	"os"
 	"path"
 	"runtime/pprof"
@@ -25,9 +27,6 @@ import (
 	"go.opentelemetry.io/otel/sdk/trace"
 	"google.golang.org/grpc"
 
-	//nolint:gosec,G108
-	_ "net/http/pprof"
-
 	"github.com/cosmos/cosmos-sdk/client"
 	"github.com/cosmos/cosmos-sdk/client/flags"
 	"github.com/cosmos/cosmos-sdk/codec"
@@ -310,7 +309,7 @@ func startStandAlone(ctx *Context, appCreator types.AppCreator) error {
 	goCtx, cancel := context.WithCancel(context.Background())
 	err = svr.Start(goCtx)
 	if err != nil {
-		fmt.Printf(err.Error() + "\n")
+		fmt.Println(err.Error())
 		os.Exit(1)
 	}
 
diff --git a/sei-cosmos/x/auth/ante/fee.go b/sei-cosmos/x/auth/ante/fee.go
@@ -207,7 +207,7 @@ func DeductFees(bankKeeper types.BankKeeper, ctx sdk.Context, acc types.AccountI
 
 	err := bankKeeper.DeferredSendCoinsFromAccountToModule(ctx, acc.GetAddress(), types.FeeCollectorName, fees)
 	if err != nil {
-		return sdkerrors.Wrapf(sdkerrors.ErrInsufficientFunds, err.Error())
+		return sdkerrors.Wrapf(sdkerrors.ErrInsufficientFunds, "%s", err.Error())
 	}
 
 	return nil
diff --git a/sei-cosmos/x/auth/keeper/grpc_query.go b/sei-cosmos/x/auth/keeper/grpc_query.go
@@ -67,7 +67,7 @@ func (ak AccountKeeper) Account(c context.Context, req *types.QueryAccountReques
 
 	any, err := codectypes.NewAnyWithValue(account)
 	if err != nil {
-		return nil, status.Errorf(codes.Internal, err.Error())
+		return nil, status.Errorf(codes.Internal, "%s", err.Error())
 	}
 
 	return &types.QueryAccountResponse{Account: any}, nil
diff --git a/sei-cosmos/x/authz/keeper/grpc_query.go b/sei-cosmos/x/authz/keeper/grpc_query.go
@@ -39,7 +39,7 @@ func (k Keeper) Grants(c context.Context, req *authz.QueryGrantsRequest) (*authz
 		}
 		authorizationAny, err := codectypes.NewAnyWithValue(authorization)
 		if err != nil {
-			return nil, status.Errorf(codes.Internal, err.Error())
+			return nil, status.Errorf(codes.Internal, "%s", err.Error())
 		}
 		return &authz.QueryGrantsResponse{
 			Grants: []*authz.Grant{{
@@ -61,7 +61,7 @@ func (k Keeper) Grants(c context.Context, req *authz.QueryGrantsRequest) (*authz
 
 		authorizationAny, err := codectypes.NewAnyWithValue(auth1)
 		if err != nil {
-			return nil, status.Errorf(codes.Internal, err.Error())
+			return nil, status.Errorf(codes.Internal, "%s", err.Error())
 		}
 		return &authz.Grant{
 			Authorization: authorizationAny,
@@ -103,7 +103,7 @@ func (k Keeper) GranterGrants(c context.Context, req *authz.QueryGranterGrantsRe
 
 		any, err := codectypes.NewAnyWithValue(auth1)
 		if err != nil {
-			return nil, status.Errorf(codes.Internal, err.Error())
+			return nil, status.Errorf(codes.Internal, "%s", err.Error())
 		}
 
 		grantee := firstAddressFromGrantStoreKey(key)
@@ -155,7 +155,7 @@ func (k Keeper) GranteeGrants(c context.Context, req *authz.QueryGranteeGrantsRe
 
 		authorizationAny, err := codectypes.NewAnyWithValue(auth1)
 		if err != nil {
-			return nil, status.Errorf(codes.Internal, err.Error())
+			return nil, status.Errorf(codes.Internal, "%s", err.Error())
 		}
 
 		return &authz.GrantAuthorization{
diff --git a/sei-cosmos/x/capability/keeper/keeper.go b/sei-cosmos/x/capability/keeper/keeper.go
@@ -229,7 +229,7 @@ func (sk ScopedKeeper) NewCapability(ctx sdk.Context, name string) (*types.Capab
 	store := ctx.KVStore(sk.storeKey)
 
 	if _, ok := sk.GetCapability(ctx, name); ok {
-		return nil, sdkerrors.Wrapf(types.ErrCapabilityTaken, fmt.Sprintf("module: %s, name: %s", sk.module, name))
+		return nil, sdkerrors.Wrapf(types.ErrCapabilityTaken, "module: %s, name: %s", sk.module, name)
 	}
 
 	// create new capability with the current global index
diff --git a/sei-cosmos/x/capability/types/types.go b/sei-cosmos/x/capability/types/types.go
@@ -47,7 +47,7 @@ func (co *CapabilityOwners) Set(owner Owner) error {
 	i, ok := co.Get(owner)
 	if ok {
 		// owner already exists at co.Owners[i]
-		return sdkerrors.Wrapf(ErrOwnerClaimed, owner.String())
+		return sdkerrors.Wrapf(ErrOwnerClaimed, "%s", owner.String())
 	}
 
 	// owner does not exist in the set of owners, so we insert at position i
diff --git a/sei-cosmos/x/evidence/keeper/grpc_query.go b/sei-cosmos/x/evidence/keeper/grpc_query.go
@@ -42,7 +42,7 @@ func (k Keeper) Evidence(c context.Context, req *types.QueryEvidenceRequest) (*t
 
 	evidenceAny, err := codectypes.NewAnyWithValue(msg)
 	if err != nil {
-		return nil, status.Errorf(codes.Internal, err.Error())
+		return nil, status.Errorf(codes.Internal, "%s", err.Error())
 	}
 
 	return &types.QueryEvidenceResponse{Evidence: evidenceAny}, nil
diff --git a/sei-cosmos/x/feegrant/keeper/grpc_query.go b/sei-cosmos/x/feegrant/keeper/grpc_query.go
@@ -36,7 +36,7 @@ func (q Keeper) Allowance(c context.Context, req *feegrant.QueryAllowanceRequest
 
 	feeAllowance, err := q.GetAllowance(ctx, granterAddr, granteeAddr)
 	if err != nil {
-		return nil, status.Errorf(codes.Internal, err.Error())
+		return nil, status.Errorf(codes.Internal, "%s", err.Error())
 	}
 
 	msg, ok := feeAllowance.(proto.Message)
@@ -46,7 +46,7 @@ func (q Keeper) Allowance(c context.Context, req *feegrant.QueryAllowanceRequest
 
 	feeAllowanceAny, err := codectypes.NewAnyWithValue(msg)
 	if err != nil {
-		return nil, status.Errorf(codes.Internal, err.Error())
+		return nil, status.Errorf(codes.Internal, "%s", err.Error())
 	}
 
 	return &feegrant.QueryAllowanceResponse{
diff --git a/sei-cosmos/x/genutil/collect_test.go b/sei-cosmos/x/genutil/collect_test.go
@@ -2,7 +2,6 @@ package genutil_test
 
 import (
 	"encoding/json"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"testing"
@@ -38,12 +37,7 @@ func (dni *doNothingIterator) IterateGenesisBalances(_ codec.JSONCodec, _ map[st
 // Ensures that CollectTx correctly traverses directories and won't error out on encountering
 // a directory during traversal of the first level. See issue https://github.com/cosmos/cosmos-sdk/issues/6788.
 func TestCollectTxsHandlesDirectories(t *testing.T) {
-	testDir, err := ioutil.TempDir(os.TempDir(), "testCollectTxs")
-	if err != nil {
-		t.Fatal(err)
-	}
-	defer os.RemoveAll(testDir)
-
+	testDir := t.TempDir()
 	// 1. We'll insert a directory as the first element before JSON file.
 	subDirPath := filepath.Join(testDir, "_adir")
 	if err := os.MkdirAll(subDirPath, 0755); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -186,7 +186,7 @@ func TestDeriveHDPathRange(t *testing.T) {`
`186`	`186`	`}`
`187`	`187`	`}`
`188`	`188`
`189`		`-func ExampleStringifyPathParams() {`
	`189`	`+func ExampleNewParams() {`
`190`	`190`	`path := hd.NewParams(44, 0, 0, false, 0)`
`191`	`191`	`fmt.Println(path.String())`
`192`	`192`	`path = hd.NewParams(44, 33, 7, true, 9)`
`@@ -196,7 +196,7 @@ func ExampleStringifyPathParams() {`
`196`	`196`	`// m/44'/33'/7'/1/9`
`197`	`197`	`}`
`198`	`198`
`199`		`-func ExampleSomeBIP32TestVecs() {`
	`199`	`+func ExampleComputeMastersFromSeed() {`
`200`	`200`	`seed := mnemonicToSeed("barrel original fuel morning among eternal " +`
`201`	`201`	`"filter ball stove pluck matrix mechanic")`
`202`	`202`	`master, ch := hd.ComputeMastersFromSeed(seed)`
Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ func DeductFees(bankKeeper types.BankKeeper, ctx sdk.Context, acc types.AccountI`
`207`	`207`
`208`	`208`	`err := bankKeeper.DeferredSendCoinsFromAccountToModule(ctx, acc.GetAddress(), types.FeeCollectorName, fees)`
`209`	`209`	`if err != nil {`
`210`		`- return sdkerrors.Wrapf(sdkerrors.ErrInsufficientFunds, err.Error())`
	`210`	`+ return sdkerrors.Wrapf(sdkerrors.ErrInsufficientFunds, "%s", err.Error())`
`211`	`211`	`}`
`212`	`212`
`213`	`213`	`return nil`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ func (ak AccountKeeper) Account(c context.Context, req *types.QueryAccountReques`
`67`	`67`
`68`	`68`	`any, err := codectypes.NewAnyWithValue(account)`
`69`	`69`	`if err != nil {`
`70`		`- return nil, status.Errorf(codes.Internal, err.Error())`
	`70`	`+ return nil, status.Errorf(codes.Internal, "%s", err.Error())`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`return &types.QueryAccountResponse{Account: any}, nil`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func (k Keeper) Grants(c context.Context, req authz.QueryGrantsRequest) (authz`
`39`	`39`	`}`
`40`	`40`	`authorizationAny, err := codectypes.NewAnyWithValue(authorization)`
`41`	`41`	`if err != nil {`
`42`		`- return nil, status.Errorf(codes.Internal, err.Error())`
	`42`	`+ return nil, status.Errorf(codes.Internal, "%s", err.Error())`
`43`	`43`	`}`
`44`	`44`	`return &authz.QueryGrantsResponse{`
`45`	`45`	`Grants: []*authz.Grant{{`
`@@ -61,7 +61,7 @@ func (k Keeper) Grants(c context.Context, req authz.QueryGrantsRequest) (authz`
`61`	`61`
`62`	`62`	`authorizationAny, err := codectypes.NewAnyWithValue(auth1)`
`63`	`63`	`if err != nil {`
`64`		`- return nil, status.Errorf(codes.Internal, err.Error())`
	`64`	`+ return nil, status.Errorf(codes.Internal, "%s", err.Error())`
`65`	`65`	`}`
`66`	`66`	`return &authz.Grant{`
`67`	`67`	`Authorization: authorizationAny,`
`@@ -103,7 +103,7 @@ func (k Keeper) GranterGrants(c context.Context, req *authz.QueryGranterGrantsRe`
`103`	`103`
`104`	`104`	`any, err := codectypes.NewAnyWithValue(auth1)`
`105`	`105`	`if err != nil {`
`106`		`- return nil, status.Errorf(codes.Internal, err.Error())`
	`106`	`+ return nil, status.Errorf(codes.Internal, "%s", err.Error())`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`grantee := firstAddressFromGrantStoreKey(key)`
`@@ -155,7 +155,7 @@ func (k Keeper) GranteeGrants(c context.Context, req *authz.QueryGranteeGrantsRe`
`155`	`155`
`156`	`156`	`authorizationAny, err := codectypes.NewAnyWithValue(auth1)`
`157`	`157`	`if err != nil {`
`158`		`- return nil, status.Errorf(codes.Internal, err.Error())`
	`158`	`+ return nil, status.Errorf(codes.Internal, "%s", err.Error())`
`159`	`159`	`}`
`160`	`160`
`161`	`161`	`return &authz.GrantAuthorization{`
Original file line number	Diff line number	Diff line change
`@@ -229,7 +229,7 @@ func (sk ScopedKeeper) NewCapability(ctx sdk.Context, name string) (*types.Capab`
`229`	`229`	`store := ctx.KVStore(sk.storeKey)`
`230`	`230`
`231`	`231`	`if _, ok := sk.GetCapability(ctx, name); ok {`
`232`		`- return nil, sdkerrors.Wrapf(types.ErrCapabilityTaken, fmt.Sprintf("module: %s, name: %s", sk.module, name))`
	`232`	`+ return nil, sdkerrors.Wrapf(types.ErrCapabilityTaken, "module: %s, name: %s", sk.module, name)`
`233`	`233`	`}`
`234`	`234`
`235`	`235`	`// create new capability with the current global index`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ func (co *CapabilityOwners) Set(owner Owner) error {`
`47`	`47`	`i, ok := co.Get(owner)`
`48`	`48`	`if ok {`
`49`	`49`	`// owner already exists at co.Owners[i]`
`50`		`- return sdkerrors.Wrapf(ErrOwnerClaimed, owner.String())`
	`50`	`+ return sdkerrors.Wrapf(ErrOwnerClaimed, "%s", owner.String())`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`// owner does not exist in the set of owners, so we insert at position i`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ func (k Keeper) Evidence(c context.Context, req types.QueryEvidenceRequest) (t`
`42`	`42`
`43`	`43`	`evidenceAny, err := codectypes.NewAnyWithValue(msg)`
`44`	`44`	`if err != nil {`
`45`		`- return nil, status.Errorf(codes.Internal, err.Error())`
	`45`	`+ return nil, status.Errorf(codes.Internal, "%s", err.Error())`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`return &types.QueryEvidenceResponse{Evidence: evidenceAny}, nil`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ func (q Keeper) Allowance(c context.Context, req *feegrant.QueryAllowanceRequest`
`36`	`36`
`37`	`37`	`feeAllowance, err := q.GetAllowance(ctx, granterAddr, granteeAddr)`
`38`	`38`	`if err != nil {`
`39`		`- return nil, status.Errorf(codes.Internal, err.Error())`
	`39`	`+ return nil, status.Errorf(codes.Internal, "%s", err.Error())`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`msg, ok := feeAllowance.(proto.Message)`
`@@ -46,7 +46,7 @@ func (q Keeper) Allowance(c context.Context, req *feegrant.QueryAllowanceRequest`
`46`	`46`
`47`	`47`	`feeAllowanceAny, err := codectypes.NewAnyWithValue(msg)`
`48`	`48`	`if err != nil {`
`49`		`- return nil, status.Errorf(codes.Internal, err.Error())`
	`49`	`+ return nil, status.Errorf(codes.Internal, "%s", err.Error())`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`return &feegrant.QueryAllowanceResponse{`