refactor: consolidate SnapshotGenerationOverrides, add storage/chain key constants

Merge StateSyncerOverrides into SnapshotGenerationOverrides since P2P
capacity, pruning tightening, and snapshot creation are all part of
what a snapshot-generating node needs. Remove pruning=nothing (that's
an archive mode default, not a snapshot generation concern).

Add exported Key constants for storage and chain override paths so
consumers don't use raw strings.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: bdchatham

config.go

@@ -70,8 +70,14 @@ func NodePortsForMode(mode NodeMode) []NodePort {
 	}
 }
 
-// Override key constants for P2P configuration fields.
+// Override key constants for the unified config schema.
 const (
+	KeyPruningKeepRecent  = "storage.pruning_keep_recent"
+	KeyPruningKeepEvery   = "storage.pruning_keep_every"
+	KeySnapshotInterval   = "storage.snapshot_interval"
+	KeySnapshotKeepRecent = "storage.snapshot_keep_recent"
+	KeyMinRetainBlocks    = "chain.min_retain_blocks"
+
 	KeyP2PExternalAddress = "network.p2p.external_address"
 	KeyP2PMaxConnections  = "network.p2p.max_connections"
 	KeyP2PSendRate        = "network.p2p.send_rate"

defaults.go

@@ -309,24 +309,20 @@ func applyArchiveOverrides(cfg *SeiConfig) {
 	cfg.Storage.StateCommit.MemIAVL.SnapshotMinTimeInterval = 20000
 }
 
-// SnapshotGenerationOverrides returns the config overrides needed when a node
-// is configured to produce Tendermint state-sync snapshots. The controller
-// applies these as ConfigIntent.Overrides alongside the mode defaults.
+// SnapshotGenerationOverrides returns overrides for full-mode nodes that
+// generate CometBFT state-sync snapshots. Includes snapshot creation,
+// tighter pruning than the full-node default, and elevated P2P capacity
+// for serving snapshot chunks to peers.
 func SnapshotGenerationOverrides(keepRecent int32) map[string]string {
 	return map[string]string{
-		"storage.pruning":              PruningNothing,
-		"storage.snapshot_interval":    strconv.FormatInt(DefaultSnapshotInterval, 10),
-		"storage.snapshot_keep_recent": strconv.FormatInt(int64(keepRecent), 10),
-	}
-}
-
-// StateSyncerOverrides returns the config overrides for nodes acting as
-// state-sync snapshot servers.
-func StateSyncerOverrides() map[string]string {
-	return map[string]string{
-		KeyP2PMaxConnections: "500",
-		KeyP2PSendRate:       "20971520",
-		KeyP2PRecvRate:       "20971520",
+		KeySnapshotInterval:   strconv.FormatInt(DefaultSnapshotInterval, 10),
+		KeySnapshotKeepRecent: strconv.FormatInt(int64(keepRecent), 10),
+		KeyPruningKeepRecent:  "50000",
+		KeyPruningKeepEvery:   "0",
+		KeyMinRetainBlocks:    "50000",
+		KeyP2PMaxConnections:  "500",
+		KeyP2PSendRate:        "20971520",
+		KeyP2PRecvRate:        "20971520",
 	}
 }