Upgrade to Go 1.24 and fix all golangci-lint issues (#117)

Author: masih

.github/workflows/codeql.yml

@@ -24,7 +24,7 @@ jobs:
         uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '1.19'
+          go-version: '1.24'
       # Initializes the CodeQL tools for scanning.
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v2

.github/workflows/golangci.yml

@@ -17,9 +17,8 @@ jobs:
     steps:
       - uses: actions/setup-go@v3
         with:
-          go-version: '1.19'
-      - uses: actions/checkout@v3
-      - uses: golangci/golangci-lint-action@v3
+          go-version: '1.24'
+      - uses: actions/checkout@v5
+      - uses: golangci/golangci-lint-action@v8
         with:
-          version: v1.49
-          args: --config=.golangci.yml --timeout=10m
+          version: v2.4.0

.github/workflows/unit_tests.yml

@@ -15,7 +15,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v3
         with:
-          go-version: '1.19'
+          go-version: '1.24'
       - uses: actions/checkout@v3
       - name: Run Go Tests
         run: |
@@ -30,7 +30,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v3
         with:
-          go-version: '1.19'
+          go-version: '1.24'
       - uses: actions/checkout@v3
 
       - name: Install RocksDB dependencies
@@ -81,7 +81,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '1.19'
+          go-version: '1.24'
 
       # Download all coverage reports from the 'tests' job
       - name: Download coverage reports

.golangci.yml

@@ -1,48 +1,32 @@
+version: "2"
 run:
   tests: false
-  #   # timeout for analysis, e.g. 30s, 5m, default is 1m
   timeout: 10m
   build-tags:
     - codeanalysis
 
 linters:
-  disable-all: true
+  default: none
   enable:
     - bodyclose
     - dogsled
-    - exportloopref
     - errcheck
     - goconst
-    - gocritic
-    - gofmt
-    - goimports
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - misspell
-    - nakedret
+    - prealloc
     - staticcheck
-    # - structcheck ## author abandoned project
-    - stylecheck
-    - revive
-    - typecheck
     - unconvert
-    - unused
-    - unparam
     - misspell
-    # - nolintlint ## does not work with IDEs like VSCode which automatically insert leading spaces
+  exclusions:
+    rules:
+      - linters:
+          - gosec
+        text: "Use of weak random number generator"
 
-issues:
-  exclude-rules:
-    - text: "Use of weak random number generator"
-      linters:
-        - gosec
-    - text: "ST1003:"
-      linters:
-        - stylecheck
-    # FIXME: Disabled until golangci-lint updates stylecheck with this fix:
-    # https://github.com/dominikh/go-tools/issues/389
-    - text: "ST1016:"
-      linters:
-        - stylecheck
+formatters:
+  enable:
+    - gofmt
+    - goimports

common/utils/versions.go

@@ -1,5 +1,10 @@
 package utils
 
+import (
+	"fmt"
+	"math"
+)
+
 // NextVersion get the next version
 func NextVersion(v int64, initialVersion uint32) int64 {
 	if v == 0 && initialVersion > 1 {
@@ -10,6 +15,9 @@ func NextVersion(v int64, initialVersion uint32) int64 {
 
 // VersionToIndex converts version to rlog index based on initial version
 func VersionToIndex(version int64, initialVersion uint32) uint64 {
+	if version < 0 {
+		panic(fmt.Sprintf("version %d is out of range", version))
+	}
 	if initialVersion > 1 {
 		return uint64(version) - uint64(initialVersion) + 1
 	}
@@ -18,6 +26,12 @@ func VersionToIndex(version int64, initialVersion uint32) uint64 {
 
 // IndexToVersion converts rlog index to version, reverse of versionToIndex
 func IndexToVersion(index uint64, initialVersion uint32) int64 {
+	if index > math.MaxInt64 {
+		panic(fmt.Sprintf("index %d is out of range", index))
+	}
+	if initialVersion > math.MaxInt32 {
+		panic(fmt.Sprintf("initial version %d is out of range", initialVersion))
+	}
 	if initialVersion > 1 {
 		return int64(index) + int64(initialVersion) - 1
 	}

go.mod

@@ -1,6 +1,6 @@
 module github.com/sei-protocol/sei-db
 
-go 1.19
+go 1.24.5
 
 require (
 	github.com/alitto/pond v1.8.3

go.sum

@@ -204,6 +204,7 @@ github.com/cncf/xds/go v0.0.0-20211130200136-a8f946100490/go.mod h1:eXthEFrGJvWH
 github.com/cockroachdb/datadriven v0.0.0-20190809214429-80d97fb3cbaa/go.mod h1:zn76sxSg3SzpJ0PPJaLDCu+Bu0Lg3sKTORVIj19EIF8=
 github.com/cockroachdb/datadriven v1.0.0/go.mod h1:5Ib8Meh+jk1RlHIXej6Pzevx/NLlNvQB9pmSBZErGA4=
 github.com/cockroachdb/datadriven v1.0.3-0.20230413201302-be42291fc80f h1:otljaYPt5hWxV3MUfO5dFPFiOXg9CyG5/kCfayTqsJ4=
+github.com/cockroachdb/datadriven v1.0.3-0.20230413201302-be42291fc80f/go.mod h1:a9RdTaap04u637JoCzcUoIcDmvwSUtcUFtT/C3kJlTU=
 github.com/cockroachdb/errors v1.6.1/go.mod h1:tm6FTP5G81vwJ5lC0SizQo374JNCOPrHyXGitRJoDqM=
 github.com/cockroachdb/errors v1.8.1 h1:A5+txlVZfOqFBDa4mGz2bUWSp0aHElvHX2bKkdbQu+Y=
 github.com/cockroachdb/errors v1.8.1/go.mod h1:qGwQn6JmZ+oMjuLwjWzUNqblqk0xl4CVV3SQbGwK7Ac=
@@ -461,6 +462,7 @@ github.com/google/go-cmp v0.5.6/go.mod h1:v8dTdLbMG2kIc/vJvl+f65V22dbkXbowE6jgT/
 github.com/google/go-cmp v0.5.7/go.mod h1:n+brtR0CgQNWTVd5ZUFpTBC8YFBDLK/h/bpaJ8/DtOE=
 github.com/google/go-cmp v0.5.8/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/google/go-cmp v0.5.9 h1:O2Tfq5qg4qc4AmwVlvv0oLiVAGB7enBSJ2x2DqQFi38=
+github.com/google/go-cmp v0.5.9/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
 github.com/google/go-querystring v1.0.0/go.mod h1:odCYkC5MyYFN7vkCjXpyrEuKhc/BUO6wN/zVPAxq5ck=
 github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
 github.com/google/martian v2.1.0+incompatible/go.mod h1:9I4somxYTbIHy5NJKHRl3wXiIaQGbYVAs8BPL6v8lEs=
@@ -486,6 +488,7 @@ github.com/google/pprof v0.0.0-20210601050228-01bbb1931b22/go.mod h1:kpwsk12EmLe
 github.com/google/pprof v0.0.0-20210609004039-a478d1d731e9/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE=
 github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1/go.mod h1:kpwsk12EmLew5upagYY7GY0pfYCcupk39gWOCRROcvE=
 github.com/google/pprof v0.0.0-20221118152302-e6195bd50e26 h1:Xim43kblpZXfIBQsbuBVKCudVG457BR2GZFIz3uw3hQ=
+github.com/google/pprof v0.0.0-20221118152302-e6195bd50e26/go.mod h1:dDKJzRmX4S37WGHujM7tX//fmj1uioxKzKxz3lo4HJo=
 github.com/google/renameio v0.1.0/go.mod h1:KWCgfxg9yswjAJkECMjeO8J8rahYeXnNhOm40UhjYkI=
 github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510/go.mod h1:pupxD2MaaD3pAXIBCelhxNneeOaAeabZDe5s4K6zSpQ=
 github.com/google/trillian v1.3.11/go.mod h1:0tPraVHrSDkA3BO6vKX67zgLXs6SsOAbHEivX+9mPgw=
@@ -738,6 +741,7 @@ github.com/mattn/go-runewidth v0.0.9/go.mod h1:H031xJmbD/WCDINGzjvQ9THkh0rPKHF+m
 github.com/mattn/go-sqlite3 v1.9.0/go.mod h1:FPy6KqzDD04eiIsT53CuJW3U88zkxoIYsOqkbpncsNc=
 github.com/mattn/go-sqlite3 v1.14.9/go.mod h1:NyWgC/yNuGj7Q9rpYnZvas74GogHl5/Z4A/KQRfk6bU=
 github.com/mattn/go-sqlite3 v1.14.16 h1:yOQRA0RpS5PFz/oikGwBEqvAWhWg5ufRz4ETLjwpU1Y=
+github.com/mattn/go-sqlite3 v1.14.16/go.mod h1:2eHXhiwb8IkHr+BDWZGa96P6+rkvnG63S2DGjv9HUNg=
 github.com/mattn/goveralls v0.0.2/go.mod h1:8d1ZMHsd7fW6IRPKQh46F2WRpyib5/X4FOpevwGNQEw=
 github.com/matttproud/golang_protobuf_extensions v1.0.1/go.mod h1:D8He9yQNgCq6Z5Ld7szi9bcBfOoFv/3dc6xSMkL2PC0=
 github.com/matttproud/golang_protobuf_extensions v1.0.4 h1:mmDVorXM7PCGKw94cs5zkfA9PSy5pEvNWRP0ET0TIVo=
@@ -1511,6 +1515,7 @@ golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
 golang.org/x/text v0.4.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
 golang.org/x/text v0.13.0 h1:ablQoSUd0tRdKxZewP80B+BaqeKJuVhuRxj/dkrun3k=
+golang.org/x/text v0.13.0/go.mod h1:TvPlkZtksWOMsz7fbANvkp4WM8x/WCo/om8BMLbz+aE=
 golang.org/x/time v0.0.0-20180412165947-fbb02b2291d2/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/time v0.0.0-20181108054448-85acf8d2951c/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
 golang.org/x/time v0.0.0-20190308202827-9d24e82272b4/go.mod h1:tRJNPiyCQ0inRvYxbN9jk5I+vvW/OXSQhTDSoE431IQ=
@@ -1835,6 +1840,7 @@ gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15/go.mod h1:Co6ibVJAznAaIkqp8
 gopkg.in/check.v1 v1.0.0-20200227125254-8fa46927fb4f/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/check.v1 v1.0.0-20200902074654-038fdea0a05b/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
+gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=
 gopkg.in/cheggaaa/pb.v1 v1.0.25/go.mod h1:V/YB90LKu/1FcN3WVnfiiE5oMCibMjukxqG/qStrOgw=
 gopkg.in/cheggaaa/pb.v1 v1.0.28/go.mod h1:V/YB90LKu/1FcN3WVnfiiE5oMCibMjukxqG/qStrOgw=
 gopkg.in/errgo.v2 v2.1.0/go.mod h1:hNsd1EY+bozCKY1Ytp96fpM3vjJbqLJn88ws8XvfDNI=
@@ -1884,7 +1890,9 @@ modernc.org/cc/v3 v3.40.0/go.mod h1:/bTg4dnWkSXowUO6ssQKnOV0yMVxDYNIsIrzqTFDGH0=
 modernc.org/ccgo/v3 v3.16.13 h1:Mkgdzl46i5F/CNR/Kj80Ri59hC8TKAhZrYSaqvkwzUw=
 modernc.org/ccgo/v3 v3.16.13/go.mod h1:2Quk+5YgpImhPjv2Qsob1DnZ/4som1lJTodubIcoUkY=
 modernc.org/ccorpus v1.11.6 h1:J16RXiiqiCgua6+ZvQot4yUuUy8zxgqbqEEUuGPlISk=
+modernc.org/ccorpus v1.11.6/go.mod h1:2gEUTrWqdpH2pXsmTM1ZkjeSrUWDpjMu2T6m29L/ErQ=
 modernc.org/httpfs v1.0.6 h1:AAgIpFZRXuYnkjftxTAZwMIiwEqAfk8aVB2/oA6nAeM=
+modernc.org/httpfs v1.0.6/go.mod h1:7dosgurJGp0sPaRanU53W4xZYKh14wfzX420oZADeHM=
 modernc.org/libc v1.24.1 h1:uvJSeCKL/AgzBo2yYIPPTy82v21KgGnizcGYfBHaNuM=
 modernc.org/libc v1.24.1/go.mod h1:FmfO1RLrU3MHJfyi9eYYmZBfi/R+tqZ6+hQ3yQQUkak=
 modernc.org/mathutil v1.5.0 h1:rV0Ko/6SfM+8G+yKiyI830l3Wuz1zRutdslNoQ0kfiQ=
@@ -1898,9 +1906,11 @@ modernc.org/sqlite v1.26.0/go.mod h1:FL3pVXie73rg3Rii6V/u5BoHlSoyeZeIgKZEgHARyCU
 modernc.org/strutil v1.1.3 h1:fNMm+oJklMGYfU9Ylcywl0CO5O6nTfaowNsh2wpPjzY=
 modernc.org/strutil v1.1.3/go.mod h1:MEHNA7PdEnEwLvspRMtWTNnp2nnyvMfkimT1NKNAGbw=
 modernc.org/tcl v1.15.2 h1:C4ybAYCGJw968e+Me18oW55kD/FexcHbqH2xak1ROSY=
+modernc.org/tcl v1.15.2/go.mod h1:3+k/ZaEbKrC8ePv8zJWPtBSW0V7Gg9g8rkmhI1Kfs3c=
 modernc.org/token v1.0.1 h1:A3qvTqOwexpfZZeyI0FeGPDlSWX5pjZu9hF4lU+EKWg=
 modernc.org/token v1.0.1/go.mod h1:UGzOrNV1mAFSEB63lOFHIpNRUVMvYTc6yu1SMY/XTDM=
 modernc.org/z v1.7.3 h1:zDJf6iHjrnB+WRD88stbXokugjyc0/pB91ri1gO6LZY=
+modernc.org/z v1.7.3/go.mod h1:Ipv4tsdxZRbQyLq9Q1M6gdbkxYzdlrciF2Hi/lS7nWE=
 mvdan.cc/gofumpt v0.3.1/go.mod h1:w3ymliuxvzVx8DAutBnVyDqYb1Niy/yCJt/lk821YCE=
 mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed/go.mod h1:Xkxe497xwlCKkIaQYRfC7CSLworTXY9RMqwhhCm+8Nc=
 mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b/go.mod h1:2odslEg/xrtNQqCYg2/jCoyKnw3vv5biOc3JnIcYfL4=

sc/memiavl/benchmark_test.go

@@ -37,7 +37,7 @@ func BenchmarkRandomGet(b *testing.B) {
 	require.NoError(b, err)
 	snapshot, err := OpenSnapshot(snapshotDir)
 	require.NoError(b, err)
-	defer snapshot.Close()
+	defer func() { _ = snapshot.Close() }()
 
 	b.Run("memiavl", func(b *testing.B) {
 		require.Equal(b, targetValue, tree.Get(targetKey))

sc/memiavl/db.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"math"
 	"os"
 	"path/filepath"
 	"runtime"
@@ -543,7 +544,7 @@ func (db *DB) reloadMultiTree(mtree *MultiTree) error {
 	if err := mtree.apply(db.pendingLogEntry); err != nil {
 		return err
 	}
-	return db.MultiTree.ReplaceWith(mtree)
+	return db.ReplaceWith(mtree)
 }
 
 // rewriteIfApplicable execute the snapshot rewrite strategy according to current height
@@ -552,12 +553,12 @@ func (db *DB) rewriteIfApplicable(height int64) {
 		return
 	}
 
-	if db.snapshotInterval <= 0 || height <= 0 || height < db.MultiTree.SnapshotVersion() {
+	if db.snapshotInterval <= 0 || height <= 0 || height < db.SnapshotVersion() {
 		return
 	}
 
 	// create snapshot when current height - last snapshot height > interval
-	if height-db.MultiTree.SnapshotVersion() >= int64(db.snapshotInterval) {
+	if height-db.SnapshotVersion() >= int64(db.snapshotInterval) {
 		if err := db.rewriteSnapshotBackground(); err != nil {
 			db.logger.Error("failed to rewrite snapshot in background", "err", err)
 		}
@@ -913,5 +914,8 @@ func GetLatestVersion(dir string) (int64, error) {
 	if err != nil {
 		return 0, err
 	}
+	if metadata.InitialVersion < 0 || metadata.InitialVersion > math.MaxUint32 {
+		return 0, fmt.Errorf("invalid initial version: %d", metadata.InitialVersion)
+	}
 	return utils.IndexToVersion(lastIndex, uint32(metadata.InitialVersion)), nil
 }

sc/memiavl/import.go

@@ -2,7 +2,6 @@ package memiavl
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"math"
 	"os"
@@ -131,8 +130,8 @@ func (ai *TreeImporter) Close() error {
 
 // doImport a stream of `types.SnapshotNode`s into a new snapshot.
 func doImport(dir string, version int64, nodes <-chan *types.SnapshotNode) (returnErr error) {
-	if version > int64(math.MaxUint32) {
-		return errors.New("version overflows uint32")
+	if version < 0 || version > int64(math.MaxUint32) {
+		return fmt.Errorf("version under/overflows uint32: %d", version)
 	}
 
 	return writeSnapshot(context.Background(), dir, uint32(version), func(w *snapshotWriter) (uint32, error) {
@@ -167,15 +166,16 @@ type importer struct {
 }
 
 func (i *importer) Add(n *types.SnapshotNode) error {
-	if n.Version > int64(math.MaxUint32) {
-		return errors.New("version overflows uint32")
+	if n.Version < 0 || n.Version > math.MaxUint32 {
+		return fmt.Errorf("node version under/overflows uint32: %d", n.Version)
 	}
+	version := uint32(n.Version)
 
 	if n.Height == 0 {
 		node := &MemNode{
 			height:  0,
 			size:    1,
-			version: uint32(n.Version),
+			version: version,
 			key:     n.Key,
 			value:   n.Value,
 		}
@@ -193,10 +193,14 @@ func (i *importer) Add(n *types.SnapshotNode) error {
 	leftNode := i.nodeStack[len(i.nodeStack)-2]
 	rightNode := i.nodeStack[len(i.nodeStack)-1]
 
+	if n.Height < 0 {
+		return fmt.Errorf("node height under/overflows uint8: %d", n.Height)
+	}
+
 	node := &MemNode{
 		height:  uint8(n.Height),
 		size:    leftNode.size + rightNode.size,
-		version: uint32(n.Version),
+		version: version,
 		key:     n.Key,
 		left:    leftNode,
 		right:   rightNode,
@@ -207,7 +211,14 @@ func (i *importer) Add(n *types.SnapshotNode) error {
 	node.left = nil
 	node.right = nil
 
-	preTrees := uint8(len(i.nodeStack) - 2)
+	pt := len(i.nodeStack) - 2
+	if pt < 0 || pt > math.MaxUint8 {
+		return fmt.Errorf("preTrees out of range: %d", pt)
+	}
+	preTrees := uint8(pt)
+	if node.size < 0 || node.size > math.MaxUint32 {
+		return fmt.Errorf("node size under/overflows uint32: %d", node.size)
+	}
 	if err := i.writeBranch(node.version, uint32(node.size), node.height, preTrees, keyLeaf, nodeHash); err != nil {
 		return err
 	}