Skip to content

Commit c439c52

Browse files
bdchathamclaude
andcommitted
design: reuse existing Google OAuth client for OAuth2 Proxy
Share the Grafana Google OAuth client rather than creating a separate one. Just add the OAuth2 Proxy callback URI to the existing client. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 0dc9adc commit c439c52

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

.tide/designs/platform-oauth2-ext-authz.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,15 @@ Cookie domain `.prod.platform.sei.io` means one login covers all protected tools
4747

4848
## Design Decisions
4949

50-
### Separate Google OAuth Client
50+
### Shared Google OAuth Client
5151

52-
A new Google OAuth client is required (not reusing Grafana's). Google Cloud Console ties redirect URIs to specific clients. Mixing OAuth2 Proxy callbacks with Grafana's `/login/generic_oauth` in one client is fragile — URI rotation on one side risks breaking the other.
52+
OAuth2 Proxy reuses the existing Google OAuth client that Grafana already uses. Add the OAuth2 Proxy callback URI to the existing client's authorized redirect URIs in Google Cloud Console:
5353

54-
**Google Cloud Console config:**
55-
- Application type: Web application
56-
- Name: `sei-platform-oauth2-proxy-prod`
57-
- Authorized redirect URI: `https://oauth2-proxy.prod.platform.sei.io/oauth2/callback`
54+
```
55+
https://oauth2-proxy.prod.platform.sei.io/oauth2/callback
56+
```
57+
58+
This avoids managing a second set of credentials. The OAuth2 Proxy deployment references the same `google-oauth` secret (client ID and client secret) plus its own `cookie-secret`.
5859

5960
### Dedicated `auth` Namespace
6061

0 commit comments

Comments
 (0)