refactor: use --halt-height instead of await-condition for pre-init

The bootstrap seid now receives --halt-height so it stops itself
after committing the target block and exits 0. This removes the
need for the sidecar to kill seid externally and eliminates the
race where the controller tries to poll a dead sidecar after the
Job completes.

Changes:
- preInitWaitCommand passes --halt-height to seid and uses exec
- buildPreInitPlan no longer appends await-condition task
- Tests updated accordingly

Author: bdchatham

internal/controller/node/job.go

@@ -77,19 +77,13 @@ func preInitSidecarURL(node *seiv1alpha1.SeiNode) string {
 }
 
 // preInitWaitCommand returns a shell command that waits for the sidecar
-// healthz to return 200 and then runs "seid start --home /sei".
-// Unlike sidecarWaitCommand, it does NOT use the node's custom entrypoint
-// because the pre-init Job runs the bootstrap image which may not support
-// custom flags (e.g. --skip-app-hash-validation).
+// healthz to return 200 and then exec's seid with --halt-height.
 //
-// seid is run as a child process (not exec'd) so the shell can exit 0
-// regardless of how seid terminates. The sidecar's await-condition task
-// sends SIGTERM directly to the seid process when the target height is
-// reached; the trailing "exit 0" ensures the shell reports success even
-// though seid exits with code 143 (SIGTERM). The trap handles the case
-// where Kubernetes sends SIGTERM to the shell (PID 1) during pod
-// termination.
-func preInitWaitCommand(port int32) (command []string, args []string) {
+// The bootstrap image's seid uses the Cosmos SDK halt-height mechanism:
+// after committing the block at haltHeight, seid sends itself SIGINT and
+// exits 0. This avoids the need for the sidecar to kill seid externally
+// and keeps the Job exit code clean without wrapper tricks.
+func preInitWaitCommand(port int32, haltHeight int64) (command []string, args []string) {
 	script := fmt.Sprintf(
 		`echo "waiting for sidecar to become ready..."; `+
 			`while true; do `+
@@ -98,10 +92,9 @@ func preInitWaitCommand(port int32) (command []string, args []string) {
 			`head -1 <&3 | grep -q "200" && break; `+
 			`exec 3>&-; sleep 5; done; `+
 			`exec 3>&-; `+
-			`echo "sidecar ready, starting seid"; `+
-			`trap 'exit 0' TERM; `+
-			`seid start --home %s & wait $!; exit 0`,
-		port, dataDir,
+			`echo "sidecar ready, starting seid with halt-height %d"; `+
+			`exec seid start --home %s --halt-height %d`,
+		port, haltHeight, dataDir, haltHeight,
 	)
 	return []string{"/bin/bash", "-c"}, []string{script}
 }
@@ -145,7 +138,8 @@ func buildPreInitPodSpec(node *seiv1alpha1.SeiNode, snap *seiv1alpha1.SnapshotSo
 		bootstrapImage = snap.BootstrapImage
 	}
 
-	seidCmd, seidArgs := preInitWaitCommand(sidecarPort(node))
+	haltHeight := snap.S3.TargetHeight
+	seidCmd, seidArgs := preInitWaitCommand(sidecarPort(node), haltHeight)
 	seidContainer := corev1.Container{
 		Name:    "seid",
 		Image:   bootstrapImage,

internal/controller/node/plan_execution_test.go

@@ -1268,17 +1268,19 @@ func TestReconcileInitializing_PlanFailed_TransitionsToFailed(t *testing.T) {
 
 // --- PreInitPlan builder tests ---
 
-func TestBuildPreInitPlan_AppendsAwaitCondition(t *testing.T) {
+func TestBuildPreInitPlan_DoesNotIncludeAwaitCondition(t *testing.T) {
 	node := bootstrapReplayerNode()
 	planner, _ := PlannerForNode(node, testSnapshotRegion)
 	plan := buildPreInitPlan(node, planner)
 
-	lastTask := plan.Tasks[len(plan.Tasks)-1]
-	if lastTask.Type != taskAwaitCondition {
-		t.Errorf("last task type = %q, want %q", lastTask.Type, taskAwaitCondition)
+	for _, task := range plan.Tasks {
+		if task.Type == taskAwaitCondition {
+			t.Errorf("pre-init plan should not contain await-condition (halt-height is used instead)")
+		}
 	}
-	if lastTask.Status != seiv1alpha1.PlannedTaskPending {
-		t.Errorf("last task status = %q, want Pending", lastTask.Status)
+	lastTask := plan.Tasks[len(plan.Tasks)-1]
+	if lastTask.Type != taskMarkReady {
+		t.Errorf("last task type = %q, want %q", lastTask.Type, taskMarkReady)
 	}
 }
 

internal/controller/node/planner_bootstrap.go

@@ -12,19 +12,15 @@ const taskAwaitCondition = sidecar.TaskTypeAwaitCondition
 
 // buildPreInitPlan constructs the task plan for the PreInit Job. For nodes
 // that require bootstrap infrastructure (e.g. S3 snapshot with a bootstrap
-// image), it builds the standard bootstrap sequence and appends an
-// await-condition task. For all other nodes it returns an empty plan that
-// resolves trivially.
+// image), it builds the standard bootstrap sequence. The seid process
+// handles the halt-height natively (via --halt-height), so no
+// await-condition task is needed. For all other nodes it returns an empty
+// plan that resolves trivially.
 func buildPreInitPlan(node *seiv1alpha1.SeiNode, planner NodePlanner) *seiv1alpha1.TaskPlan {
 	if !needsPreInit(node) {
 		return &seiv1alpha1.TaskPlan{Phase: seiv1alpha1.TaskPlanActive, Tasks: []seiv1alpha1.PlannedTask{}}
 	}
-	plan := planner.BuildPlan(node)
-	plan.Tasks = append(plan.Tasks, seiv1alpha1.PlannedTask{
-		Type:   taskAwaitCondition,
-		Status: seiv1alpha1.PlannedTaskPending,
-	})
-	return plan
+	return planner.BuildPlan(node)
 }
 
 // buildPostBootstrapInitPlan constructs a reduced InitPlan for nodes that