fix: advance pre-init plan when Job completes successfully

When the pre-init Job finishes, the sidecar container is already
terminated and unreachable. Instead of polling a dead sidecar
indefinitely, check the Job status directly: Complete means all
tasks succeeded (the sidecar only kills seid after await-condition
passes), Failed means something went wrong.

Author: bdchatham

internal/controller/node/pre_init.go

@@ -67,6 +67,21 @@ func (r *SeiNodeReconciler) reconcilePreInitializing(ctx context.Context, node *
 		return ctrl.Result{RequeueAfter: immediateRequeue}, nil
 	}
 
+	if isJobComplete(job) {
+		log.FromContext(ctx).Info("pre-init job completed, advancing plan", "job", job.Name)
+		patch := client.MergeFrom(node.DeepCopy())
+		for i := range plan.Tasks {
+			if plan.Tasks[i].Status != seiv1alpha1.PlannedTaskComplete {
+				plan.Tasks[i].Status = seiv1alpha1.PlannedTaskComplete
+			}
+		}
+		plan.Phase = seiv1alpha1.TaskPlanComplete
+		if err := r.Status().Patch(ctx, node, patch); err != nil {
+			return ctrl.Result{}, fmt.Errorf("marking pre-init plan complete after job success: %w", err)
+		}
+		return ctrl.Result{RequeueAfter: immediateRequeue}, nil
+	}
+
 	sc := r.buildJobSidecarClient(node)
 	if sc == nil {
 		log.FromContext(ctx).Info("pre-init job sidecar not reachable yet, will retry")
@@ -158,6 +173,16 @@ func isJobFailed(job *batchv1.Job) bool {
 	return false
 }
 
+// isJobComplete returns true if the Job has a Complete condition.
+func isJobComplete(job *batchv1.Job) bool {
+	for _, c := range job.Status.Conditions {
+		if c.Type == batchv1.JobComplete && c.Status == corev1.ConditionTrue {
+			return true
+		}
+	}
+	return false
+}
+
 // jobFailureReason extracts a human-readable failure reason from the Job's conditions.
 func jobFailureReason(job *batchv1.Job) string {
 	for _, c := range job.Status.Conditions {