fix: only gate on external address for LoadBalancer services

bdchatham · claude · bdchatham · commit f7bd3a0dba42 · 2026-04-08T15:38:48.000-07:00
ClusterIP services don't produce LoadBalancer ingress, so the gate
would block forever. Only gate when the service type is LoadBalancer.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/internal/controller/nodedeployment/networking.go b/internal/controller/nodedeployment/networking.go
@@ -39,9 +39,12 @@ type effectiveRoute struct {
 	Port      int32
 }
 
-// hasExternalService returns true when the deployment has an external Service configured.
+// hasExternalService returns true when the deployment has a LoadBalancer
+// Service that will produce an external address to gate on.
 func (r *SeiNodeDeploymentReconciler) hasExternalService(group *seiv1alpha1.SeiNodeDeployment) bool {
-	return group.Spec.Networking != nil && group.Spec.Networking.Service != nil
+	return group.Spec.Networking != nil &&
+		group.Spec.Networking.Service != nil &&
+		group.Spec.Networking.Service.Type == corev1.ServiceTypeLoadBalancer
 }
 
 func (r *SeiNodeDeploymentReconciler) reconcileNetworking(ctx context.Context, group *seiv1alpha1.SeiNodeDeployment) error {

Original file line number	Diff line number	Diff line change
`@@ -39,9 +39,12 @@ type effectiveRoute struct {`
`39`	`39`	`Port int32`
`40`	`40`	`}`
`41`	`41`
`42`		`-// hasExternalService returns true when the deployment has an external Service configured.`
	`42`	`+// hasExternalService returns true when the deployment has a LoadBalancer`
	`43`	`+// Service that will produce an external address to gate on.`
`43`	`44`	`func (r SeiNodeDeploymentReconciler) hasExternalService(group seiv1alpha1.SeiNodeDeployment) bool {`
`44`		`- return group.Spec.Networking != nil && group.Spec.Networking.Service != nil`
	`45`	`+ return group.Spec.Networking != nil &&`
	`46`	`+ group.Spec.Networking.Service != nil &&`
	`47`	`+ group.Spec.Networking.Service.Type == corev1.ServiceTypeLoadBalancer`
`45`	`48`	`}`
`46`	`49`
`47`	`50`	`func (r SeiNodeDeploymentReconciler) reconcileNetworking(ctx context.Context, group seiv1alpha1.SeiNodeDeployment) error {`