refactor: simplify genesis resolution and clean up sidecar task handlers (#49)

## Summary
- **Genesis simplification**: All genesis/ceremony task handlers now
derive S3 coordinates from environment variables (`SEI_GENESIS_BUCKET`,
`SEI_GENESIS_REGION`, `SEI_CHAIN_ID`) instead of receiving them as task
params. Genesis resolution: embedded sei-config first, S3 fallback at
`{bucket}/{chainID}/genesis.json`.
- **Bump sei-config to v0.0.9**: Corrected embedded genesis files for
pacific-1, atlantic-2, arctic-1
- **Remove dead code**: `CommandRunner` type, `parseUploadConfig`, stale
S3 fields from client task types
- **Fix `readLocalNodeID`**: Now derives node ID from Ed25519 key
(matching CometBFT's `p2p.PubKeyToID`), instead of assuming a top-level
`"id"` field in `node_key.json`
- **Consistency fixes**: ConfigPatcher rejects empty files,
`SEI_SNAPSHOT_UPLOAD_INTERVAL` fails fast on invalid value, stale doc
comments cleaned up
- **Env var validation**: `serve.go` validates `SEI_CHAIN_ID`,
`SEI_GENESIS_BUCKET`, `SEI_GENESIS_REGION` at startup

## Deployment notes
- Requires sei-k8s-controller to inject `SEI_GENESIS_BUCKET` and
`SEI_GENESIS_REGION` into sidecar pod specs (see
sei-protocol/sei-k8s-controller `refactor/genesis-env-driven` branch)
- Controller must deploy before this sidecar — new sidecar requires env
vars that the new controller injects

## Test plan
- [x] `go test ./sidecar/...` — all pass (pre-existing
`TestExportS3UploaderFactoryError` unrelated)
- [x] Genesis embedded path tested (pacific-1, atlantic-2)
- [x] Genesis S3 fallback tested (unknown chain)
- [x] Ceremony tasks tested (upload artifacts, assemble genesis, set
peers)
- [x] TypedHandler deserialization integration tests pass for all 17
task types
- [ ] Deploy controller with env var injection, then deploy new sidecar
image
- [ ] Verify genesis ceremony end-to-end on dev cluster

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: bdchatham

go.mod

@@ -14,7 +14,7 @@ require (
 	github.com/oapi-codegen/runtime v1.2.0
 	github.com/pelletier/go-toml/v2 v2.2.4
 	github.com/sei-protocol/sei-chain v0.0.29-fix.0.20260326202429-c9b42951fef7
-	github.com/sei-protocol/sei-config v0.0.9-0.20260327015454-7cf35ff77daa
+	github.com/sei-protocol/sei-config v0.0.9
 	github.com/sei-protocol/seilog v0.0.3
 	github.com/urfave/cli/v3 v3.6.1
 	modernc.org/sqlite v1.18.1

go.sum

@@ -1820,8 +1820,8 @@ github.com/sei-protocol/goutils v0.0.2 h1:Bfa7Sv+4CVLNM20QcpvGb81B8C5HkQC/kW1CQp
 github.com/sei-protocol/goutils v0.0.2/go.mod h1:iYE2DuJfEnM+APPehr2gOUXfuLuPsVxorcDO+Tzq9q8=
 github.com/sei-protocol/sei-chain v0.0.29-fix.0.20260326202429-c9b42951fef7 h1:kW+yxMoSm4RvpP5VT5lFfSa+dqnOE9ZpapE2qNIJwvc=
 github.com/sei-protocol/sei-chain v0.0.29-fix.0.20260326202429-c9b42951fef7/go.mod h1:R1/EoOY+MKvwH0k5ivTtG9mLYOQvm0Ni/Trjxrep3t4=
-github.com/sei-protocol/sei-config v0.0.9-0.20260327015454-7cf35ff77daa h1:bi0qHl2E8TxpOpBZZJmMl7eZc04sMJe5E11nC+uF7IM=
-github.com/sei-protocol/sei-config v0.0.9-0.20260327015454-7cf35ff77daa/go.mod h1:IEAv5ynYw8Gu2F2qNfE4MQR0PPihAT6g7RWLpWdw5O0=
+github.com/sei-protocol/sei-config v0.0.9 h1:ELCpE0XnsTvgjOfWe1fWU43vqqFGL2tnlWuF9U1A2l8=
+github.com/sei-protocol/sei-config v0.0.9/go.mod h1:IEAv5ynYw8Gu2F2qNfE4MQR0PPihAT6g7RWLpWdw5O0=
 github.com/sei-protocol/sei-load v0.0.0-20251007135253-78fbdc141082 h1:f2sY8OcN60UL1/6POx+HDMZ4w04FTZtSScnrFSnGZHg=
 github.com/sei-protocol/sei-load v0.0.0-20251007135253-78fbdc141082/go.mod h1:V0fNURAjS6A8+sA1VllegjNeSobay3oRUW5VFZd04bA=
 github.com/sei-protocol/sei-tm-db v0.0.5 h1:3WONKdSXEqdZZeLuWYfK5hP37TJpfaUa13vAyAlvaQY=

serve.go

@@ -40,12 +40,26 @@ var serveCmd = cli.Command{
 		}
 		port := cmd.String("port")
 		chainID := os.Getenv("SEI_CHAIN_ID")
+		genesisBucket := os.Getenv("SEI_GENESIS_BUCKET")
+		genesisRegion := os.Getenv("SEI_GENESIS_REGION")
+
+		for _, kv := range []struct{ name, val string }{
+			{"SEI_CHAIN_ID", chainID},
+			{"SEI_GENESIS_BUCKET", genesisBucket},
+			{"SEI_GENESIS_REGION", genesisRegion},
+		} {
+			if kv.val == "" {
+				return fmt.Errorf("required environment variable %s is not set", kv.name)
+			}
+		}
 
 		var snapshotUploadInterval time.Duration
 		if raw := os.Getenv("SEI_SNAPSHOT_UPLOAD_INTERVAL"); raw != "" {
-			if parsed, err := time.ParseDuration(raw); err == nil {
-				snapshotUploadInterval = parsed
+			parsed, err := time.ParseDuration(raw)
+			if err != nil {
+				return fmt.Errorf("invalid SEI_SNAPSHOT_UPLOAD_INTERVAL %q: %w", raw, err)
 			}
+			snapshotUploadInterval = parsed
 		}
 
 		if err := tasks.EnsureDefaultConfig(homeDir); err != nil {
@@ -65,16 +79,16 @@ var serveCmd = cli.Command{
 			engine.TaskConfigValidate:           tasks.NewConfigValidator(homeDir).Handler(),
 			engine.TaskConfigReload:             tasks.NewConfigReloader(homeDir).Handler(),
 			engine.TaskMarkReady:                tasks.MarkReadyHandler(),
-			engine.TaskConfigureGenesis:         tasks.NewGenesisFetcher(homeDir, chainID, nil).Handler(),
+			engine.TaskConfigureGenesis:         tasks.NewGenesisFetcher(homeDir, chainID, genesisBucket, genesisRegion, nil).Handler(),
 			engine.TaskConfigureStateSync:       tasks.NewStateSyncConfigurer(homeDir, nil).Handler(),
 			engine.TaskSnapshotUpload:           tasks.NewSnapshotUploader(homeDir, snapshotUploadInterval, nil).Handler(),
 			engine.TaskResultExport:             tasks.NewResultExporter(homeDir, nil).Handler(),
 			engine.TaskAwaitCondition:           tasks.NewConditionWaiter(nil).Handler(),
-			engine.TaskGenerateIdentity:         tasks.NewIdentityGenerator(homeDir, nil).Handler(),
-			engine.TaskGenerateGentx:            tasks.NewGentxGenerator(homeDir, nil).Handler(),
-			engine.TaskUploadGenesisArtifacts:   tasks.NewGenesisArtifactUploader(homeDir, nil).Handler(),
-			engine.TaskAssembleAndUploadGenesis: tasks.NewGenesisAssembler(homeDir, nil, nil, nil).Handler(),
-			engine.TaskSetGenesisPeers:          tasks.NewGenesisPeersSetter(homeDir, nil).Handler(),
+			engine.TaskGenerateIdentity:         tasks.NewIdentityGenerator(homeDir).Handler(),
+			engine.TaskGenerateGentx:            tasks.NewGentxGenerator(homeDir).Handler(),
+			engine.TaskUploadGenesisArtifacts:   tasks.NewGenesisArtifactUploader(homeDir, genesisBucket, genesisRegion, chainID, nil).Handler(),
+			engine.TaskAssembleAndUploadGenesis: tasks.NewGenesisAssembler(homeDir, genesisBucket, genesisRegion, chainID, nil, nil).Handler(),
+			engine.TaskSetGenesisPeers:          tasks.NewGenesisPeersSetter(homeDir, genesisBucket, genesisRegion, chainID, nil).Handler(),
 		}
 
 		eng := engine.NewEngine(ctx, handlers, store)

sidecar/client/client.go

@@ -132,7 +132,7 @@ func (c *SidecarClient) SubmitTask(ctx context.Context, task TaskRequest) (uuid.
 	}
 }
 
-// ListTasks returns recent task results and active scheduled tasks.
+// ListTasks returns recent task results.
 func (c *SidecarClient) ListTasks(ctx context.Context) ([]TaskResult, error) {
 	resp, err := c.inner.ListTasksWithResponse(ctx)
 	if err != nil {

sidecar/client/tasks.go

@@ -2,7 +2,6 @@ package client
 
 import (
 	"fmt"
-	"net/url"
 
 	"github.com/google/uuid"
 	seiconfig "github.com/sei-protocol/sei-config"
@@ -156,61 +155,28 @@ func SnapshotUploadTaskFromParams(params map[string]interface{}) SnapshotUploadT
 	}
 }
 
-// ConfigureGenesisTask configures genesis.json for a node. When URI and Region
-// are set, the sidecar downloads from S3. When they are empty, the sidecar
-// falls back to writing the embedded genesis for the chain ID it was started
-// with (set via SEI_CHAIN_ID environment variable).
+// ConfigureGenesisTask instructs the sidecar to resolve and write genesis.json.
+// The sidecar resolves genesis from its chain ID: embedded config is checked
+// first, then S3 fallback at {bucket}/{chainID}/genesis.json using env vars.
+// No parameters are needed from the controller.
 type ConfigureGenesisTask struct {
 	TaskMeta
-	URI    string
-	Region string
 }
 
 func (t ConfigureGenesisTask) TaskType() string { return TaskTypeConfigureGenesis }
 
-func (t ConfigureGenesisTask) Validate() error {
-	if t.URI == "" {
-		return nil
-	}
-	if t.Region == "" {
-		return fmt.Errorf("configure-genesis: Region is required when URI is set")
-	}
-	parsed, err := url.Parse(t.URI)
-	if err != nil {
-		return fmt.Errorf("configure-genesis: invalid URI %q: %w", t.URI, err)
-	}
-	if parsed.Scheme != "s3" {
-		return fmt.Errorf("configure-genesis: URI must use s3:// scheme, got %q", parsed.Scheme)
-	}
-	if parsed.Host == "" || parsed.Path == "" || parsed.Path == "/" {
-		return fmt.Errorf("configure-genesis: URI must be s3://bucket/key, got %q", t.URI)
-	}
-	return nil
-}
+func (t ConfigureGenesisTask) Validate() error { return nil }
 
 func (t ConfigureGenesisTask) ToTaskRequest() TaskRequest {
-	var req TaskRequest
-	if t.URI == "" {
-		req = TaskRequest{Type: t.TaskType()}
-	} else {
-		p := map[string]interface{}{
-			"uri":    t.URI,
-			"region": t.Region,
-		}
-		req = TaskRequest{Type: t.TaskType(), Params: &p}
-	}
+	req := TaskRequest{Type: t.TaskType()}
 	t.applyMeta(&req)
 	return req
 }
 
 // ConfigureGenesisTaskFromParams reconstructs a ConfigureGenesisTask from
 // a generic params map.
-func ConfigureGenesisTaskFromParams(params map[string]interface{}) ConfigureGenesisTask {
-	s := func(k string) string { v, _ := params[k].(string); return v }
-	return ConfigureGenesisTask{
-		URI:    s("uri"),
-		Region: s("region"),
-	}
+func ConfigureGenesisTaskFromParams(_ map[string]interface{}) ConfigureGenesisTask {
+	return ConfigureGenesisTask{}
 }
 
 // PeerSourceType identifies the peer discovery mechanism.
@@ -645,23 +611,15 @@ func (t GenerateGentxTask) ToTaskRequest() TaskRequest {
 }
 
 // UploadGenesisArtifactsTask uploads identity.json and gentx.json to S3.
+// S3 coordinates are derived by the sidecar from its environment.
 type UploadGenesisArtifactsTask struct {
 	TaskMeta
-	S3Bucket string
-	S3Prefix string
-	S3Region string
 	NodeName string
 }
 
 func (t UploadGenesisArtifactsTask) TaskType() string { return TaskTypeUploadGenesisArtifacts }
 
 func (t UploadGenesisArtifactsTask) Validate() error {
-	if t.S3Bucket == "" {
-		return fmt.Errorf("upload-genesis-artifacts: missing required field S3Bucket")
-	}
-	if t.S3Region == "" {
-		return fmt.Errorf("upload-genesis-artifacts: missing required field S3Region")
-	}
 	if t.NodeName == "" {
 		return fmt.Errorf("upload-genesis-artifacts: missing required field NodeName")
 	}
@@ -670,9 +628,6 @@ func (t UploadGenesisArtifactsTask) Validate() error {
 
 func (t UploadGenesisArtifactsTask) ToTaskRequest() TaskRequest {
 	p := map[string]interface{}{
-		"s3Bucket": t.S3Bucket,
-		"s3Prefix": t.S3Prefix,
-		"s3Region": t.S3Region,
 		"nodeName": t.NodeName,
 	}
 	req := TaskRequest{Type: t.TaskType(), Params: &p}
@@ -686,26 +641,22 @@ type GenesisNodeParam struct {
 }
 
 // AssembleAndUploadGenesisTask collects per-node artifacts and produces final genesis.json.
+// S3 coordinates are derived by the sidecar from its environment.
 type AssembleAndUploadGenesisTask struct {
 	TaskMeta
-	S3Bucket string
-	S3Prefix string
-	S3Region string
-	ChainID  string
-	Nodes    []GenesisNodeParam
+	AccountBalance string
+	Namespace      string
+	Nodes          []GenesisNodeParam
 }
 
 func (t AssembleAndUploadGenesisTask) TaskType() string { return TaskTypeAssembleGenesis }
 
 func (t AssembleAndUploadGenesisTask) Validate() error {
-	if t.S3Bucket == "" {
-		return fmt.Errorf("assemble-and-upload-genesis: missing required field S3Bucket")
-	}
-	if t.S3Region == "" {
-		return fmt.Errorf("assemble-and-upload-genesis: missing required field S3Region")
+	if t.AccountBalance == "" {
+		return fmt.Errorf("assemble-and-upload-genesis: missing required field AccountBalance")
 	}
-	if t.ChainID == "" {
-		return fmt.Errorf("assemble-and-upload-genesis: missing required field ChainID")
+	if t.Namespace == "" {
+		return fmt.Errorf("assemble-and-upload-genesis: missing required field Namespace")
 	}
 	if len(t.Nodes) == 0 {
 		return fmt.Errorf("assemble-and-upload-genesis: at least one node is required")
@@ -719,11 +670,9 @@ func (t AssembleAndUploadGenesisTask) ToTaskRequest() TaskRequest {
 		nodes[i] = map[string]interface{}{"name": n.Name}
 	}
 	p := map[string]interface{}{
-		"s3Bucket": t.S3Bucket,
-		"s3Prefix": t.S3Prefix,
-		"s3Region": t.S3Region,
-		"chainId":  t.ChainID,
-		"nodes":    nodes,
+		"accountBalance": t.AccountBalance,
+		"namespace":      t.Namespace,
+		"nodes":          nodes,
 	}
 	req := TaskRequest{Type: t.TaskType(), Params: &p}
 	t.applyMeta(&req)

sidecar/client/tasks_test.go

@@ -44,16 +44,7 @@ func genSnapshotUploadTask() gopter.Gen {
 }
 
 func genConfigureGenesisTask() gopter.Gen {
-	return gopter.CombineGens(
-		genNonEmptyString(),
-		genNonEmptyString(),
-		genNonEmptyString(),
-	).Map(func(v []interface{}) ConfigureGenesisTask {
-		return ConfigureGenesisTask{
-			URI:    "s3://" + v[0].(string) + "/" + v[1].(string),
-			Region: v[2].(string),
-		}
-	})
+	return gen.Const(ConfigureGenesisTask{})
 }
 
 func genEC2TagsSource() gopter.Gen {
@@ -154,37 +145,19 @@ func TestSnapshotUploadRoundTrip(t *testing.T) {
 
 func TestConfigureGenesisRoundTrip_S3(t *testing.T) {
 	properties := gopter.NewProperties(gopter.DefaultTestParameters())
-	properties.Property("ConfigureGenesisTask (S3) round-trips through TaskRequest", prop.ForAll(
+	properties.Property("ConfigureGenesisTask round-trips through TaskRequest", prop.ForAll(
 		func(task ConfigureGenesisTask) bool {
 			if err := task.Validate(); err != nil {
 				return false
 			}
 			req := task.ToTaskRequest()
-			if req.Type != TaskTypeConfigureGenesis {
-				return false
-			}
-			rebuilt := ConfigureGenesisTaskFromParams(*req.Params)
-			return rebuilt.URI == task.URI && rebuilt.Region == task.Region
+			return req.Type == TaskTypeConfigureGenesis && req.Params == nil
 		},
 		genConfigureGenesisTask(),
 	))
 	properties.TestingRun(t)
 }
 
-func TestConfigureGenesisRoundTrip_Empty(t *testing.T) {
-	task := ConfigureGenesisTask{}
-	if err := task.Validate(); err != nil {
-		t.Fatalf("Validate: %v", err)
-	}
-	req := task.ToTaskRequest()
-	if req.Type != TaskTypeConfigureGenesis {
-		t.Errorf("Type = %q, want %q", req.Type, TaskTypeConfigureGenesis)
-	}
-	if req.Params != nil {
-		t.Errorf("expected nil Params for empty genesis task, got %v", req.Params)
-	}
-}
-
 func TestDiscoverPeersRoundTrip(t *testing.T) {
 	properties := gopter.NewProperties(gopter.DefaultTestParameters())
 	properties.Property("DiscoverPeersTask round-trips through TaskRequest", prop.ForAll(
@@ -342,28 +315,9 @@ func TestSnapshotUploadValidation(t *testing.T) {
 }
 
 func TestConfigureGenesisValidation(t *testing.T) {
-	cases := []struct {
-		name string
-		task ConfigureGenesisTask
-		ok   bool
-	}{
-		{"valid s3", ConfigureGenesisTask{URI: "s3://bucket/key", Region: "us-east-1"}, true},
-		{"empty (uses embedded)", ConfigureGenesisTask{}, true},
-		{"uri without region", ConfigureGenesisTask{URI: "s3://bucket/key"}, false},
-		{"wrong scheme", ConfigureGenesisTask{URI: "https://bucket/key", Region: "us-east-1"}, false},
-		{"no key", ConfigureGenesisTask{URI: "s3://bucket", Region: "us-east-1"}, false},
-		{"no key trailing slash", ConfigureGenesisTask{URI: "s3://bucket/", Region: "us-east-1"}, false},
-	}
-	for _, tc := range cases {
-		t.Run(tc.name, func(t *testing.T) {
-			err := tc.task.Validate()
-			if tc.ok && err != nil {
-				t.Errorf("expected no error, got %v", err)
-			}
-			if !tc.ok && err == nil {
-				t.Error("expected validation error, got nil")
-			}
-		})
+	task := ConfigureGenesisTask{}
+	if err := task.Validate(); err != nil {
+		t.Errorf("expected no error, got %v", err)
 	}
 }