fix last ruff errors

Author: sabadroiback

.pre-commit-config.yaml

@@ -19,11 +19,11 @@ repos:
       - id: name-tests-test
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.6.9
+    rev: v0.14.11
     hooks:
-      - id: ruff
-        args: [--fix, --exit-non-zero-on-fix]
       - id: ruff-format
+      - id: ruff-check
+        args: [--fix, --exit-non-zero-on-fix]
 
   - repo: https://github.com/lk16/detect-missing-init
     rev: v0.1.6
@@ -32,18 +32,18 @@ repos:
         args: ["--create", "--python-folders", "amazon_paapi"]
 
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: 'v1.11.2'
+    rev: 'v1.19.1'
     hooks:
       - id: mypy
         exclude: sdk/
 
   - repo: local
     hooks:
-      - id: mypy
-        name: Checking types with mypy
-        language: system
-        entry: "python -m mypy amazon_paapi"
-        pass_filenames: false
+      # - id: mypy
+      #   name: Checking types with mypy
+      #   language: system
+      #   entry: "python -m mypy amazon_paapi"
+      #   pass_filenames: false
 
       - id: test
         name: Running tests

amazon_paapi/__init__.py

@@ -1,6 +1,7 @@
 """Amazon Product Advertising API wrapper for Python."""
 
 __author__ = "Sergio Abad"
+__all__ = ["AmazonApi", "get_asin"]
 
 from .api import AmazonApi
 from .tools import get_asin

amazon_paapi/api.py

@@ -43,7 +43,6 @@ def __init__(
         tag: str,
         country: CountryCode,
         throttling: float = 1,
-        **kwargs: Any,
     ) -> None:
         """Initialize the Amazon API client with the provided credentials."""
         self._key = key

amazon_paapi/helpers/arguments.py

@@ -7,6 +7,8 @@
 from amazon_paapi.errors import InvalidArgument
 from amazon_paapi.tools import get_asin
 
+MAX_PAGINATION_VALUE = 10
+
 
 def get_items_ids(items: str | list[str]) -> list[str]:
     """Parse and extract ASINs from items input.
@@ -64,7 +66,9 @@ def check_search_pagination_args(**kwargs: Any) -> None:
     pagination_args = [kwargs.get("item_count"), kwargs.get("item_page")]
 
     for arg in pagination_args:
-        if arg is not None and (not isinstance(arg, int) or not 1 <= arg <= 10):
+        if arg is not None and (
+            not isinstance(arg, int) or not 1 <= arg <= MAX_PAGINATION_VALUE
+        ):
             raise InvalidArgument(error_message)
 
 
@@ -76,7 +80,9 @@ def check_variations_args(**kwargs: Any) -> None:
     variation_args = [kwargs.get("variation_count"), kwargs.get("variation_page")]
 
     for arg in variation_args:
-        if arg is not None and (not isinstance(arg, int) or not 1 <= arg <= 10):
+        if arg is not None and (
+            not isinstance(arg, int) or not 1 <= arg <= MAX_PAGINATION_VALUE
+        ):
             raise InvalidArgument(error_message)
 
 

amazon_paapi/helpers/requests.py

@@ -13,10 +13,6 @@
     RequestError,
     TooManyRequests,
 )
-from amazon_paapi.models.browse_nodes_result import BrowseNode
-from amazon_paapi.models.item_result import Item
-from amazon_paapi.models.search_result import SearchResult
-from amazon_paapi.models.variations_result import VariationsResult
 from amazon_paapi.sdk.models.get_browse_nodes_request import GetBrowseNodesRequest
 from amazon_paapi.sdk.models.get_browse_nodes_resource import GetBrowseNodesResource
 from amazon_paapi.sdk.models.get_items_request import GetItemsRequest
@@ -29,8 +25,14 @@
 from amazon_paapi.sdk.rest import ApiException
 from amazon_paapi.sdk.rest import ApiException as ApiExceptionType
 
+HTTP_TOO_MANY_REQUESTS = 429
+
 if TYPE_CHECKING:
     from amazon_paapi.api import AmazonApi
+    from amazon_paapi.models.browse_nodes_result import BrowseNode
+    from amazon_paapi.models.item_result import Item
+    from amazon_paapi.models.search_result import SearchResult
+    from amazon_paapi.models.variations_result import VariationsResult
 
 
 def get_items_request(
@@ -64,7 +66,7 @@ def get_items_response(amazon_api: AmazonApi, request: GetItemsRequest) -> list[
         msg = "No items have been found"
         raise ItemsNotFound(msg)
 
-    return cast(List[Item], response.items_result.items)
+    return cast("List[Item]", response.items_result.items)
 
 
 def get_search_items_request(
@@ -98,7 +100,7 @@ def get_search_items_response(
         msg = "No items have been found"
         raise ItemsNotFound(msg)
 
-    return cast(SearchResult, response.search_result)
+    return cast("SearchResult", response.search_result)
 
 
 def get_variations_request(
@@ -132,7 +134,7 @@ def get_variations_response(
         msg = "No variation items have been found"
         raise ItemsNotFound(msg)
 
-    return cast(VariationsResult, response.variations_result)
+    return cast("VariationsResult", response.variations_result)
 
 
 def get_browse_nodes_request(
@@ -166,7 +168,7 @@ def get_browse_nodes_response(
         msg = "No browse nodes have been found"
         raise ItemsNotFound(msg)
 
-    return cast(List[BrowseNode], response.browse_nodes_result.browse_nodes)
+    return cast("List[BrowseNode]", response.browse_nodes_result.browse_nodes)
 
 
 def _get_request_resources(resource_class: type[object]) -> list[str]:
@@ -180,7 +182,7 @@ def _manage_response_exceptions(error: ApiExceptionType) -> NoReturn:
     error_status = getattr(error, "status", None)
     error_body = getattr(error, "body", "") or ""
 
-    if error_status == 429:
+    if error_status == HTTP_TOO_MANY_REQUESTS:
         msg = (
             "Requests limit reached, try increasing throttling or wait before"
             " trying again"

amazon_paapi/tools/__init__.py

@@ -1,3 +1,5 @@
 """Tools for extracting information from Amazon URLs and ASINs."""
 
+__all__ = ["get_asin"]
+
 from .asin import get_asin

pyproject.toml

@@ -14,6 +14,9 @@ ignore = [
     "D213",
     "COM812",
     "ISC001",
+    "FBT001",
+    "FBT002",
+    "N818",   # TODO: Exception name should be named with an Error suffix
 ]
 exclude = ["amazon_paapi/sdk/*", "docs/*"]
 
@@ -30,6 +33,7 @@ exclude = ["amazon_paapi/sdk/*", "docs/*"]
     "PT027",
     "SLF001",
 ]
+"api.py" = ["PLR0913"]
 
 [tool.ruff.format]
 exclude = ["amazon_paapi/sdk/*", "docs/*", ".github"]