Skip to content

Commit 07a461f

Browse files
committed
Revert "Build correct externalID"
This reverts commit 3d20db6.
1 parent 3d20db6 commit 07a461f

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

serverscom/instances_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,7 @@ func TestInstances_InstanceIDWithCloudInstance(t *testing.T) {
332332
providerID, err := instances.InstanceID(ctx, types.NodeName(nodeName))
333333

334334
g.Expect(err).To(BeNil())
335-
g.Expect(providerID).To(Equal("serverscom://cloud-instance/a"))
335+
g.Expect(providerID).To(Equal("cloud-instance/a"))
336336
}
337337

338338
func TestInstances_InstanceIDWithDedicatedServer(t *testing.T) {
@@ -380,7 +380,7 @@ func TestInstances_InstanceIDWithDedicatedServer(t *testing.T) {
380380
providerID, err := instances.InstanceID(ctx, types.NodeName(nodeName))
381381

382382
g.Expect(err).To(BeNil())
383-
g.Expect(providerID).To(Equal("serverscom://dedicated-server/a"))
383+
g.Expect(providerID).To(Equal("dedicated-server/a"))
384384
}
385385

386386
func TestInstances_InstanceIDWithKubernetesBaremetalNode(t *testing.T) {
@@ -428,7 +428,7 @@ func TestInstances_InstanceIDWithKubernetesBaremetalNode(t *testing.T) {
428428
providerID, err := instances.InstanceID(ctx, types.NodeName(nodeName))
429429

430430
g.Expect(err).To(BeNil())
431-
g.Expect(providerID).To(Equal("serverscom://kubernetes-baremetal-node/a"))
431+
g.Expect(providerID).To(Equal("kubernetes-baremetal-node/a"))
432432
}
433433

434434
func TestInstances_InstanceTypeWithCloudInstance(t *testing.T) {

serverscom/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ func collectHostAddresses(host *cli.Host) []v1.NodeAddress {
109109
}
110110

111111
func buildExternalID(instanceType, ID string) string {
112-
return fmt.Sprintf("%s://%s/%s", providerName, instanceType, ID)
112+
return fmt.Sprintf("%s/%s", instanceType, ID)
113113
}
114114

115115
func getLoadBalancerName(srv *v1.Service, clusterName string) string {

0 commit comments

Comments
 (0)