Skip to content

Commit 5b501bf

Browse files
committed
fix: created DB row types, domain types, added mappers and fixed service - formatte code [no ci]
1 parent b633dc8 commit 5b501bf

7 files changed

Lines changed: 25 additions & 31 deletions

File tree

packages/backend/src/db/mappers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,4 @@ export function mapDocument(r: DocumentRow): Document {
4848
updatedAt: r.updated_at,
4949
readonly: false,
5050
};
51-
}
51+
}

packages/backend/src/db/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ export type DocumentRow = {
3737
status: string;
3838
created_at: Date;
3939
updated_at: Date;
40-
};
40+
};

packages/backend/src/domain/types.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,4 +39,4 @@ export type Document = {
3939
createdAt: Date;
4040
updatedAt: Date;
4141
readonly: boolean;
42-
};
42+
};

packages/backend/src/routes/assets.routes.ts

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,13 @@ router.get('/bpmn/by-bpmn-id/:bpmnProcessId', async (req: Request, res: Response
7575
try {
7676
const result = await getBpmnByBpmnProcessId(req.params.bpmnProcessId);
7777
if (!result)
78-
return res
79-
.status(404)
80-
.json({
81-
success: false,
82-
error: {
83-
code: 'NOT_FOUND',
84-
message: `No process found for bpmnProcessId: ${req.params.bpmnProcessId}`,
85-
},
86-
});
78+
return res.status(404).json({
79+
success: false,
80+
error: {
81+
code: 'NOT_FOUND',
82+
message: `No process found for bpmnProcessId: ${req.params.bpmnProcessId}`,
83+
},
84+
});
8785
res.json({ success: true, data: result });
8886
} catch (err) {
8987
logger.error('[assets] getBpmnByBpmnProcessId failed', { error: getErrorMessage(err) });

packages/backend/src/routes/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import vendorRoutes from './vendor.routes';
1212
import processRoutes from './process.routes';
1313
import edocsRoutes from './edocs.routes';
1414
import assetsRoutes from './assets.routes';
15-
import ropaRoutes from './ropa.routes';
15+
import ropaRoutes from './ropa.routes';
1616
import ropaPublicRoutes from './ropa.public.routes';
1717

1818
const router = Router();
@@ -38,7 +38,7 @@ router.use('/v1/process', processRoutes);
3838
router.use('/v1/edocs', edocsRoutes);
3939
router.use('/v1/assets', assetsRoutes);
4040
router.use('/v1/assets/ropa', ropaRoutes);
41-
router.use('/v1/ropa/public', ropaPublicRoutes);
41+
router.use('/v1/ropa/public', ropaPublicRoutes);
4242

4343
// Legacy /api/* routes (deprecated but working)
4444
router.use('/api/health', deprecationMiddleware('/v1/health'), healthRoutes);

packages/backend/src/routes/ropa.routes.ts

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,10 @@ const router = Router();
1515

1616
const dbRequired = (_req: Request, res: Response): boolean => {
1717
if (!pool) {
18-
res
19-
.status(503)
20-
.json({
21-
success: false,
22-
error: { code: 'DB_NOT_CONFIGURED', message: 'Asset storage not configured' },
23-
});
18+
res.status(503).json({
19+
success: false,
20+
error: { code: 'DB_NOT_CONFIGURED', message: 'Asset storage not configured' },
21+
});
2422
return false;
2523
}
2624
return true;
@@ -45,15 +43,13 @@ router.get('/by-bpmn-id/:bpmnProcessId', async (req, res) => {
4543
try {
4644
const result = await getRopaByBpmnProcessId(req.params.bpmnProcessId);
4745
if (!result)
48-
return res
49-
.status(404)
50-
.json({
51-
success: false,
52-
error: {
53-
code: 'NOT_FOUND',
54-
message: `No RoPA record for bpmnProcessId: ${req.params.bpmnProcessId}`,
55-
},
56-
});
46+
return res.status(404).json({
47+
success: false,
48+
error: {
49+
code: 'NOT_FOUND',
50+
message: `No RoPA record for bpmnProcessId: ${req.params.bpmnProcessId}`,
51+
},
52+
});
5753
res.json({ success: true, data: result });
5854
} catch (err) {
5955
logger.error('[ropa] getRopaByBpmnProcessId failed', { error: getErrorMessage(err) });

packages/backend/src/services/ropa.service.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,8 +91,8 @@ export async function upsertRopa(
9191
try {
9292
await client.query('BEGIN');
9393

94-
const { rows } = await client.query(
95-
`INSERT INTO ropa_records (
94+
const { rows } = await client.query(
95+
`INSERT INTO ropa_records (
9696
bpmn_process_id, process_level, title, controller_name, controller_contact,
9797
dpo_contact, purpose, legal_basis_uri, legal_basis_label, gdpr_article,
9898
data_subjects, recipients, third_country_transfers, third_country_details,

0 commit comments

Comments
 (0)