only 8 bits of Track::userfield are for user

Oher 8 bits of the mUserField are for the internal status bits

Author: shahor02

DataFormats/Reconstruction/include/ReconstructionDataFormats/TrackParametrization.h

@@ -249,8 +249,11 @@ class TrackParametrization
   GPUd() bool isValid() const;
   GPUd() void invalidate();
 
-  GPUhd() uint16_t getUserField() const;
-  GPUhd() void setUserField(uint16_t v);
+  GPUhd() uint8_t getUserField() const;
+  GPUhd() void setUserField(uint8_t v);
+
+  GPUhd() void setPerProjection(bool v) { setBit(0); }        // request perform operations per projection
+  GPUhd() bool isPerProjection() const { return testBit(0); } // perform operations per projection?
 
   GPUd() void printParam() const;
   GPUd() void printParamHexadecimal();
@@ -268,6 +271,11 @@ class TrackParametrization
 
   GPUd() yzerr_t getVertexInTrackFrame(const o2::dataformats::VertexBase& vtx) const;
 
+ protected:
+  GPUhd() void setBit(uint8_t b, bool v = true);
+  GPUhd() bool testBit(uint8_t b) const;
+  GPUhd() uint8_t getBits() const;
+
  private:
   //
   static constexpr value_t InvalidX = -99999.f;
@@ -740,16 +748,43 @@ GPUdi() void TrackParametrization<value_T>::invalidate()
   mX = InvalidX;
 }
 
+//____________________________________________________________
 template <typename value_T>
-GPUhdi() uint16_t TrackParametrization<value_T>::getUserField() const
+GPUhdi() void TrackParametrization<value_T>::setBit(uint8_t b, bool v)
 {
-  return mUserField;
+  if (v) {
+    mUserField |= ((0x1 << b) & 0xff);
+  } else {
+    mUserField &= ~((0x1 << b) & 0xff);
+  }
 }
 
+//____________________________________________________________
+template <typename value_T>
+GPUhdi() bool TrackParametrization<value_T>::testBit(uint8_t b) const
+{
+  return mUserField & ((0x1 << b) & 0xff);
+}
+
+//____________________________________________________________
+template <typename value_T>
+GPUhdi() uint8_t TrackParametrization<value_T>::getBits() const
+{
+  return (mUserField & 0xff);
+}
+
+//____________________________________________________________
+template <typename value_T>
+GPUhdi() uint8_t TrackParametrization<value_T>::getUserField() const
+{
+  return ((mUserField >> 8) & 0xff);
+}
+
+//____________________________________________________________
 template <typename value_T>
-GPUhdi() void TrackParametrization<value_T>::setUserField(uint16_t v)
+GPUhdi() void TrackParametrization<value_T>::setUserField(uint8_t v)
 {
-  mUserField = v;
+  mUserField |= uint16_t(v & 0xff) << 8;
 }
 
 //____________________________________________________________

Detectors/GlobalTrackingWorkflow/study/src/TrackMCStudy.cxx

@@ -802,7 +802,7 @@ void TrackMCStudy::processTPCTrackRefs()
       float tgL = trf.Pz() / pT;
       std::array<float, 5> pars = {secY, trf.Z(), std::sin(dphiPt), tgL, q / pT};
       auto& refTrack = mSelTRefs.emplace_back(secX, alpsec[sector], pars);
-      refTrack.setUserField(uint16_t(sector));
+      refTrack.setUserField(uint8_t(sector));
       nrefsSel++;
     }
     if (nrefsSel < params.minTPCRefsToExtractClRes) {

GPU/GPUTracking/DataTypes/GPUTRDInterfaceO2Track.h

@@ -70,11 +70,15 @@ class trackInterface<o2::track::TrackParCov> : public o2::track::TrackParCov
 
   GPUdi() bool CheckNumericalQuality() const { return true; }
 
-  GPUdi() void setPileUpDistance(uint8_t bwd, uint8_t fwd) { setUserField((((uint16_t)bwd) << 8) | fwd); }
-  GPUdi() bool hasPileUpInfo() const { return getUserField() != 0; }
+  GPUdi() void setPileUpDistance(uint8_t bwd, uint8_t fwd)
+  {
+    mPileUpDistanceFwd = fwd;
+    mPileUpDistanceBwd = bwd;
+  }
+  GPUdi() bool hasPileUpInfo() const { return (mPileUpDistanceFwd != 0) || (mPileUpDistanceBwd != 0); }
   GPUdi() bool hasPileUpInfoBothSides() const { return getPileUpDistanceBwd() > 0 && getPileUpDistanceFwd() > 0; }
-  GPUdi() uint8_t getPileUpDistanceBwd() const { return getUserField() >> 8; }
-  GPUdi() uint8_t getPileUpDistanceFwd() const { return getUserField() & 255; }
+  GPUdi() uint8_t getPileUpDistanceBwd() const { return mPileUpDistanceBwd; }
+  GPUdi() uint8_t getPileUpDistanceFwd() const { return mPileUpDistanceFwd; }
   GPUdi() uint16_t getPileUpSpan() const { return ((uint16_t)getPileUpDistanceBwd()) + getPileUpDistanceFwd(); }
   GPUdi() float getPileUpMean() const { return hasPileUpInfoBothSides() ? 0.5f * (getPileUpDistanceFwd() + getPileUpDistanceBwd()) : getPileUpDistanceFwd() + getPileUpDistanceBwd(); }
   GPUdi() float getPileUpTimeShiftMUS() const { return getPileUpMean() * o2::constants::lhc::LHCBunchSpacingMUS; }
@@ -85,8 +89,10 @@ class trackInterface<o2::track::TrackParCov> : public o2::track::TrackParCov
  private:
   o2::track::TrackLTIntegral mLTOut;
   o2::track::TrackParCov mParamOut;
+  uint8_t mPileUpDistanceFwd = 0;
+  uint8_t mPileUpDistanceBwd = 0;
 
-  ClassDefNV(trackInterface, 1);
+  ClassDefNV(trackInterface, 2);
 };
 
 } // namespace o2::gpu