fix(modern-js-plugin): adjust fetch type (module-federation#3825)

Author: 2heal1

.changeset/weak-spoons-begin.md

@@ -0,0 +1,5 @@
+---
+'@module-federation/modern-js': patch
+---
+
+fix(modern-js-plugin): adjust fetch type

packages/modernjs/src/cli/mfRuntimePlugins/auto-fetch-data.ts

@@ -63,18 +63,26 @@ const autoFetchData: () => FederationRuntimePlugin = () => ({
     }
 
     const dataFetchMap = getDataFetchMap();
-    const downgradeType = remoteSnapshot.modules.find(
-      (module) =>
-        module.moduleName === `${dataFetchName}${DATA_FETCH_CLIENT_SUFFIX}`,
-    )
+    const hasSSRAsset = Boolean(remoteSnapshot.ssrRemoteEntry);
+    const hasDataFetchClient = Boolean(
+      remoteSnapshot.modules.find(
+        (module) =>
+          module.moduleName === `${dataFetchName}${DATA_FETCH_CLIENT_SUFFIX}`,
+      ),
+    );
+    const downgradeType = hasDataFetchClient
       ? MF_DATA_FETCH_TYPE.FETCH_CLIENT
-      : MF_DATA_FETCH_TYPE.FETCH_SERVER;
+      : hasSSRAsset
+        ? MF_DATA_FETCH_TYPE.FETCH_SERVER
+        : MF_DATA_FETCH_TYPE.FETCH_CLIENT;
     let finalDataFetchId = dataFetchId;
 
     if (typeof window !== 'undefined') {
       finalDataFetchId =
         downgradeType === MF_DATA_FETCH_TYPE.FETCH_CLIENT
-          ? `${dataFetchId}${DATA_FETCH_CLIENT_SUFFIX}`
+          ? hasDataFetchClient
+            ? `${dataFetchId}${DATA_FETCH_CLIENT_SUFFIX}`
+            : dataFetchId
           : dataFetchId;
     }
 

packages/node/src/runtimePlugin.ts

@@ -176,6 +176,7 @@ export const resolveUrl = (
   } catch {
     const entryUrl =
       returnFromCache(remoteName) || returnFromGlobalInstances(remoteName);
+
     if (!entryUrl) return null;
 
     const url = new URL(entryUrl);