find not fully supported

[tdjastrzebski]

I just made the first attempt to use shx.
shx find BUILD/debug -type f -name '*.o'
yields find: no such file or directory: -type

[nfischer]

This is a known limitation of ShellJS's find() method. First step would be supporting the -type flag over there. I think shx could translate "-name" to shelljs's expected syntax, similar to how we translate sed's syntax:

shx/src/shx.js

Lines 95 to 100 in 7e7bf7f

	// Workaround for sed syntax
	let ret;
	if (fnName === 'sed') {
	const newArgs = convertSedRegex(args);
	ret = shell[fnName].apply(input, newArgs);
	} else {

[tdjastrzebski]

It looks -name flag is not fully supported as well.
shx find BUILD/debug -name '*.o'
results in find: no such file or directory: -name

[nfischer]

-name is just the default argument. Try cd BUILD/debug && shx find '**/*.o'.

[tdjastrzebski]

Well, yes, of course. The point, however, is still valid. -name flag is not supported.

[nfischer]

My point above was that we could probably translate that within shx itself (merge default arg + -name into shelljs's expected input). But there's little point for doing so right now because shell.find() is just a wrapper around shell.ls() (you could just use shx ls for the same effect). If we implement -type, then shell.find() would bring something valuable to the table.

[carlocorradini]

Any update on this? Thanks 😥

[carlocorradini]

Sorry for bothering you, but does the following work?

npx shx find "scripts/**/*.sh" -exec npx shellcheck {} \;

Or there is another (supported) approach? Thanks