Remove unnecessary comparison from is_local_port_fixed

shioimm · shioimm · commit 327814605e6d · 2025-12-28T15:34:09.000+09:00
Simplify the conditions:
- Return false if the port is 0 or a negative number
- Return true if the port is a positive number
diff --git a/ext/socket/ipsocket.c b/ext/socket/ipsocket.c
@@ -258,6 +258,7 @@ is_specified_ip_address(const char *hostname)
             inet_pton(AF_INET, hostname, &ipv4addr) == 1);
 }
 
+
 static int
 is_local_port_fixed(const char *portp)
 {
@@ -269,9 +270,8 @@ is_local_port_fixed(const char *portp)
 
     if (endp == portp) return 0;
     if (errno == ERANGE) return 0;
-    if (port <= 0) return 0;
 
-    return port != 0;
+    return port > 0;
 }
 
 struct fast_fallback_inetsock_arg

Original file line number	Diff line number	Diff line change
`@@ -258,6 +258,7 @@ is_specified_ip_address(const char *hostname)`
`258`	`258`	`inet_pton(AF_INET, hostname, &ipv4addr) == 1);`
`259`	`259`	`}`
`260`	`260`
	`261`	`+`
`261`	`262`	`static int`
`262`	`263`	`is_local_port_fixed(const char *portp)`
`263`	`264`	`{`
`@@ -269,9 +270,8 @@ is_local_port_fixed(const char *portp)`
`269`	`270`
`270`	`271`	`if (endp == portp) return 0;`
`271`	`272`	`if (errno == ERANGE) return 0;`
`272`		`- if (port <= 0) return 0;`
`273`	`273`
`274`		`- return port != 0;`
	`274`	`+ return port > 0;`
`275`	`275`	`}`
`276`	`276`
`277`	`277`	`struct fast_fallback_inetsock_arg`