Skip to content

Commit 7742265

Browse files
committed
Fix $PATH expansion in su -c to resolve "spawn sh ENOENT" in npm install
1 parent f498313 commit 7742265

3 files changed

Lines changed: 10 additions & 10 deletions

File tree

features/src/node-packages/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"id": "node-packages",
3-
"version": "1.0.0",
3+
"version": "1.0.1",
44
"name": "Node Packages",
55
"documentationURL": "https://github.com/shokkunrf/develop/tree/main/features/src/node-packages",
66
"description": "Installs specified npm packages globally",

features/src/node-packages/install.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ EOF
4646

4747
# User has write permission (e.g., devcontainer images with nvm)
4848
if su "$_REMOTE_USER" -c "test -w '$npm_prefix/lib/node_modules'" 2>/dev/null; then
49-
su - "$_REMOTE_USER" -c "PATH='$npm_bin_dir:\$PATH' npm install -g $packages"
49+
su - "$_REMOTE_USER" -c "PATH=$npm_bin_dir:\$PATH npm install -g $packages"
5050
return 0
5151
fi
5252

@@ -61,7 +61,7 @@ export NPM_CONFIG_PREFIX="$npm_global"
6161
export PATH="$npm_global/bin:\$PATH"
6262
EOF
6363

64-
su - "$_REMOTE_USER" -c "PATH='$npm_bin_dir:\$PATH' NPM_CONFIG_PREFIX='$npm_global' npm install -g $packages"
64+
su - "$_REMOTE_USER" -c "PATH=$npm_bin_dir:\$PATH NPM_CONFIG_PREFIX=$npm_global npm install -g $packages"
6565
export PATH="$npm_global/bin:$PATH"
6666
}
6767

features/test/node-packages/scenarios.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
"features": {
55
"ghcr.io/devcontainers/features/node:1": {},
66
"node-packages": {
7-
"packages": "@devcontainers/cli,prettier"
7+
"packages": "@devcontainers/cli,prettier,@google/gemini-cli"
88
}
99
}
1010
},
1111
"official-node-debian": {
1212
"image": "node:24",
1313
"features": {
1414
"node-packages": {
15-
"packages": "@devcontainers/cli,prettier"
15+
"packages": "@devcontainers/cli,prettier,@google/gemini-cli"
1616
}
1717
},
1818
"remoteUser": "node"
@@ -21,7 +21,7 @@
2121
"image": "node:24-alpine",
2222
"features": {
2323
"node-packages": {
24-
"packages": "@devcontainers/cli,prettier"
24+
"packages": "@devcontainers/cli,prettier,@google/gemini-cli"
2525
}
2626
},
2727
"remoteUser": "node"
@@ -31,7 +31,7 @@
3131
"features": {
3232
"ghcr.io/devcontainers/features/node:1": {},
3333
"node-packages": {
34-
"packages": "@devcontainers/cli,prettier"
34+
"packages": "@devcontainers/cli,prettier,@google/gemini-cli"
3535
}
3636
},
3737
"remoteUser": "vscode"
@@ -41,7 +41,7 @@
4141
"features": {
4242
"ghcr.io/devcontainers/features/node:1": {},
4343
"node-packages": {
44-
"packages": "@devcontainers/cli,prettier"
44+
"packages": "@devcontainers/cli,prettier,@google/gemini-cli"
4545
}
4646
}
4747
},
@@ -50,7 +50,7 @@
5050
"features": {
5151
"ghcr.io/devcontainers/features/node:1": {},
5252
"node-packages": {
53-
"packages": "@devcontainers/cli,prettier"
53+
"packages": "@devcontainers/cli,prettier,@google/gemini-cli"
5454
}
5555
},
5656
"remoteUser": "vscode"
@@ -59,7 +59,7 @@
5959
"image": "mcr.microsoft.com/devcontainers/javascript-node:24",
6060
"features": {
6161
"node-packages": {
62-
"packages": "@devcontainers/cli,prettier"
62+
"packages": "@devcontainers/cli,prettier,@google/gemini-cli"
6363
}
6464
},
6565
"remoteUser": "node"

0 commit comments

Comments
 (0)