Black (#2)

* Added Hound Badge to the README, and ran python modernize.

* Ran black

* Added the black badge to the README.

* Added Azure config.

* Adds the Azure build badge to the README.

Author: pscadding

.pre-commit-config.yaml

@@ -0,0 +1,39 @@
+# Copyright (c) 2019 Shotgun Software Inc.
+#
+# CONFIDENTIAL AND PROPRIETARY
+#
+# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit
+# Source Code License included in this distribution package. See LICENSE.
+# By accessing, using, copying or modifying this work you indicate your
+# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights
+# not expressly granted therein are reserved by Shotgun Software Inc.
+
+# Styles the code properly
+# Exclude the UI files, as they are auto-generated.
+exclude: "ui\/.*py$"
+# List of super useful formatters.
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v2.4.0
+    hooks:
+    # Ensures the code is syntaxically correct
+    - id: check-ast
+      language_version: python3
+    # Ensures a file name will resolve on all platform
+    - id: check-case-conflict
+    # Checks files with the execute bit set have shebangs
+    - id: check-executables-have-shebangs
+    # Ensure there's no incomplete merges
+    - id: check-merge-conflict
+    # Adds an empty line if missing at the end of a file.
+    - id: end-of-file-fixer
+    # Makes sure requirements.txt is properly formatted
+    - id: requirements-txt-fixer
+    # Removes trailing whitespaces.
+    - id: trailing-whitespace
+  # Leave black at the bottom so all touchups are done before it is run.
+  - repo: https://github.com/ambv/black
+    rev: 19.10b0
+    hooks:
+    - id: black
+      language_version: python3

LICENSE

@@ -4,9 +4,9 @@ Version: 7/07/2013
 
 Shotgun Software Inc. ("Company") provides the Shotgun Pipeline Toolkit,
 software, including source code, in this package or repository folder (the
-"Shotgun Toolkit Code") subject to your acceptance of and compliance with 
+"Shotgun Toolkit Code") subject to your acceptance of and compliance with
 the following terms and conditions (the "License Terms"). By accessing,
-downloading, copying, using or modifying any of the Shotgun Toolkit Code, 
+downloading, copying, using or modifying any of the Shotgun Toolkit Code,
 you agree to these License Terms.
 
 Eligibility
@@ -33,7 +33,7 @@ to the Shotgun Toolkit Code or any of Company's other software or intellectual
 property rights. You agree not to take any action with respect to the Shotgun
 Toolkit Code that is not expressly authorized above.
 
-You must keep intact (and, in the case of copies, reproduce) all copyright 
+You must keep intact (and, in the case of copies, reproduce) all copyright
 and other proprietary notices, including all references to and copies of these
 License Terms, as originally included on, in, or with the Shotgun Toolkit
 Code. You must ensure that all derivative works you make of the Shotgun
@@ -64,7 +64,7 @@ Company).
 Liability
 
 You agree to be solely responsible for your use and modifications of the
-Shotgun Toolkit Code, and for any harm or liability arising out of such use 
+Shotgun Toolkit Code, and for any harm or liability arising out of such use
 or modifications, including but not limited to any liability for infringement
 of third-party intellectual property rights.
 
@@ -78,7 +78,7 @@ advised of the possibility of such damages; and (b) in any event, Company's
 aggregate liability under these License Terms or in connection with the
 Shotgun Toolkit Code, regardless of the form of action and under any theory
 (whether in contract, tort, statutory, or otherwise), will not exceed the
-greater of $50 or the amount (if any) that you actually paid for access to 
+greater of $50 or the amount (if any) that you actually paid for access to
 the Shotgun Toolkit Code.
 
 Ownership
@@ -115,7 +115,7 @@ Company grants you a non-exclusive right to continue to modify, make
 derivative works of, reproduce, and use the Contribution for your
 non-commercial or internal business purposes, and to further Company's
 development of Company Programs. This grant does not: (a) limit Company's
-rights, (b) grant you any rights with respect to the Company Programs; nor 
+rights, (b) grant you any rights with respect to the Company Programs; nor
 (c) permit you to distribute, operate for the benefit of third parties (for
 example, on a hosted basis), or otherwise commercially exploit the
 Contribution.
@@ -143,4 +143,4 @@ employees, and agents against any and all claims, actions or damages
 account of a breach or alleged breach of the foregoing warranty. You make no
 other express or implied warranty (including without limitation any warranty
 of merchantability or fitness for a particular purpose) regarding the
-Contribution.
+Contribution.

README.md

@@ -1,3 +1,7 @@
+[![Build Status](https://dev.azure.com/shotgun-ecosystem/Toolkit/_apis/build/status/Apps/tk-multi-devutils?branchName=master)](https://dev.azure.com/shotgun-ecosystem/Toolkit/_build/latest?definitionId=78&branchName=master)
+[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)
+[![Linting](https://img.shields.io/badge/PEP8%20by-Hound%20CI-a873d1.svg)](https://houndci.com)
+
 ## Documentation
 This repository is a part of the Shotgun Pipeline Toolkit.
 
@@ -6,7 +10,7 @@ This repository is a part of the Shotgun Pipeline Toolkit.
 - For information about Shotgun in general, click here: http://www.shotgunsoftware.com/toolkit
 
 ## Using this app in your Setup
-All the apps that are part of our standard app suite are pushed to our App Store. 
+All the apps that are part of our standard app suite are pushed to our App Store.
 This is where you typically go if you want to install an app into a project you are
 working on. For an overview of all the Apps and Engines in the Toolkit App Store,
 click here: https://support.shotgunsoftware.com/entries/95441247.

app.py

@@ -1,11 +1,11 @@
 # Copyright (c) 2018 Shotgun Software Inc.
-# 
+#
 # CONFIDENTIAL AND PROPRIETARY
-# 
-# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit 
+#
+# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit
 # Source Code License included in this distribution package. See LICENSE.
-# By accessing, using, copying or modifying this work you indicate your 
-# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights 
+# By accessing, using, copying or modifying this work you indicate your
+# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights
 # not expressly granted therein are reserved by Shotgun Software Inc.
 
 import os
@@ -36,9 +36,7 @@ def init_app(self):
             "type": "context_menu",
         }
         self.engine.register_command(
-            "New config sandbox...",
-            self._new_config_sandbox,
-            menu_options
+            "New config sandbox...", self._new_config_sandbox, menu_options
         )
 
         # certain menu options are only available if you
@@ -52,9 +50,7 @@ def init_app(self):
                 "type": "context_menu",
             }
             self.engine.register_command(
-                "Open config location on disk",
-                self._jump_to_dev_area,
-                menu_options
+                "Open config location on disk", self._jump_to_dev_area, menu_options
             )
 
             # command to check for updates
@@ -64,9 +60,7 @@ def init_app(self):
                 "type": "context_menu",
             }
             self.engine.register_command(
-                "Check for config updates...",
-                self._updates,
-                menu_options
+                "Check for config updates...", self._updates, menu_options
             )
 
             # command to validate
@@ -76,32 +70,22 @@ def init_app(self):
                 "type": "context_menu",
             }
             self.engine.register_command(
-                "Check for core updates...",
-                self._check_core_updates,
-                menu_options
+                "Check for core updates...", self._check_core_updates, menu_options
             )
 
     def _updates(self):
         """
         Callback to launch check for updates tank command
         """
         command_runner = self.import_module("command_runner")
-        command_runner.show_dialog(
-            self,
-            "Check for Updates",
-            "updates"
-        )
+        command_runner.show_dialog(self, "Check for Updates", "updates")
 
     def _check_core_updates(self):
         """
         Callback to launch the validate tank command
         """
         command_runner = self.import_module("command_runner")
-        command_runner.show_dialog(
-            self,
-            "Check for core updates",
-            "core"
-        )
+        command_runner.show_dialog(self, "Check for core updates", "core")
 
     def _new_config_sandbox(self):
         """

azure-pipelines.yml

@@ -0,0 +1,43 @@
+# Copyright (c) 2019 Shotgun Software Inc.
+#
+# CONFIDENTIAL AND PROPRIETARY
+#
+# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit
+# Source Code License included in this distribution package. See LICENSE.
+# By accessing, using, copying or modifying this work you indicate your
+# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights
+# not expressly granted therein are reserved by Shotgun Software Inc.
+
+# Imports the shared Azure CI tools
+resources:
+  repositories:
+    - repository: templates
+      type: github
+      name: shotgunsoftware/tk-ci-tools
+      ref: refs/heads/master
+      endpoint: shotgunsoftware
+
+# We want builds to trigger for 3 reasons:
+# - The master branch sees new commits
+# - Each PR should get rebuilt when commits are added to it.
+# - When we tag something
+trigger:
+  branches:
+    include:
+    - master
+  tags:
+    include:
+    - v*
+pr:
+  branches:
+    include:
+    - "*"
+
+# This pulls in a variable group from Azure. Variables can be encrypted or not.
+variables:
+- group: deploy-secrets
+
+jobs:
+- template: build-pipeline.yml@templates
+  parameters:
+    skip_tests: true

info.yml

@@ -1,33 +1,32 @@
 # Copyright (c) 2018 Shotgun Software Inc.
-# 
+#
 # CONFIDENTIAL AND PROPRIETARY
-# 
-# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit 
+#
+# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit
 # Source Code License included in this distribution package. See LICENSE.
-# By accessing, using, copying or modifying this work you indicate your 
-# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights 
+# By accessing, using, copying or modifying this work you indicate your
+# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights
 # not expressly granted therein are reserved by Shotgun Software Inc.
 
 configuration:
 
 # the Shotgun fields that this app needs in order to operate correctly
 requires_shotgun_fields:
 
-# More verbose description of this item 
+# More verbose description of this item
 display_name: "Developer Tools"
 description: "Tools for development."
 
 # Required minimum versions for this item to run
 requires_shotgun_version:
 requires_core_version: "v0.18.158"
-requires_engine_version: 
+requires_engine_version:
 
-# this app works in all engines - it does not contain 
+# this app works in all engines - it does not contain
 # any host application specific commands
-supported_engines: 
+supported_engines:
 
 # the frameworks required to run this app
 frameworks:
     - {"name": "tk-framework-shotgunutils", "version": "v5.x.x"}
     - {"name": "tk-framework-qtwidgets", "version": "v2.x.x", "minimum_version": "v2.7.0"}
-    

python/__init__.py

@@ -1,11 +1,11 @@
 # Copyright (c) 2018 Shotgun Software Inc.
-# 
+#
 # CONFIDENTIAL AND PROPRIETARY
-# 
-# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit 
+#
+# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit
 # Source Code License included in this distribution package. See LICENSE.
-# By accessing, using, copying or modifying this work you indicate your 
-# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights 
+# By accessing, using, copying or modifying this work you indicate your
+# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights
 # not expressly granted therein are reserved by Shotgun Software Inc.
 
 from . import create_sandbox

python/command_runner/__init__.py

@@ -1,11 +1,11 @@
 # Copyright (c) 2018 Shotgun Software Inc.
-# 
+#
 # CONFIDENTIAL AND PROPRIETARY
-# 
-# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit 
+#
+# This work is provided "AS IS" and subject to the Shotgun Pipeline Toolkit
 # Source Code License included in this distribution package. See LICENSE.
-# By accessing, using, copying or modifying this work you indicate your 
-# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights 
+# By accessing, using, copying or modifying this work you indicate your
+# agreement to the Shotgun Pipeline Toolkit Source Code License. All rights
 # not expressly granted therein are reserved by Shotgun Software Inc.
 
 import sgtk

python/command_runner/dialog.py

@@ -65,7 +65,9 @@ def _doit(self):
         self._command_obj = None
 
         self._logger.info("")
-        self._logger.info("The command has finished execution. Press Close to continue.")
+        self._logger.info(
+            "The command has finished execution. Press Close to continue."
+        )
 
         # turn cancel button into close button
         self.ui.cancel.setEnabled(True)

python/command_runner/interact.py

@@ -15,7 +15,6 @@
 
 
 class QtInteraction(sgtk.CommandInteraction):
-
     def __init__(self, parent):
         self._parent = parent
         self._always_enabled = False
@@ -35,11 +34,7 @@ def request_input(self, message):
         :returns: Information entered by user.
         :rtype: str
         """
-        input, ok = QtGui.QInputDialog.getText(
-            self._parent,
-            "Shotgun",
-            message
-        )
+        input, ok = QtGui.QInputDialog.getText(self._parent, "Shotgun", message)
         return input
 
     def ask_yn_question(self, message):
@@ -54,7 +49,7 @@ def ask_yn_question(self, message):
             self._parent,
             "Shotgun",
             message,
-            QtGui.QMessageBox.Yes | QtGui.QMessageBox.No
+            QtGui.QMessageBox.Yes | QtGui.QMessageBox.No,
         )
 
         if res == QtGui.QMessageBox.Yes:
@@ -82,7 +77,7 @@ def ask_yna_question(self, message, force_prompt=False):
             self._parent,
             "Shotgun",
             message,
-            QtGui.QMessageBox.Yes | QtGui.QMessageBox.No | QtGui.QMessageBox.YesToAll
+            QtGui.QMessageBox.Yes | QtGui.QMessageBox.No | QtGui.QMessageBox.YesToAll,
         )
 
         if res == QtGui.QMessageBox.YesToAll: