Skip to content

Commit 1bcee94

Browse files
committed
feat!: add version check
1 parent 6c9dedc commit 1bcee94

7 files changed

Lines changed: 20 additions & 8 deletions

File tree

pkg/api/client.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import (
99
"github.com/distribution/reference"
1010
"github.com/docker/docker/api/types/build"
1111
"github.com/docker/docker/api/types/image"
12-
"github.com/docker/docker/client"
1312
v1 "github.com/google/go-containerregistry/pkg/v1"
1413
"github.com/opencontainers/go-digest"
1514
"github.com/silenium-dev/docker-wrapper/pkg/client/provider"
@@ -51,7 +50,7 @@ type SystemClient interface {
5150
}
5251

5352
type ClientWrapper interface {
54-
client.APIClient
53+
DockerClient
5554
ClientBase
5655
ImageClient
5756
ContainerClient

pkg/api/docker.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package api
2+
3+
import (
4+
"context"
5+
6+
"github.com/docker/docker/client"
7+
)
8+
9+
type DockerClient interface {
10+
client.APIClient
11+
NewVersionError(ctx context.Context, APIrequired, feature string) error
12+
}

pkg/client/base.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import (
66
)
77

88
func (c *Client) Close() error {
9-
return c.APIClient.Close()
9+
return c.DockerClient.Close()
1010
}
1111

1212
func (c *Client) AuthProvider() provider.AuthProvider {

pkg/client/build.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ func (c *Client) ImageBuild(
1515
maps.Copy(authConfigs, opts.AuthConfigs)
1616
opts.AuthConfigs = authConfigs
1717

18-
return c.APIClient.ImageBuild(ctx, buildContext, opts)
18+
return c.DockerClient.ImageBuild(ctx, buildContext, opts)
1919
}

pkg/client/client.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,14 @@ import (
88

99
"github.com/docker/docker/client"
1010
client2 "github.com/docker/go-sdk/client"
11+
"github.com/silenium-dev/docker-wrapper/pkg/api"
1112
"github.com/silenium-dev/docker-wrapper/pkg/client/provider"
1213
"go.uber.org/zap"
1314
"go.uber.org/zap/exp/zapslog"
1415
)
1516

1617
type Client struct {
17-
client.APIClient
18+
api.DockerClient
1819
sdkClient *client2.Client
1920
dockerOpts []client.Opt
2021
authProvider provider.AuthProvider
@@ -43,7 +44,7 @@ func NewWithOpts(opts ...Opt) (*Client, error) {
4344
if err != nil {
4445
return nil, err
4546
}
46-
c.APIClient = cli
47+
c.DockerClient = cli
4748

4849
result := &client2.Client{}
4950
internal := (*sdkClient)(unsafe.Pointer(result))

pkg/client/image_pull.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ func (c *Client) ImagePullWithEvents(ctx context.Context, ref reference.Named, o
3838
return v1.Hash{}, nil, nil, err
3939
}
4040

41-
reader, err := c.APIClient.ImagePull(ctx, ref.String(), options)
41+
reader, err := c.ImagePull(ctx, ref.String(), options)
4242
if err != nil {
4343
return v1.Hash{}, nil, nil, err
4444
}

pkg/client/system.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ func (c *Client) SystemIsPodman(ctx context.Context) (bool, error) {
2222
}
2323

2424
func (c *Client) SystemDefaultPlatform(ctx context.Context) (*v1.Platform, error) {
25-
info, err := c.APIClient.Info(ctx)
25+
info, err := c.Info(ctx)
2626
if err != nil {
2727
return nil, err
2828
}

0 commit comments

Comments
 (0)