Fix LT-22295: Crash when switching to Texts and Words (#739)

* Fix LT-22295: Crash when switching to Texts and Words

* Respond to Hasso's comments

Author: jtmaxwell3

Src/LexText/Interlinear/InterlinDocForAnalysis.cs

@@ -310,8 +310,18 @@ public virtual void TriggerAnalysisSelected(AnalysisOccurrence target, bool fSav
 			RecordGuessIfNotKnown(target);
 			InstallFocusBox();
 			RootBox.DestroySelection();
-			FocusBox.SelectOccurrence(target);
-			SetFocusBoxSizeForVc();
+			try
+			{
+				// Suppress changing the FocusBox when called from VwDrawRootBufferedClass.Create()
+				// when the selected word has a different RTL from the text (LT-22295).
+				SuppressChanges = true;
+				FocusBox.SelectOccurrence(target);
+				SetFocusBoxSizeForVc();
+			}
+			finally
+			{
+				SuppressChanges = false;
+			}
 			SelectedOccurrence = target;
 
 			if (fShow)
@@ -1851,7 +1861,7 @@ internal FocusBoxController FocusBox
 		{
 			get
 			{
-				if ((ExistingFocusBox == null && ForEditing) || hasRightToLeftChanged)
+				if ((ExistingFocusBox == null && ForEditing) || hasRightToLeftChanged && !SuppressChanges)
 				{
 					CreateFocusBox();
 					previousRightToLeft = Vc.RightToLeft;
@@ -1991,6 +2001,8 @@ public override bool WantInitialSelection
 			get { return false; }
 		}
 
+		private bool SuppressChanges = false;
+
 		protected override void OnMouseDown(MouseEventArgs e)
 		{
 			// The base method does this too, but some paths in this method don't go through the base!