Move test execution before installer build (#774)

* Also increase test run timeout (to help slower dev boxes)

Author: jasonleenaylor

Test.runsettings

@@ -23,7 +23,7 @@
     <!-- Framework version - net48 -->
     <TargetFrameworkVersion>net48</TargetFrameworkVersion>
     <!-- Test timeout in milliseconds (10 minutes default for long-running tests) -->
-    <TestSessionTimeout>600000</TestSessionTimeout>
+    <TestSessionTimeout>900000</TestSessionTimeout>
     <!--
       InIsolation: Run tests in a separate process.
       This prevents native COM cleanup crashes from affecting VSTest's exit code.

build.ps1

@@ -525,6 +525,39 @@ try {
 			Write-Host "Output: Output\$Configuration" -ForegroundColor Cyan
 		}
 
+		# =============================================================================
+		# Test Execution (Optional)
+		# =============================================================================
+		# Run tests BEFORE the installer build because the installer's CleanAll target
+		# (enabled on CI via InstallerCleanProductOutputs=true) wipes Output/ and
+		# rebuilds without /p:BuildTests=true, removing all *Tests.dll assemblies.
+
+		if ($RunTests) {
+			Write-Host ""
+			Write-Host "Running tests..." -ForegroundColor Cyan
+
+			$testArgs = @{
+				Configuration = $Configuration
+				NoBuild       = $true
+			}
+			if ($TestFilter) {
+				$testArgs["TestFilter"] = $TestFilter
+			}
+
+			Stop-ConflictingProcesses @cleanupArgs
+			& "$PSScriptRoot\test.ps1" @testArgs
+			$script:testExitCode = $LASTEXITCODE
+			if ($script:testExitCode -eq 1) {
+				# VSTest exit code 1 means tests were skipped (or skipped+failed). test.ps1 prints a
+				# FAIL summary when there are actual failures, so treat exit code 1 as a warning only
+				# to avoid failing the build when the only non-passing tests were skipped.
+				Write-Warning "Test run exited with code 1 (skipped tests or failures). Check test output above for details."
+				$script:testExitCode = 0
+			} elseif ($script:testExitCode -ne 0) {
+				Write-Warning "Some tests failed (exit code: $($script:testExitCode)). Check output above for details."
+			}
+		}
+
 		if ($BuildInstaller -or $BuildPatch) {
 			if ($BuildPatch) {
 				$BaseOrPatch = "Patch"
@@ -575,36 +608,6 @@ try {
 			Write-Host "[OK] $BaseOrPatch build complete!" -ForegroundColor Green
 		}
 	}
-
-	# =============================================================================
-	# Test Execution (Optional)
-	# =============================================================================
-
-	if ($RunTests) {
-		Write-Host ""
-		Write-Host "Running tests..." -ForegroundColor Cyan
-
-		$testArgs = @{
-			Configuration = $Configuration
-			NoBuild       = $true
-		}
-		if ($TestFilter) {
-			$testArgs["TestFilter"] = $TestFilter
-		}
-
-		Stop-ConflictingProcesses @cleanupArgs
-		& "$PSScriptRoot\test.ps1" @testArgs
-		$script:testExitCode = $LASTEXITCODE
-		if ($script:testExitCode -eq 1) {
-			# VSTest exit code 1 means tests were skipped (or skipped+failed). test.ps1 prints a
-			# FAIL summary when there are actual failures, so treat exit code 1 as a warning only
-			# to avoid failing the build when the only non-passing tests were skipped.
-			Write-Warning "Test run exited with code 1 (skipped tests or failures). Check test output above for details."
-			$script:testExitCode = 0
-		} elseif ($script:testExitCode -ne 0) {
-			Write-Warning "Some tests failed (exit code: $($script:testExitCode)). Check output above for details."
-		}
-	}
 }
 finally {
 	# Kill any lingering build processes that might hold file locks