LT-21495: Move AddTexts to Pub/Sub

Cherry-pick from the PubSub branch to the main branch using
the following commands:
git cherry-pick --no-commit 11d9885
git cherry-pick --no-commit d431877

After the cherry-pick additional edits were made to:
1. resolve conflicts
2. Remove the Subscribe() and Unsubscribe() from
StatisticsView.cs. In this view the command is only executed
from the menu and toolbar. The GUI that would call Publish()
is not displayed.
3. standardize on the use of:
using static SIL.FieldWorks.Common.FwUtils.FwUtils;

Author: mark-sil

Src/LexText/Interlinear/InterlinearTextsRecordClerk.cs

@@ -37,6 +37,28 @@ public List<int> GetScriptureIds()
 			return (from st in GetInterestingTextList().ScriptureTexts select st.Hvo).ToList();
 		}
 
+		public override bool IsControllingTheRecordTreeBar
+		{
+			set
+			{
+				CheckDisposed();
+
+				// Nothing to do if we were already the active clerk or if we are not controlling the recordtreebar,
+				var oldActiveClerk = m_propertyTable.GetValue<RecordClerk>("ActiveClerk");
+				if (oldActiveClerk == this || !value)
+					return;
+
+				base.IsControllingTheRecordTreeBar = value;
+				Subscriber.Subscribe(EventConstants.AddTexts, AddTexts);
+			}
+		}
+
+		protected override void RemoveNotification()
+		{
+			Subscriber.Unsubscribe(EventConstants.AddTexts, AddTexts);
+			base.RemoveNotification();
+		}
+
 		protected override string FilterStatusContents(bool listIsFiltered)
 		{
 			var baseStatus = base.FilterStatusContents(listIsFiltered);
@@ -141,10 +163,25 @@ public void ParseInterstingTextsIfNeeded()
 			}
 		}
 
+		/// <summary>
+		/// Handler for the "Choose Texts..." menu item.
+		/// Triggered from: DistFiles/Language Explorer/Configuration/Words/areaConfiguration.xml
+		/// </summary>
 		protected internal bool OnAddTexts(object args)
 		{
 			CheckDisposed();
-			// get saved scripture choices
+			AddTexts(args);
+
+			return true;
+		}
+
+		/// <summary>
+		/// Method to handle published messages for AddTexts.
+		/// </summary>
+		protected internal void AddTexts(object args)
+		{
+			CheckDisposed();
+			// get saved texts choices
 			var interestingTextsList = GetInterestingTextList();
 			var interestingTexts = interestingTextsList.InterestingTexts.ToArray();
 
@@ -154,10 +191,11 @@ protected internal bool OnAddTexts(object args)
 				{
 					interestingTextsList.SetInterestingTexts(dlg.GetListOfIncludedTexts());
 					UpdateFilterStatusBarPanel();
+					ReloadIfNeeded();
 				}
 			}
 
-			return true;
+			return;
 		}
 
 		private InterestingTextList GetInterestingTextList()

Src/LexText/Interlinear/StatisticsView.cs

@@ -79,7 +79,7 @@ public void Init(Mediator mediator, PropertyTable propertyTable, XmlNode configu
 			m_clerk = (clerk == null || clerk is TemporaryRecordClerk) ?
 				(InterlinearTextsRecordClerk)RecordClerkFactory.CreateClerk(mediator, _propertyTable, configurationParameters, true, true) :
 				(InterlinearTextsRecordClerk)clerk;
-			// There's no record bar for it to control, but it should control the staus bar (e.g., it should update if we change
+			// There's no record bar for it to control, but it should control the status bar (e.g., it should update if we change
 			// the set of selected texts).
 			m_clerk.ActivateUI(true);
 			_areaName = XmlUtils.GetOptionalAttributeValue(configurationParameters, "area", "unknown");
@@ -237,14 +237,16 @@ public bool OnDisplayAddTexts(object commandObject, ref UIItemDisplayProperties
 			return true;
 		}
 
+		/// <summary>
+		/// Handler for the "Choose Texts..." menu item.
+		/// Triggered from: DistFiles/Language Explorer/Configuration/Words/areaConfiguration.xml
+		/// </summary>
 		public bool OnAddTexts(object args)
 		{
-			bool result = m_clerk.OnAddTexts(args);
-			if(result)
-			{
-				RebuildStatisticsTable();
-			}
-			return result;
+			CheckDisposed();
+			m_clerk.AddTexts(args);
+			RebuildStatisticsTable();
+			return true;
 		}
 
 		#endregion
@@ -254,7 +256,6 @@ public bool OnAddTexts(object args)
 		public bool PrepareToGoAway()
 		{
 			CheckDisposed();
-
 			return true;
 		}
 

Src/LexText/Interlinear/TextsFilterItem.cs

@@ -3,6 +3,8 @@
 // (http://www.gnu.org/licenses/lgpl-2.1.html)
 
 using SIL.FieldWorks.Common.Controls;
+using SIL.FieldWorks.Common.FwUtils;
+using static SIL.FieldWorks.Common.FwUtils.FwUtils;
 using SIL.LCModel.Core.KernelInterfaces;
 using SIL.LCModel;
 using XCore;
@@ -25,14 +27,7 @@ public TextsFilterItem(ITsString tssName, LcmCache cache, Mediator mediator) : b
 
 		public override bool Invoke()
 		{
-#pragma warning disable 618 // suppress obsolete warning
-			m_mediator.SendMessage("AddTexts", this);
-#pragma warning restore 618
-
-			//var clerk = RecordClerk.FindClerk(m_mediator, "interlinearTexts") as InterlinearTextsRecordClerk;
-			//if (clerk == null)
-			//    return false;
-			//clerk.OnAddTexts(null);
+			Publisher.Publish(new PublisherParameterObject(EventConstants.AddTexts, this));
 
 			return false; // Whatever the user did, we don't currently count it as changing the filter.
 		}

Src/xWorks/RecordClerk.cs

@@ -2014,7 +2014,7 @@ public static RecordClerk FindClerk(PropertyTable propertyTable, string id)
 		/// <summary>
 		/// Stop notifications of prop changes
 		/// </summary>
-		void RemoveNotification()
+		protected virtual void RemoveNotification()
 		{
 			Subscriber.Unsubscribe(EventConstants.FilterListChanged, FilterListChanged);