Remove ScrChecks project and replace with streamlined parser (#764)

* Delete entire Lib/src/ScrChecks/ project and tests
* Remove unused interfaces: IChecksDataSource, IScriptureCheck,
   RecordErrorEventArgs
* Remove ScrChecks from solution, build targets, installer targets
* Replace with ParseCharacterSequences in TextFileDataSource using
   StringInfo.GetTextElementEnumerator for correct Unicode handling
* Update CharContextCtrl and ValidCharactersDlg to remove
   reflection-based loading of ScrChecks
* Remove FwDirectoryFinder ScrChecks directory helper
* Add comprehensive tests for diacritics, surrogate pairs,
  supplementary plane chars, and minority language scripts

 The ScrChecks project under Lib/src was over-engineered for the
 limited functionality actually used by FieldWorks. Only character
 sequence parsing (grouping base characters with combining
 diacritics) was needed.

 Currently all the artifacts from projects under Lib\src are
 committed in DistFiles - leave that for future evaluation

 Co-Authored with Claude

Author: jasonleenaylor

Build/Installer.legacy.targets

@@ -296,10 +296,6 @@
 			<!-- REVIEW (Hasso) 2018.04: not sure if this is files or a folder -->
 			<MergeModules Include="$(OutputDirForConfig)\Python\**\*" />
 			<!-- REVIEW (Hasso) 2018.04: not sure if this is files or a folder -->
-			<MergeModules Include="$(OutputDirForConfig)\ScrChecks.dll" />
-			<!-- this will be taken from DistFiles\Editorial Checks -->
-			<MergeModules Include="$(OutputDirForConfig)\ScrChecks.pdb" />
-			<!-- this will be taken from DistFiles\Editorial Checks -->
 			<MergeModules Include="$(OutputDirForConfig)\SilEncConverters40.dll" />
 			<MergeModules Include="$(OutputDirForConfig)\SilEncConverters40.tlb" />
 			<MergeModules Include="$(OutputDirForConfig)\Temp\**\*" />

Build/Src/FwBuildTasks/CollectTargets.cs

@@ -129,8 +129,6 @@ public void Generate()
 			);
 			var infoEth = new DirectoryInfo(Path.Combine(m_fwroot, "Lib/src/Ethnologue"));
 			CollectInfo(infoEth);
-			var infoScr2 = new DirectoryInfo(Path.Combine(m_fwroot, "Lib/src/ScrChecks"));
-			CollectInfo(infoScr2);
 			var infoObj = new DirectoryInfo(Path.Combine(m_fwroot, "Lib/src/ObjectBrowser"));
 			CollectInfo(infoObj);
 
@@ -552,12 +550,6 @@ private void WriteTargetFiles()
 						writer.Write("\t<Target Name=\"{0}\"", project);
 						var bldr = new StringBuilder();
 						bldr.Append("Initialize"); // ensure the output directories and version files exist.
-						if (project == "ParatextImportTests" || project == "FwCoreDlgsTests")
-						{
-							// The ParatextImportTests and FwCoreDlgsTests require that the ScrChecks.dll be in DistFiles/Editorial Checks.
-							// We don't discover that dependency because it's not a reference (LT-13777).
-							bldr.Append(";ScrChecks");
-						}
 						var dependencies = m_mapProjDepends[project];
 						dependencies.Sort();
 						foreach (var dep in dependencies)

FieldWorks.sln

@@ -154,10 +154,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RootSite", "Src\Common\Root
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "RootSiteTests", "Src\Common\RootSite\RootSiteTests\RootSiteTests.csproj", "{EC934204-1D3A-5575-A500-CB7923C440E2}"
 EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ScrChecks", "Lib\src\ScrChecks\ScrChecks.csproj", "{0B5C69D2-8502-5FED-A22C-CE6A0269D9F1}"
-EndProject
-Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ScrChecksTests", "Lib\src\ScrChecks\ScrChecksTests\ScrChecksTests.csproj", "{37555756-6D42-5E46-B455-E58E3D1E8E0C}"
-EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ScriptureUtils", "Src\Common\ScriptureUtils\ScriptureUtils.csproj", "{8336DC7C-954B-5076-9315-D7DC5317282B}"
 EndProject
 Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "ScriptureUtilsTests", "Src\Common\ScriptureUtils\ScriptureUtilsTests\ScriptureUtilsTests.csproj", "{04546E35-9A3A-5629-8282-3683A5D848F9}"
@@ -725,18 +721,6 @@ Global
 		{EC934204-1D3A-5575-A500-CB7923C440E2}.Debug|x64.Build.0 = Debug|x64
 		{EC934204-1D3A-5575-A500-CB7923C440E2}.Release|x64.ActiveCfg = Release|x64
 		{EC934204-1D3A-5575-A500-CB7923C440E2}.Release|x64.Build.0 = Release|x64
-		{0B5C69D2-8502-5FED-A22C-CE6A0269D9F1}.Bounds|x64.ActiveCfg = Release|x64
-		{0B5C69D2-8502-5FED-A22C-CE6A0269D9F1}.Bounds|x64.Build.0 = Release|x64
-		{0B5C69D2-8502-5FED-A22C-CE6A0269D9F1}.Debug|x64.ActiveCfg = Debug|x64
-		{0B5C69D2-8502-5FED-A22C-CE6A0269D9F1}.Debug|x64.Build.0 = Debug|x64
-		{0B5C69D2-8502-5FED-A22C-CE6A0269D9F1}.Release|x64.ActiveCfg = Release|x64
-		{0B5C69D2-8502-5FED-A22C-CE6A0269D9F1}.Release|x64.Build.0 = Release|x64
-		{37555756-6D42-5E46-B455-E58E3D1E8E0C}.Bounds|x64.ActiveCfg = Release|x64
-		{37555756-6D42-5E46-B455-E58E3D1E8E0C}.Bounds|x64.Build.0 = Release|x64
-		{37555756-6D42-5E46-B455-E58E3D1E8E0C}.Debug|x64.ActiveCfg = Debug|x64
-		{37555756-6D42-5E46-B455-E58E3D1E8E0C}.Debug|x64.Build.0 = Debug|x64
-		{37555756-6D42-5E46-B455-E58E3D1E8E0C}.Release|x64.ActiveCfg = Release|x64
-		{37555756-6D42-5E46-B455-E58E3D1E8E0C}.Release|x64.Build.0 = Release|x64
 		{8336DC7C-954B-5076-9315-D7DC5317282B}.Bounds|x64.ActiveCfg = Release|x64
 		{8336DC7C-954B-5076-9315-D7DC5317282B}.Bounds|x64.Build.0 = Release|x64
 		{8336DC7C-954B-5076-9315-D7DC5317282B}.Debug|x64.ActiveCfg = Debug|x64